July 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 10:08:54 2024 +0000, Dmitry Timoshkov wrote: > I'd suggest to add a test. That test most likely will show that > GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every > VM in the Testbot. That means that your assumptions about > GetUserNameEx() behaviour are incorrect, and the code in your plugin > software won't work on at least some (I'd guess on most) of the Windows > computers. Therefore your implementation is incorrect as well. I will. Also, take a look at this: ![GetUserNameExW](/uploads/786f1b0d12cc9dffb024bb0a65e328ee/GetUserNameExW.mp4) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75893

1 0

[PATCH 0/1] MR6044: crypt32: Make CertFindCertificateInStore(CERT_FIND_ISSUER_NAME) work.
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6044

4 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:52:04 2024 +0000, Egor Poleshko wrote: > Nevermind, I apologise. I misunderstood how do the username values work > on local accounts. > From your and my observations, GetUserNameExW(3) performs several checks > before returning a result: > - If the user is connected to an Active Directory domain, return the > `displayName` value from the domain LDAP database. > - If the local user is linked to a Microsoft account, return the name > specified in it. > - Else, return `ERROR_NONE_MAPPED`. > The Microsoft Account part is tricky, because, as far as I know, Wine > doesn't provide a way to link the local user to a Microsoft account... > Maybe, my implementation will suffice? I'd suggest to add a test. That test most likely will show that GetUserNameEx(NameDisplay) returns an error ERROR_NONE_MAPPED on every VM in the Testbot. That means that your assumptions about GetUserNameEx() behaviour are incorrect, and the code in your plugin software won't work on at least some (I'd guess on most) of the Windows computers. Therefore your implementation is incorrect as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75890

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Thu Jul 11 09:01:15 2024 +0000, Dmitry Timoshkov wrote: > What do you mean? Nevermind, I apologise. I misunderstood how do the username values work on local accounts. >From your and my observations, GetUserNameExW(3) performs several checks before returning a result: - If the user is connected to an Active Directory domain, return the `displayName` value from the domain LDAP database. - If the local user is linked to a Microsoft account, return the name specified in it. - Else, return `ERROR_NONE_MAPPED`. The Microsoft Account part is tricky, because, as far as I know, Wine doesn't provide a way to link the local user to a Microsoft account... Maybe, my implementation will suffice? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75889

1 0

[PATCH v10 0/1] MR5968: cmd: Do not set enviroment variable when no input is provided by set /p command.
by Vijay Kiran Kamuju (＠infyquest) 11 Jul '24

11 Jul '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55662 Tests are not provided as its interactive. -- v10: cmd: Do not set enviroment variable when no input is provided by set /p command. https://gitlab.winehq.org/wine/wine/-/merge_requests/5968

3 3

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Dmitry Timoshkov (＠dmitry) 11 Jul '24

11 Jul '24

On Thu Jul 11 08:58:24 2024 +0000, Egor Poleshko wrote: > Does the user on that computer have an offline display name? > ![image](/uploads/c9944139127ec71cac7d2b2d1e19c834/image.png){width=318 height=100} What do you mean? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75886

1 0

Re: [PATCH v2 0/1] MR6002: secur32: Implement the NameDisplay name format of the GetUserNameExW method
by Egor Poleshko (＠somedevfox) 11 Jul '24

11 Jul '24

On Tue Jul 9 18:18:29 2024 +0000, Egor Poleshko wrote: > Hm, interesting. I'll experiment with this and make changes to my branch > accordingly. Thank you. Does the user on that computer have an offline display name? ![image](/uploads/c9944139127ec71cac7d2b2d1e19c834/image.png){width=318 height=100} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6002#note_75885

1 0

[PATCH v4 0/2] MR6021: nsiproxy.sys: Use net.inet.tcp.pcblist64 to enumerate connections on macOS.
by Tim Clem (＠tclem) 11 Jul '24

11 Jul '24

The handles returned by libproc (namely struct socket_info's soi_pcb) use all 64 bits, but the ones from the pcblist sysctl are truncated to 32. That makes find_owning_pid fail. The pcblist64 sysctl was added in macOS 10.6 and returns handles that match those from libproc. -- There does not seem to be a MIB constant for pcblist64, so I had to fetch it with sysctlbyname. -- v4: nsiproxy.sys: Use the pcblist64 sysctl to enumerate UDP connections on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/6021

5 7

[PATCH 0/6] MR6051: win32u: Move layered window attributes update out of the drivers.
by Rémi Bernon 11 Jul '24

11 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6051

1 6

[PATCH 0/2] MR6049: ntdll: Double-null-terminate registry multi-strings in RtlQueryRegistryValues.
by Alex Henrie (＠alexhenrie) 11 Jul '24

11 Jul '24

This reverts most of commit 2821a850d401dfabc5d76a4f40b0d6a42045fc5e which was a partial and ultimately improper solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6049

2 2