August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/2] MR6294: mlang: Fix bug when multibyte string truncation in ConvertINetMultiByteToUnicode
by Alexandre Julliard (＠julliard) 23 Aug '24

23 Aug '24

Alexandre Julliard (@julliard) commented about dlls/mlang/mlang.c: > default: > if (*pcSrcSize == -1) > *pcSrcSize = lstrlenA(pSrcStr); > - > + while (MultiByteToWideChar(dwEncoding, MB_ERR_INVALID_CHARS, pSrcStr, *pcSrcSize, 0, 0) == 0) > + { > + (*pcSrcSize)--; > + } This will truncate at the first invalid char, it would need a test to show that this is the correct behavior. Also it won't do the right thing for a zero-length string. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6294#note_79775

1 0

[PATCH 0/2] MR6346: winex11.drv: Properly check if the desktop window is fullscreen on multi-monitor systems.
by Zhiyi Zhang (＠zhiyi) 23 Aug '24

23 Aug '24

If there are two monitors and the primary monitor is on the right side and the virtual desktop resolution happens to be the same as the primary monitor, then the X11 desktop window will not have window frames and show as a fullscreen window before this patch. is_desktop_fullscreen() should check which monitor that it is on to decide whether to use fullscreen mode instead of always checking against the primary monitor. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6346

3 4

[PATCH v3 0/3] MR6317: comctl32: handle large tooltip icons
by Cherser-s (＠Cherser-s) 23 Aug '24

23 Aug '24

Added 32x32 icons for TTI_INFO_LARGE, TTI_WARNING_LARGE and TTI_ERROR_LARGE. User-defined icons passed through TTM_SETTITLE message are still drawn as 16x16 icons. -- v3: comctl32: changed tooltip icon indices to match the native library https://gitlab.winehq.org/wine/wine/-/merge_requests/6317

4 10

[PATCH 0/2] MR6343: comctl32/imagelist: Remove version check in ImageList_Read().
by Jacob Czekalla (＠JacobCzekalla) 23 Aug '24

23 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=18382 If an imagelist is created and stored to a file on windows using WriteEx(ImageList_WriteEx is not implemented in WINE), and it is read using ImageList_Read(), it should still read just fine on Windows. On WINE we see the version mismatch as it was made using V6 Comctl32 and WriteEx and return -1 instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6343

4 7

[PATCH v2 0/3] MR6333: odbccp32 valid dsn
by Alistair Leslie-Hughes (＠alesliehughes) 23 Aug '24

23 Aug '24

-- v2: odbccp32: SQLWrite/RemoveDSNFromIniW correctly handle config_mode odbccp32: SQLRemoveDSNFromIniW check for valid DSN before delete odbccp32: SQLValidDSNW return false on empty string. https://gitlab.winehq.org/wine/wine/-/merge_requests/6333

3 4

[PATCH v10 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect.
by Jacob Czekalla (＠JacobCzekalla) 23 Aug '24

23 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- v10: comctl32/edit: Fix incorrect size for format rect when it is smaller than text. https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

3 12

Re: [PATCH v4 0/1] MR6342: wscript: Implement Sleep - approved
by Jacek Caban (＠jacek) 23 Aug '24

23 Aug '24

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6342

1 0

[PATCH 0/7] MR6344: user32: Introduce a generic KeUserDispatchCallback kernel callback.
by Rémi Bernon 23 Aug '24

23 Aug '24

First part of a series that supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/1180, based on patches from Torge Matthies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6344

3 9

[PATCH v3 0/4] MR6331: win32u: Implement DPI scaled window surface.
by Rémi Bernon 23 Aug '24

23 Aug '24

Right now this should not do anything because all windows are per-monitor DPI aware. When this is changed this will automatically fall back to window surface scaling through `NtGdiStretchBlt` in win32u. This has the disadvantage that `NtGdiStretchBlt` is doing an absolutely terrible job at upscaling. This then adds a way for drivers to opt-in and do their own surface scaling before falling back to win32u. Alternatively and perhaps better, we could pull libcairo and use it to scale the surface contents with high quality filtering instead of using GDI. -- v3: win32u: Implement DPI scaled window surface. win32u: Move window_surface creation helper to dce.c. win32u: Map window rects DPI before calling into the drivers. win32u: Map window region DPI before calling into the drivers. https://gitlab.winehq.org/wine/wine/-/merge_requests/6331

2 6

[PATCH v7 0/8] MR5819: win32u: Fix DPI conversions in process_mouse_message.
by Rémi Bernon 23 Aug '24

23 Aug '24

-- v7: winex11: Map message pos to physical DPI in move_resize_window. win32u: Avoid changing thread DPI context in process_hardware_message. win32u: Factor hardware message point DPI mapping together. win32u: Use map_window_points with explicit DPI over screen_to_client. win32u: Split hardware message window lookup to a separate helper. win32u: Use per-monitor DPI window_from_point in process_mouse_message. win32u: Parameterize window_from_point dpi. server: Pass window's per-monitor DPI in set_window_pos. https://gitlab.winehq.org/wine/wine/-/merge_requests/5819

1 10