August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v20 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Ilia Docin (＠IDocin) 19 Aug '24

19 Aug '24

On Mon Aug 19 09:19:13 2024 +0000, Zhiyi Zhang wrote: > There should be a test failing on Wine in this patch. Then you add a > todo_wine to make the test pass in this commit. Then in the next patch > after you've fixed the bug, the todo_wine should get removed. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79103

1 0

[PATCH v3 0/2] MR6300: Draft: wined3d: Don't reject cross-device blits.
by Aida Jonikienė 19 Aug '24

19 Aug '24

I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures would be better like stated in the original change?) -- v3: HACK: wined3d: Don't assert in CS thread check. https://gitlab.winehq.org/wine/wine/-/merge_requests/6300

1 2

[PATCH 0/4] MR6255: mfplat: Some mf/winegstreamer fixes around pausing/unpausing a media session
by Torge Matthies (＠tmatthies) 19 Aug '24

19 Aug '24

Commit 1 prevents the media session from starting execution of an asynchronous operation while another asynchronous operation is still running. Without this, it was possible for invalid state transitions to happen, which could leave the session in an intermediary state (not stopped, started, paused, closed or shut down) indefinitely. Commits 2, 3 and 4 are some more fixes around pausing and unpausing in mfplat. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6255

5 8

[PATCH 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect when it is smaller than text.
by Jacob Czekalla (＠JacobCzekalla) 19 Aug '24

19 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

3 9

[PATCH 0/3] MR6286: win32u: Support setting host IME composition window position for ImmSetCompositionWindow().
by Zhiyi Zhang (＠zhiyi) 19 Aug '24

19 Aug '24

Based on the wine-staging patch winex11-CandidateWindowPos from Felix Yan with works from Muneyuki Noguchi and Sebastian Lackner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6286

3 10

Re: [PATCH v19 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) 19 Aug '24

19 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + DWORD r; > + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0); > + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0); > + > + hwnd = create_listview_control(LVS_REPORT); > + insert_item(hwnd, 0); > + insert_item(hwnd, 1); > + > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsAbove); > + expect(-1, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsBelow); > + expect(1, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsAbove); > + expect(0, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsBelow); > + expect(-1, r); There should be a test failing on Wine in this patch. Then you add a todo_wine to make the test pass in this commit. Then in the next patch after you've fixed the bug, the todo_wine should get removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79085

1 0

[PATCH v15 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 19 Aug '24

19 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v15: comctl32/tests: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

4 3

[PATCH v13 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 19 Aug '24

19 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v13: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 5

[PATCH 0/1] MR6309: win32u: Allocate and initialize window surface in window_surface_create.
by Rémi Bernon 19 Aug '24

19 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6309

1 1

[PATCH v3 0/2] MR6283: msvcr120: Implement feholdexcept.
by Daniel Lehman (＠dlehman25) 19 Aug '24

19 Aug '24

-- v3: msvcr120: Implement feholdexcept. msvcr120: Add feholdexcept stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6283

3 3