August 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR6304: comctl32/edit: Fix incorrect size for format rect when it is smaller than text.
by Jacob Czekalla (＠JacobCzekalla) 19 Aug '24

19 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56873 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6304

3 9

[PATCH 0/3] MR6286: win32u: Support setting host IME composition window position for ImmSetCompositionWindow().
by Zhiyi Zhang (＠zhiyi) 19 Aug '24

19 Aug '24

Based on the wine-staging patch winex11-CandidateWindowPos from Felix Yan with works from Muneyuki Noguchi and Sebastian Lackner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6286

3 10

Re: [PATCH v19 0/2] MR5909: comctl32/tests: Add LVM_GETNEXTITEM test.
by Zhiyi Zhang (＠zhiyi) 19 Aug '24

19 Aug '24

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + DWORD r; > + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0); > + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0); > + > + hwnd = create_listview_control(LVS_REPORT); > + insert_item(hwnd, 0); > + insert_item(hwnd, 1); > + > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsAbove); > + expect(-1, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsBelow); > + expect(1, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsAbove); > + expect(0, r); > + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsBelow); > + expect(-1, r); There should be a test failing on Wine in this patch. Then you add a todo_wine to make the test pass in this commit. Then in the next patch after you've fixed the bug, the todo_wine should get removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79085

1 0

[PATCH v15 0/1] MR6075: Add chevron visibility test to check the case of restoring band width to ideal value
by Ilia Docin (＠IDocin) 19 Aug '24

19 Aug '24

I prepared fix https://gitlab.winehq.org/wine/wine/-/commit/b45ad56, that I didn't provide test for, but now I find a way to check it. -- v15: comctl32/tests: Add rebar chevron visibility test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6075

4 3

[PATCH v13 0/2] MR6218: comctl32/treeview: Allow treeview parent to deny treeview expansion.
by Jacob Czekalla (＠JacobCzekalla) 19 Aug '24

19 Aug '24

When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727 -- v13: comctl32/treeview: Allow treeview parent to deny treeview expansion. comctl32/tests: Add test to check if treeview expansion can be denied. https://gitlab.winehq.org/wine/wine/-/merge_requests/6218

4 5

[PATCH 0/1] MR6309: win32u: Allocate and initialize window surface in window_surface_create.
by Rémi Bernon 19 Aug '24

19 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6309

1 1

[PATCH v3 0/2] MR6283: msvcr120: Implement feholdexcept.
by Daniel Lehman (＠dlehman25) 19 Aug '24

19 Aug '24

-- v3: msvcr120: Implement feholdexcept. msvcr120: Add feholdexcept stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6283

3 3

[PATCH v7 0/8] MR6031: Draft: wine: Use atomic locks insted pthread_mutex.
by Grigory Vasilyev (＠h0tc0d3) 18 Aug '24

18 Aug '24

I'm not sure about the need for this solution, so it's a **DRAFT**. For me it is an academic interest to check whether atomic locks will give advantages over pthread_mutex in games. First impressions are that games have become smoother, but need to think about tests that can actually be measured. Before build need define `WINE_USE_ATOMIC_LOCKS`. ```bash export CFLAGS="${CFLAGS} -DWINE_USE_ATOMIC_LOCKS" ``` -- v7: ws2_32: Add atomic lock support. wine32u: Add atomic lock support. winevulkan: Add atomic lock support. ntdll: Add atomic lock support. winewayland: Add atomic lock support. include: Define custom mutex macroses. msxml3: Fix compilation errors with Clang 18. configure: Change C standard to C17. https://gitlab.winehq.org/wine/wine/-/merge_requests/6031

2 10

[PATCH v3 0/7] MR6107: winewayland: Support GL/VK rendering in child windows
by Alexandros Frantzis (＠afrantzis) 18 Aug '24

18 Aug '24

At the moment GL/VK content can only be presented in top-level windows, since child windows are not backed by Wayland surfaces. This MR adds support for such scenarios, in a few gradual steps: 1. Create Wayland (sub)surfaces for all child windows, anchoring them to their parent surface, which may also be a child window surface (i.e., we support GL/VK in nested child windows). This approach works, but it pollutes the compositor with mostly unused, and possibly nested (sub)surfaces. We will deal with this later in the MR. 2. Ensure that the child window (sub)surfaces are properly updated and reconfigured, and support WS_POPUP <-> WS_CHILD style changes (reparenting etc). 3. In the second to last commit, improve efficiency by creating (sub)surfaces only for the child windows needed by GL/VK, and anchor them directly to the parent toplevel. This removes (sub)surface bloat and unnecessary nesting, the trade-off being some extra complexity when dealing with updates. 4. Finally improve the display of GDI content along with accelerated content. Note that this MR doesn't clip GL/VK child window contents at the moment. The subsurface mechanism introduced in this MR could also handle other kinds of windows in the future, for example display and properly position transient windows, menus etc. -- v3: winewayland: Create Wayland surfaces for child windows on demand. winewayland: Ensure parent surface contents for accelerated windows. winewayland: Support Wayland surface role changes. winewayland: Use weak references for parent wayland_surfaces. winewayland: Handle subsurface reconfiguration. winewayland: Create subsurfaces for child windows. winewayland: Store all window rects in wayland_win_data. https://gitlab.winehq.org/wine/wine/-/merge_requests/6107

3 13

[PATCH 0/1] MR6305: odbccp32: SQLWritePrivateProfileStringW correctly hanndle ODBC_BOTH_DSN
by Alistair Leslie-Hughes (＠alesliehughes) 18 Aug '24

18 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6305

4 3