August 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v8 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Elizabeth Figura (＠zfigura) 14 Aug '24

14 Aug '24

3/3 still needs to be fixed up to 1/3 where the class is introduced, including the actxprxy parts. There's also a whitespace error introduced in 2/3. Also, I'm just now noticing... > ``` > +HRESULT __RPC_STUB IEnumObjects_Next_Stub(IEnumObjects *This, ULONG celt, REFIID riid, void **rgelt, ULONG *pceltFetched) > +{ > + HRESULT hr; > + TRACE("(%p)->(%ld, %p, %p, %p)\n", This, celt, debugstr_guid(riid), rgelt, pceltFetched); > + *pceltFetched = 0; > + hr = IEnumObjects_Next(This, celt, riid, rgelt, pceltFetched); > + if (hr == S_OK) *pceltFetched = celt; > + return hr; > +} > ``` The "*pceltFetched = celt" line looks very wrong, and I don't think that line should be necessary at all. It was copied from IEnumShellItems, but that also looks wrong. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6130#note_78694

1 0

[PATCH v2 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon 14 Aug '24

14 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- v2: winebus.sys: Read vendor/product/serial strings from the usb subsystem. winebus.sys: Always parse uevent PRODUCT= line on input subsystem. winebus.sys: Add devtype parameter to get_device_subsystem_info(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

3 4

[PATCH 0/3] MR6276: winebus.sys: Improve udev device information parsing.
by Rémi Bernon 14 Aug '24

14 Aug '24

Supersedes https://gitlab.winehq.org/wine/wine/-/merge_requests/6268. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6276

4 10

[PATCH v7 0/3] MR6130: shell32: Added stubs for the EnumerableObjectCollection COM class.
by Kevin Martinez (＠kevinrmartinez) 14 Aug '24

14 Aug '24

Stub added for the IEnumObjects and IObjectCollection interfaces, so that programs won't crash when calling it. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53620 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56891 -- v7: actxprxy: Added IEnumObjects_Next_Proxy shell32: Added stub for IObjectCollection interface. shell32: Added stub for IEnumObjects interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/6130

2 7

[PATCH 0/1] MR6272: riched20: Release IME input context when done using it.
by Zhiyi Zhang (＠zhiyi) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6272

3 2

[PATCH v2 0/10] MR6273: win32u: Use window rects structs in more functions.
by Rémi Bernon 14 Aug '24

14 Aug '24

-- v2: win32u: Keep a window_rects struct in the WND structure. win32u: Pass a window_rects struct to calc_ncsize helper. win32u: Pass a window_rects struct from get_window_rects helper. win32u: Introduce new get_(client|window)_rect_rel helpers. win32u: Pass a window_rects struct to MoveWindowBits driver entry. win32u: Pass a window_rects struct to WindowPosChanging driver entry. win32u: Pass a window_rects struct to WindowPosChanged driver entry. win32u: Pass window_rects structs to create_window_surface. win32u: Use window_rects structs in apply_window_pos. win32u: Split driver side window bits move to a separate entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/6273

2 12

[PATCH 0/1] MR6244: configure: Use separate CPPFLAGS for PE cross targets.
by Billy Laws (＠bylaws) 14 Aug '24

14 Aug '24

Host CPPFLAGS may contain architecture or target specific flags that don't apply to a PE cross compiler, to pass CPPFLAGS in such a case CROSSCPPFLAGS can now be used. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6244

3 5

[PATCH 0/2] MR6277: mfplat, mf: Fix some MFCreateMediaBufferFromMediaType tests.
by Rémi Bernon 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6277

1 2

[PATCH 0/10] MR6273: win32u: Use window rects structs in more functions.
by Rémi Bernon 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6273

2 13

[PATCH 0/3] MR6274: odbc32: Parse incoming connection string in SQLBrowse/DriverConnct().
by Hans Leidekker (＠hans) 14 Aug '24

14 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6274

3 4