August 2024 - Wine-gitlab - list.winehq.org

[PATCH v4 0/2] MR6146: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The UK Kalender program was crashing when a new event was created as stated in the bug report. The fix is to create all the property sheet pages from the beginning instead of when they are selected. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54861 -- v4: comctl32/propsheet: Create pages with PSP_PREMATURE on initialization. comctl32/tests: Add test for propsheet page creation when propsheet gets initialized. https://gitlab.winehq.org/wine/wine/-/merge_requests/6146

4 4

[PATCH v7 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v7: comctl32: Fix sorting for listview. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 5

[PATCH v6 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v6: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

3 3

[PATCH 0/1] MR6185: include: Add gdiplus effect parameter structs.
by Vijay Kiran Kamuju (＠infyquest) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6185

3 2

[PATCH 0/8] MR6184: mshtml: Use JS bindings for style objects.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6184

3 9

[PATCH 0/1] MR6183: nsiproxy.sys: Fix the build on non-Apple, non-Linux systems
by Gerald Pfeifer (＠gerald) 02 Aug '24

02 Aug '24

commit 5261811d471 revamped the code around pcblist structures, alas assumes a variable mib is always present on non-Apple, non-Linux systems when it is not. And in any case, ARRAY_SIZE should be used for the actual structure it applies to, not a similar one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6183

4 3

[PATCH 0/1] MR6182: atl: Correct comment above AtlModuleRegisterTypeLib function.
by Alex Henrie (＠alexhenrie) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6182

3 2

[PATCH 0/1] MR6181: atl: Only warn in AtlModuleGetClassObject if the class was not found.
by Alex Henrie (＠alexhenrie) 02 Aug '24

02 Aug '24

A warning should only be printed if something went wrong, not every time the function is run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

3 2

[PATCH 0/2] MR6180: gdiplus: Fixes when compiling against wine headers.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6180

3 3

[PATCH 0/1] MR6179: include: Ensure that x86_64 syscall thunks have a consistent length when built with Clang.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

GCC always assembles `jmp 1f` to `eb 01`, as does Clang when using -O1 or higher optimization. But with -O0, Clang outputs `e9 01 00 00 00`. The `subq $0xb,0x70(%rcx)` line in __wine_syscall_dispatcher relies on `jmp 1f` being 2 bytes. Since Wine defaults to `-g -O2` for `CFLAGS`, this wouldn't show up with a default Clang build. But the FreeBSD `wine-devel` port must override `CFLAGS`, it uses Clang for PE and was crashing on launch. See <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280000>. Here are compiler explorer links to see the difference: [PE](https://godbolt.org/z/35TxW8dK9) and [ELF](https://godbolt.org/z/1h3j4c4ja). Adding -O1 to the clang side will make them equivalent. I may also report this as an LLVM bug, it doesn't seem like there's any reason why Clang would prefer the long form at `-O0`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6179

3 3