October 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR8342: user32/tests: Make sure testtext has enough null bytes at the end. - approved
by Alexandre Julliard (＠julliard) 28 Oct '25

28 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8342

1 0

Re: [PATCH v4 0/1] MR9169: include: Add missing AddrBStore to STACKFRAME in imagehlp.h - approved
by Alexandre Julliard (＠julliard) 28 Oct '25

28 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9169

1 0

[PATCH 0/7] MR9302: msxml3/tests: Add some SAX tests for PI nodes.
by Nikolay Sivov (＠nsivov) 28 Oct '25

28 Oct '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9302

2 7

[PATCH 0/1] MR9301: winemac.drv: Explicitly track the shape layer used for letter/pillarboxes.
by Tim Clem (＠tclem) 28 Oct '25

28 Oct '25

The content view's layer can have internal sublayers from Cocoa, so assuming anything about the hierarchy is dangerous and can result in us removing backing layers for visible content. --- Fixes solid grey fullscreen windows in some games. It's not clear to me why the content view layer only sometimes has sublayers; it may be a macOS version difference or something, but either way we should not assume anything about what's going on in there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9301

3 2

[PATCH 0/6] MR9300: vccorlib140: Platform::Exceptions stubs and tests.
by Piotr Caban (＠piotr) 28 Oct '25

28 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9300

2 8

[PATCH v2 0/1] MR7410: test-linux32: Disable broken tests that are already released broken
by Damien Zammit (＠zamaudio) 28 Oct '25

28 Oct '25

This should allow the CI to fully pass on this merge request. If it does, master branch could have CI tests enabled to ensure any actual broken test caused by a merge request is visible just by the CI status, and master can also reflect the passing status. Signed-off-by: Damien Zammit <damien(a)zamaudio.com> -- v2: test-linux32: Disable broken tests that are already released broken https://gitlab.winehq.org/wine/wine/-/merge_requests/7410

4 4

[PATCH 0/2] MR9299: ole32, combase: Add tests for COM context switching and delayed marshaling.
by Vibhav Pant (＠vibhavp) 28 Oct '25

28 Oct '25

When `RoGetAgileReference` is used with `AGILEREFERENCE_DELAYEDMARSHAL`, the returned `IAgileReference` also contains a reference to the apartment the object belongs to. Thus, when `IAgileReference::Resolve()` gets called, the object will get marshaled inside the owning apartment, not the caller's apartment. This seems to be made possible by the `IContextCallback` interface. It provides a way to (ab)use the marshaller to execute arbitrary code inside a COM context, which is an additional bit of state nested inside apartments. An apartment can contain multiple COM contexts, and the standard marshaller will keep track of which context a marshaled interface is bound to. All method calls through that marshalled pointer will be wrapped around a context-switch, even when the caller is in the same apartment. Additionally, creating an instance of the class `CLSID_IContextCallback` allows us to create new contexts inside an apartment. C++/WinRT makes use of `IContextCallback` to [implement support for C++ coroutines ](https://github.com/microsoft/cppwinrt/blob/ebace4abb8f48b6b9a612e8b84667e6044976a47/strings/base_coroutine_threadpool.h#L51)(co_await, et al) inside application STA code. Another use of COM contexts seems to be the UI code in WinRT applications, where certain objects can only be `Released`/destructed from the apartment they were created in. (I was able to find another instance of `IContextCallback` usage in the wild [here](https://github.com/Open-Shell/Open-Shell-Menu/blob/4ebeadd949d0550642…, to get an `IAccessible` implementation that has apartment-affinity). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9299

3 7

[PATCH 0/1] MR9298: ntdll: Remove unused parameter from linux_query_event_obj().
by Marc-Aurel Zent (＠mzent) 28 Oct '25

28 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9298

2 1

[PATCH 0/1] MR3228: Update heap.c removed return NULL at line 985. Prevents Wing Commander...
by James Carthew (＠dmjc) 28 Oct '25

28 Oct '25

Update heap.c removed return NULL at line 985. Prevents Wing Commander Prophecy and Secret Ops for loading/playing. Fixes WINE bug 55176. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3228

5 4

Re: [PATCH v8 0/5] MR9209: vccorlib140: Implement Platform::Exceptions.
by Piotr Caban (＠piotr) 28 Oct '25

28 Oct '25

I'm going to move some patches from this MR to a new one to make future reviews easier (this comment is mainly to make sure there's no work duplication). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_119861

1 0