October 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR9178: ntdll: Use load / acquire instruction to get pointer value in RtlRunOnceBeginInitialize
by Luca Bacci (＠lb90) 15 Oct '25

15 Oct '25

The `RtlRunOnce` family of functions are implemented using (a variant of) the Double Checked Locking Pattern (DCLP). The DCLP requires memory fences for correctness, on both the writer and reader sides. It's pretty obvious why it's needed on the writer side, but quite surprising that any is needed on the reader side! On strong memory model architectures (x86 and x86_64), only compiler-level fences are required. On weak memory model architectures like ARM64, instead, you need both CPU and compiler fences. That's explained well in books like _Concurrent Programming on Windows_ by Joe Duffy and in online resources like [1]. The Wine implementation has fences on the writing side (`RtlRunOnceComplete`). That's because `InterlockedCompareExchangePointer` inserts a full memory fence. However some code paths on the reader side (`RtlRunOnceBeginInitialize`) are missing fences, specifically the (`RTL_RUN_ONCE_CHECK_ONLY`) branch and the (`!RTL_RUN_ONCE_CHECK_ONLY && (val & 3) == 2`) branch. Add the missing fences using GCC's atomic builtins [2] Note: with this MR, the generated code should change only for ARM64 ### References: 1. [Double-Checked Locking is Fixed In C++11](https://preshing.com/20130930/double-checked-locking-is-fixed-in-cpp… 2. [GCC's Built-in Functions for Memory Model Aware Atomic Operations](https://gcc.gnu.org/onlinedocs/gcc/_005f_005fatomic-Builtins.ht… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9178

4 7

Re: [PATCH v3 0/6] MR8261: comctl32/tests: Check RGB value in test_alpha.
by Ziqing Hui (＠zhui) 15 Oct '25

15 Oct '25

On Fri Oct 10 03:30:29 2025 +0000, Zhiyi Zhang wrote: > Hi, Ziqing, the comctl32 v5 and v6 separation is done. You can use > __WINE_COMCTL32_VERSION to check the comctl32 version. See > https://gitlab.winehq.org/wine/wine/-/merge_requests/9150/diffs?commit_id=e… > for example. You can start working on v6 specific behaviors. Thanks a lot for your work! Now I can move this forwards. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8261#note_118575

1 0

[PATCH v11 0/3] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) 15 Oct '25

15 Oct '25

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v11: trace test failures https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 3

[PATCH 0/1] MR9179: bcrypt: Support import/export for generic ECDH/ECDSA algorithms.
by Hans Leidekker (＠hans) 15 Oct '25

15 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9179

2 1

[PATCH 0/1] MR9177: win32u: Fix deadlock caused by nested locking.
by Zhao Yi (＠Zhaoyi) 15 Oct '25

15 Oct '25

Convert surface lock to recursive mutex to allow same thread to acquire the lock multiple times, preventing deadlocks when lock_surface() and window_surface_lock() are called nestedly. Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9177

3 11

[PATCH 0/1] MR9169: include: Add missing AddrBStore to STACKFRAME in imagehlp.h
by Alistair Leslie-Hughes (＠alesliehughes) 15 Oct '25

15 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9169

3 2

[PATCH v10 0/3] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) 15 Oct '25

15 Oct '25

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v10: trace test failures https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 3

[PATCH v9 0/3] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) 15 Oct '25

15 Oct '25

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v9: trace test failures https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 3

[PATCH v8 0/2] MR8887: mf/tests: Test H.264 sink media type height alignment.
by Conor McCarthy (＠cmccarthy) 15 Oct '25

15 Oct '25

H.264 uses a 16-pixel alignment, and the stream sink media type should have the aligned height after the session has started. -- v8: mf/tests: Test H.264 decoder alignment. mf/tests: Test H.264 sink media type height alignment. https://gitlab.winehq.org/wine/wine/-/merge_requests/8887

2 2

[PATCH 0/1] MR9176: winemac: Draw black letter/pillarboxes around full-screen content.
by Brendan Shanks (＠bshanks) 14 Oct '25

14 Oct '25

Currently on macOS when display mode emulation is enabled, the space (letterboxes/pillarboxes) around the scaled full-screen content is usually white. We want it to be black instead, like it would be in the case of a real display mode change. To do this: in `WindowPosChanged` when `fullscreen == TRUE`, cover the window with black borders so that only the `window` rect is visible. A `CAShapeLayer` is used, and added as a sublayer to the window's `contentView.layer`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9176

2 1