October 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR9321: winex11: Trace flags with %#x.
by Elizabeth Figura (＠zfigura) 03 Nov '25

03 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9321

3 2

[PATCH 0/1] MR9319: winex11.drv: Fix an inverted condition in x11drv_surface_swap().
by Elizabeth Figura (＠zfigura) 03 Nov '25

03 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9319

3 2

[PATCH 0/1] MR9253: winemac.drv: Create window data for message-only windows.
by Tim Clem (＠tclem) 03 Nov '25

03 Nov '25

Their surfaces may be used. --- x11drv already supports this (and we test for it in opengl32/tests/opengl.c:test_message_window). x11drv doesn't make an x11drv_win_data for message-only windows when they are initially created in X11DRV_create_win_data, but does later if a surface is requested (x11drv_client_surface_create -> create_client_window). I don't see much of a reason to do it lazily in macdrv. We won't make a Cocoa window for message-only windows in macdrv_create_win_data since the parent isn't the desktop, so we're really just allocating space for the macdrv_win_data. And plus opengl.c:macdrv_surface_create uses `get_win_data(hwnd)` as its check for whether a hwnd is in-process; we'd have to adjust that logic (and shuffle some things around in that function) if we were to have macdrv_client_surface_create potentially create a macdrv_win_data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9253

3 2

[PATCH 0/4] MR9323: user32: Fix loading comctl32 v5 after comctl32 v6 is loaded.
by Zhiyi Zhang (＠zhiyi) 03 Nov '25

03 Nov '25

When comctl32 v6 is loaded and v6 manifest is disabled, comctl32 v5 should be used when creating a common control window. However, before this patch, GetModuleHandleW(L"comctl32") return a handle to comctl32 v6 in this case, so comctl32 v5 doesn't get loaded and creating comctl32 v5 windows fails. We need to check if comctl32 v5 is actually loaded by using GetModuleHandleW() with the absolute path of the comctl32 v5 dll. Fix Word 2010 file open dialog doesn't show a listview. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9323

3 8

[PATCH 0/1] MR9329: dlls/sane.ds, dlls/gphoto2.ds: Destroy Progress Dialogs with DestroyWindow instead of EndDialog
by Bernd Herd (＠herdsoft) 01 Nov '25

01 Nov '25

The TWAIN data sources sane.ds and gpoto.ds create progress dialogs with the WIN32 CreateDialog API in files ui.c When they need to destroy these windows, they call EndDialog. But EndDialog is meant for Modal Dialogs created by DialogBox, DialogBoxParam, DialogBoxInd and the like. Calling it for dialogs created by CreateDialog is undocumented behaviour. In the end, those progress dialogs are not destroyed (immediatly?) and can still be open when the application program closes the data source with the message. DG_CONTROL / DAT_IDENTITY / MSG_CLOSEDS This can then later cause a segfault if the sane.ds/gpoto2.ds gets unloaded with FreeLibrary so the dialog box procedure is no longer in memory. There is a workaround for this in dlls/twain_32/dsm_ctrl.c:220: ``` /* This causes crashes due to still open Windows, so leave out for now. * FreeLibrary (currentDS->hmod); */ ``` But the TWAIN organization offers their own DSM-Library twaindsm.dll, that does not contain this workaround so segfaults after an otherwise successful scan: https://github.com/twain/twain-dsm Using this patch, progress dialogs are closed with DestroyWindow instead of EndDialog and these segfaults do not occur any more. This would also allow to change the code in dsm_ctrl.c:220 to FreeLibrary the DS module again. I've tested that it works. But there is no evidence that that change would have benefits and it might have other disadvantages. Compatibility of twaindsm.dll with sane.ds requires one of my previous merge requests that are not yet in wine main tree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9329

3 2

[PATCH 0/1] MR9328: dlls/sane.ds: Make comboboxes in property sheet high enough to properly drop down
by Bernd Herd (＠herdsoft) 01 Nov '25

01 Nov '25

When the sane.ds TWAIN data source displays it's user interface, it auto-generates a proprties dialog from the sane options for the current scanner. Oftenly this dialog contains windows ComboBox controls to choose between scan modes (gray / color) or resolutions. The ComboBox controls created are too flat to properly drop down, they only open about half a line height. This is difficult to use. This patch makes the control about 10 times the height of a string. The combox will not occupy more height than the elements that are filled in anyway. Behaviour before the patch: ![before.png](/uploads/80e328dde7c04c14e5a29b54fa6843a5/before.png){width=305 height=244} Behaviour after the patch: ![after.png](/uploads/49a0e1014974e4bc43637f6b0b02ba54/after.png){width=308 height=246} -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9328

3 2

[PATCH 0/7] MR9331: msxml3: Merge IXMLDocument and IXMLElement sources into a single file.
by Nikolay Sivov (＠nsivov) 31 Oct '25

31 Oct '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9331

2 7

Re: [PATCH v3 0/1] MR9298: ntdll: Remove unused parameter from linux_query_event_obj(). - approved
by Alexandre Julliard (＠julliard) 31 Oct '25

31 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9298

1 0

Re: [PATCH v2 0/1] MR9326: winex11: Use window rects for minimization in virtual desktop mode. - approved
by Alexandre Julliard (＠julliard) 31 Oct '25

31 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9326

1 0

Re: [PATCH v2 0/2] MR9324: kernelbase: Reject empty command lines in CreateProcess(). - approved
by Alexandre Julliard (＠julliard) 31 Oct '25

31 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9324

1 0