October 2025 - Wine-gitlab - list.winehq.org

[PATCH v4 0/1] MR9056: msxml3/element: Implement removeAttributeNode function.
by Reinhold Gschweicher (＠neroburner) 02 Oct '25

02 Oct '25

Implement the function `IXMLDOMElement_removeAttributeNode`. Essentially pass the hard work to `IXMLDOMNamedNodeMap_removeNamedItem`. Use the fact, that attribute names are unique in elements. One case that isn't checked is wheter or not the value of the provided attribute match with the one stored in the dom-element. This MR implements according to the tests introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/8928 -- v4: msxml3/element: Implement removeAttributeNode function. https://gitlab.winehq.org/wine/wine/-/merge_requests/9056

2 3

[PATCH v3 0/4] MR8992: mountmgr.sys: Do not create empty registry nodes for serial or parallel devices.
by Janne Kekkonen (＠Janne) 02 Oct '25

02 Oct '25

Empty registry node for parallel devices will cause Realterm to crash. Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598 -- v3: mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

3 5

[PATCH 0/8] MR9088: win32u/tests: Test shared resources runtime descriptor format and API interop.
by Rémi Bernon 02 Oct '25

02 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9088

2 9

[PATCH v20 0/4] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 02 Oct '25

02 Oct '25

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v20: shell32: Improvements to shield icon https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

4 6

[PATCH 0/1] MR9090: ntdll: Use Mach COW for write watches support on macOS.
by Marc-Aurel Zent (＠mzent) 02 Oct '25

02 Oct '25

This uses the Mach COW mechanism to implement writewatch functionality. Below is the same micro-benchmark @gofman used in his [UFFD MR](https://gitlab.winehq.org/wine/wine/-/merge_requests/7871). ``` Parameters: - number of concurrent threads; - number of pages; - delay between reading / resetting write watches (ms) - random (1) or sequentual (0) page write access; - reset with WRITE_WATCH_FLAG_RESET in GetWriteWatch (1) or in a separate ResetWriteWatch call (0). Result is in the form of <average write to page time, ns> / <average GetWriteWatch() time, mcs> Parameters Windows Mach COW Fallback 6 1080 3 1 1 897 / 80 371 / 12634 66202 / 186 6 1080 3 1 0 855 / 87 369 / 12637 66766 / 187 8 8192 3 1 1 6526 / 268 627 / 113263 111053 / 485 8 8192 3 1 0 1197 / 509 623 / 113810 122921 / 489 8 8192 1 1 1 1227 / 412 636 / 118930 150628 / 388 8 8192 1 1 0 5721 / 144 631 / 120538 146392 / 384 8 64 1 1 1 572 / 7 490 / 1078 1000 / 89 8 64 1 1 0 530 / 13 500 / 1075 1167 / 77 ``` This was all on the same M2 Max machine with Windows being win11 on ARM in a VM running the x64 binary emulated and otherwise Wine through Rosetta with and without this MR. Unlike UFFD which is always better than fallback and comparable to the Windows performance, here good average write to page time is traded for bad average `GetWriteWatch()` time (pretty much in equal ratios). However in real world applications (like the FFXIV + Dalamud mod framework/loader use case) the startup time is reduced from about 25.5s to 23.6s with this change from a cold start, including loading a modern dotnet 9 runtime into the game process and initializing a complex mod collection, with a fairly high GC pressure. This is probably because the `GetWriteWatch()` calls the GC does mostly happen concurrently, whereas in Wines fallback implementation running threads are interrupted and often wait on the global virtual lock in Wine while the segfault is handled and parallel accesses to write watched memory and other VM operations are blocked. Another advantage is that `VPROT_WRITEWATCH` can be used then for other purposes in the future and also Rosetta being a bit finicky sometimes with reported protections with the current implementation, but behaved always as expected so far in my testing with the new one. On native ARM64 the `VM_PROT_COPY`/`SM_COW` mechanism works also as expected on native 16k pages (not that this matters much at the moment). `GetWriteWatch()` with the reset flag also does not need to be transactional (unlike UFFD), since only marked pages are reset here and not the entire range. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9090

3 4

[PATCH v19 0/3] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 02 Oct '25

02 Oct '25

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v19: shell32/tests: Check hIcon value is non-zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

3 5

Re: [PATCH v2 0/1] MR7576: windowscodecs: Remove IWICWineDecoder interface. - approved
by Esme Povirk (＠madewokherd) 02 Oct '25

02 Oct '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7576

1 0

[PATCH v3 0/3] MR9056: msxml3/element: Implement removeAttributeNode function.
by Reinhold Gschweicher (＠neroburner) 02 Oct '25

02 Oct '25

Implement the function `IXMLDOMElement_removeAttributeNode`. Essentially pass the hard work to `IXMLDOMNamedNodeMap_removeNamedItem`. Use the fact, that attribute names are unique in elements. One case that isn't checked is wheter or not the value of the provided attribute match with the one stored in the dom-element. This MR implements according to the tests introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/8928 -- v3: fix formatting of if clause https://gitlab.winehq.org/wine/wine/-/merge_requests/9056

4 7

[PATCH 0/1] MR9087: win32u: Avoid a crash when unsetting current context.
by Rémi Bernon 02 Oct '25

02 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9087

1 1

[PATCH v3 0/7] MR9086: server: Continuously poll on queue fd for driver events.
by Rémi Bernon 02 Oct '25

02 Oct '25

Allowing to use a simple event-like sync for the message queues. -- v3: server: Use an internal event sync for message queues. server: Remove mostly unnecessary thread own queue check. server: Continuously poll on queue fd for driver events. win32u: Notify wineserver after processing every driver events. win32u: Return TRUE from ProcessEvents after emptying the event queue. win32u: Check for pending hardware messages after processing events. server: Use a dedicated internal bit for queued hardware messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/9086

1 8