November 2025 - Wine-gitlab

[PATCH 0/7] MR9579: ntdll: On macOS, transform the main thread into a Wine thread (running a CFRunLoop) on launch.
by Brendan Shanks (＠bshanks) 08 Dec '25

08 Dec '25

Currently, the process's main thread runs `main()` -> `__wine_main()` -> `apple_main_thread()` -> `CFRunLoopRun()`. A run loop source is added that creates the Wine main thread and runs `start_main_thread()`. With this MR, the Wine main thread calls `transform_mac_main_thread()` in `server_init_process()`. That essentially calls `NtCreateThreadEx()`, but instead of creating a new pthread it adds a source to the main thread run loop to run `start_thread()`. This transforms the process main thread into a Wine thread, after that it calls the PE `__wine_mac_run_cfrunloop()` in ntdll. That does a run_mac_cfrunloop Unix call, which just runs `CFRunLoopRun()`. The process main thread is now a Wine thread, but is otherwise still a normal Mac application main thread (including the ability for winemac to transform into a Cocoa application). In theory it might be possible to avoid the initial `CFRunLoopRun()` and have `apple_main_thread()` just spawn the Wine main thread and wait to run `start_thread()`, but the extra `CFRunLoopRun()` on the stack doesn't hurt anything. An exception/crash on the process main thread will be caught like a normal syscall fault, but `__wine_mac_run_cfrunloop()` prints an error and terminates the process. I think this is an improvement over the current behavior, which is a segfault in the signal handler when it tries to access the non-existent TEB that results in the thread hanging and eating 100% CPU. (Arguably it would be even better to unregister the signal handler and re-throw the signal so the user gets a normal macOS crash report with a helpful backtrace, maybe this could be done later.) Besides exception handling, having the main thread be a Wine thread will also allow the full use of Wine logging functions (!9503), and should allow winemac to be simplified (where many AppKit functions must be called from the main thread, and events are delivered to the main thread). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9579

3 10

[PATCH v6 0/7] MR3007: Draft: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker 08 Dec '25

08 Dec '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. - v6: (8c641d09) - Move check to NtDeviceIoControlFile - Add (at least temporary) tests to compare with NtDeviceIoControlFile and NtFsControlFile. -- v6: ntoskrnl.exe/test: Add some temporary debugging output. kernel32/tests: Add test for IOCTL_STORAGE_GET_DEVICE_NUMBER. ntdll: Add validation for input and output buffers in NtDeviceIoControlFile. ntoskrnl.exe: Allow sending a null input buffer to the driver. ntoskrnl.exe: Add todo_wine_if to test_ioctl_buffers. ntoskrnl.exe: Remove buffer assignments in test_ioctl_buffers. ntoskrnl.exe: Add test_ioctl_buffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

3 10

[PATCH 0/6] MR9569: mmdevapi/tests: Introduce helpers to test a single format.
by Giovanni Mascellani (＠giomasce) 08 Dec '25

08 Dec '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9569

2 7

[PATCH 0/3] MR9549: ddraw: Remove WS_CLIPCHILDREN when going fullscreen.
by Rémi Bernon 08 Dec '25

08 Dec '25

Using a new wined3d WINED3D_NO_CLIP_CHILDREN flag which will remove the style, as native, to allow win32u offscreen rendering to blit over child windows but still invalidate them after WM_PAINT, as necessary for some game such as Command & Conquer 2 to refresh their display properly. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58844 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9549

2 6

[PATCH 0/4] MR8183: mf: Read byte streams in chunks of 256KiB.
by Charlotte Pabst (＠CharlottePabst) 06 Dec '25

06 Dec '25

I'm dealing with a game that relies on this constant. Tagging @rbernon since this is using a proton commit of his. Tests should be run both with HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler enabled and disabled. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8183

4 15

[PATCH v2 0/1] MR4636: qcap: Add implementation of IAMVideoControl_GetFrameRateList.
by 江仪陈 05 Dec '25

05 Dec '25

Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> -- v2: qcap: Add implementation of IAMVideoControl_GetFrameRateList. https://gitlab.winehq.org/wine/wine/-/merge_requests/4636

4 4

[PATCH v24 0/10] MR7797: ntdll: Wait for all pending operations to be cancelled in NtCancelIoFile[Ex]().
by Matteo Bruni (＠Mystral) 04 Dec '25

04 Dec '25

This fixes Trials Fusion often crashing when disconnecting a controller while there are more still connected. -- v24: ntoskrnl/tests: Use the 'Nt' version of the CancelIo APIs. ntoskrnl/tests: Test the thread ID the cancellation routine runs from. ntoskrnl/tests: Add more cancellation tests. ntoskrnl/tests: Fix tests on current Windows 10 / 11. ntdll/tests: Test IOSB values of the cancel operation. ntdll/tests: Add more NtCancelIoFile[Ex]() tests. ntdll: Wait for all asyncs to handle cancel in NtCancelIoFile(). server: Factor out a cancel_async() function. server: Introduce a find_async_from_user helper. ntdll: Factor out a cancel_io() function. https://gitlab.winehq.org/wine/wine/-/merge_requests/7797

4 14

[PATCH 0/2] MR8015: ntoskrnl.exe: Do not send IRP to get device instance ID.
by Alexander Morozov (＠amorozov) 04 Dec '25

04 Dec '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57588 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8015

4 6

[PATCH v2 0/2] MR9054: winebth.sys: Remove redundant locks + Fix potential deadlocks while performing operations that block on the DBus event loop.
by Vibhav Pant (＠vibhavp) 04 Dec '25

04 Dec '25

Disconnecting and removing remote devices hold device_list_cs before blocking on the DBus event loop, which may cause a deadlock if we receive a message from BlueZ whose handler also attempts to enter device_list_cs (Like BLUETOOTH_WATCHER_EVENT_TYPE_DEVICE_PROPERTIES_CHANGED). To fix this, the device/radio handle is duplicated once found, device_list_cs is released, and the DBus method call is made using the duplicate handle(s), which are then freed normally. Also, replace the two locks in `bluetooth_radio` with `device_list_cs` instead. -- v2: winebth.sys: Fix potential deadlocks while performing operations that block on the DBus event loop. winebth.sys: Unify critical sections used for bluetooth_radio. https://gitlab.winehq.org/wine/wine/-/merge_requests/9054

3 4

[PATCH 0/1] MR9626: wined3d: Create cube views for cube textures in wined3d_texture_acquire_identity_srv().
by Henri Verbeet (＠hverbeet) 04 Dec '25

04 Dec '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9626

3 2