November 2025 - Wine-gitlab

[PATCH 0/1] MR9582: windowscodecs: Optimize a bit reading the 3bps RGB TIFF tile.
by Dmitry Timoshkov (＠dmitry) 25 Nov '25

25 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9582

3 2

[PATCH v2 0/4] MR9584: Draft: win32u: Update client surfaces starting from toplevel window.
by Rémi Bernon 25 Nov '25

25 Nov '25

In apply_window_pos, to notify any parent or children and let them make the necessary changes for offscreen rendering. -- v2: win32u: Update client surfaces starting from toplevel window. winex11: Update window position in client surface update callback. winex11: Remove some unnecessary NtUserGetClientRect calls. winex11: Pass client rect to create_client_window. https://gitlab.winehq.org/wine/wine/-/merge_requests/9584

1 4

[PATCH v2 0/1] MR9573: win32u: Initialize surface with white colour on creation.
by Paul Gofman (＠gofman) 25 Nov '25

25 Nov '25

-- v2: win32u: Initialize surface with white colour on creation. https://gitlab.winehq.org/wine/wine/-/merge_requests/9573

3 3

[PATCH 0/2] MR9573: win32u: Initialize surface with white colour on creation.
by Paul Gofman (＠gofman) 25 Nov '25

25 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9573

3 7

Re: [PATCH v2 0/5] MR9588: dsound: Introduce a cubic spline interpolation resampler.
by Matteo Bruni (＠Mystral) 25 Nov '25

25 Nov '25

I should have mentioned it together with a few more things, but I forgot :sweat_smile: This is basically a C port of the default resampler from openal-soft. It's MUCH faster while not being much worse in theoretical quality compared to the old FIR resampler. In practice the old resampler had a couple of shortcomings that lowered the effective quality[*], so I don't think this is much a downgrade quality-wise. Otherwise we could bring in the sinc resampler, which is theoretically very solid and still quite a bit faster than the old FIR resampler. It is sensibly slower than this one though, and slower than Windows 10 / 11 dsound's resampler. I'm not opposed to having it as an option; I did in fact try to make the surrounding code somewhat generic to facilitate that. The SSE2 version gives about a 2x speedup for me. For the records it makes even more of a difference in openal-soft, most likely because we start running into performance limitations in our dsound outside of the resampler proper; I should have a few more patches to improve on that. The SSE2 version is effectively always enabled on (x86) 64-bit. To compile the SSE2 version on 32-bit you need to have `-msse2` in `i386_CFLAGS`, or some other option that includes it (e.g. the typical `-march=nocona` will do that). [*]: The FIR resampler used a fixed Gaussian window instead of the parametrized Kaiser that's customarily used for audio resampling. That can introduce some aliasing or some distortion depending on the input signal. Additionally, the position computation (`total_fir_steps`, `rem`) using floats wasn't exact, which in turn caused some mid-high frequency distortion. In fact I had originally preserved it when porting the cubic resampler and I did see the same kind of distortion in the new output, so I ended up using fixed point for that, which is also what openal-soft does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9588#note_123681

1 0

[PATCH 0/1] MR9589: po: update Polish translation
by Adam Markowski (＠AMark) 25 Nov '25

25 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9589

2 1

[PATCH v3 0/1] MR9578: win32u: Ignore statup cmd show mode for owned windows.
by Paul Gofman (＠gofman) 25 Nov '25

25 Nov '25

Fixes a regression introduced by 8d7de32cd646f3d1f118836e643e6146c9837278. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59034 -- v3: win32u: Ignore statup cmd show mode for owned windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/9578

3 6

Re: [PATCH v2 0/5] MR9588: dsound: Introduce a cubic spline interpolation resampler.
by Anton Baskanov (＠baskanov) 25 Nov '25

25 Nov '25

This is going to make the resampling quality worse, isn't it? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9588#note_123673

1 0

[PATCH v2 0/1] MR9577: cmd: Skip directories if they exceed MAX_PATH in WCMD_list_directory (ASan).
by Bernhard Übelacker 25 Nov '25

25 Nov '25

By accident I had still some left-over directories from some test run, and tried a recursive dir in the wineprefix. That led to the ASan report below. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161037) <details> <summary>ASan report with gdb session</summary> ``` $ wine cmd /K "cd /d c:" c:\>dir c:\tmp.txt /s Datenträger in Laufwerk c hat keine Bezeichnung. Datenträgernummer ist 4300-0000 Directory of c: 16.10.2025 22:48 5,925,244 tmp.txt 1 file 5,925,244 bytes ================================================================= ==520==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ddea8 at pc 0x00014001a9e9 bp 0x7ffffe1dd270 sp 0x7ffffe1dd2b8 WRITE of size 2 at 0x7ffffe1ddea8 thread T0 #0 0x00014001a9e8 in lstrcatW .../wine/include/winbase.h:2615 #1 0x00014001b8c9 in WCMD_list_directory .../wine/programs/cmd/directory.c:276 #2 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #3 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 ... #23 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #24 0x00014001c7e3 in WCMD_list_directory .../wine/programs/cmd/directory.c:509 #25 0x00014001a525 in WCMD_directory .../wine/programs/cmd/directory.c:1000 #26 0x000140023e97 in WCMD_run_builtin_command .../wine/programs/cmd/wcmdmain.c:2244 #27 0x00014002964d in execute_single_command .../wine/programs/cmd/wcmdmain.c:2393 #28 0x0001400288ef in node_execute .../wine/programs/cmd/wcmdmain.c:4597 #29 0x00014002aba6 in wmain .../wine/programs/cmd/wcmdmain.c:4948 #30 0x000140037fec in wmainCRTStartup .../wine/dlls/msvcrt/crt_wmain.c:60 #31 0x6fffffc67a54 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a54) #32 0x6fffffde06d6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506d6) Address 0x7ffffe1ddea8 is located in stack of thread T0 at offset 2920 in frame #0 0x00014001b59f in WCMD_list_directory .../wine/programs/cmd/directory.c:242 This frame has 8 object(s): [32, 2080) 'string' (line 244) [2208, 2272) 'datestring' (line 244) [2304, 2368) 'timestring' (line 244) [2400, 2920) 'real_path' (line 245) <== Memory access at offset 2920 overflows this variable [3056, 3064) 'ft' (line 247) [3088, 3104) 'st' (line 248) [3120, 3168) 'username' (line 338) [3200, 3792) 'finddata' (line 465) HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/include/winbase.h:2615 in lstrcatW ... ==520==ABORTING $ gdb-multiarch -q --pid $(pidof 'C:\windows\system32\cmd.exe') (gdb) b ReportError (gdb) b ReportGenericError (gdb) handle SIGSEGV nostop noprint (gdb) handle SIGUSR1 nostop noprint (gdb) cont (gdb) set osabi Windows (gdb) bt #0 ReportGenericError () at /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_report.cpp:516 #1 0x00006ffffe8d7857 in __asan_report_store2 () at /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_rtl.cpp:134 #2 0x000000014001a9e9 in lstrcatW (dst=<optimized out>, src=<optimized out>) at .../wine/include/winbase.h:2615 #3 0x000000014001b8ca in WCMD_list_directory (inputparms=0x7ef45afe0e50, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:276 #4 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0e20, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #5 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0df0, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 ... #25 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe02e0, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #26 0x000000014001c7e4 in WCMD_list_directory (inputparms=0x7ef45afe0220, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:509 #27 0x000000014001a526 in WCMD_directory (args=<optimized out>) at .../wine/programs/cmd/directory.c:1000 #28 0x0000000140023e98 in WCMD_run_builtin_command (cmd_index=8, cmd=0x7f405b008200 L"dir c:\\tmp.txt /s") at .../wine/programs/cmd/wcmdmain.c:2244 #29 0x000000014002964e in execute_single_command (command=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:2393 #30 0x00000001400288f0 in node_execute (node=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:4597 #31 0x000000014002aba7 in wmain (argc=<optimized out>, argvW=<optimized out>) at .../wine/programs/cmd/wcmdmain.c:4948 #32 0x0000000140037fed in wmainCRTStartup () at .../wine/dlls/msvcrt/crt_wmain.c:60 #33 0x00006fffffc67a55 in BaseThreadInitThunk () from .../wine-build/llvm-old64-asan-pe/obj/dlls/kernel32/x86_64-windows/kernel32.dll #34 0x00006fffffde06d7 in RtlUserThreadStart () from .../wine-build/llvm-old64-asan-pe/obj/dlls/ntdll/x86_64-windows/ntdll.dll #35 0x0000000000000000 in ?? () (gdb) up (gdb) up (gdb) up #3 0x000000014001b8ca in WCMD_list_directory (inputparms=0x7ef45afe0e50, level=<optimized out>, outputparms=<optimized out>) at .../wine/programs/cmd/directory.c:276 276 lstrcatW(real_path, parms->fileName); (gdb) set print elements 0 (gdb) print parms->dirName $1 = (WCHAR *) 0x7f1a5afe9080 L"c:\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\abcdefghij\\" (gdb) print parms->fileName $2 = (WCHAR *) 0x7ef25afe0bf0 L"tmp.txt" (gdb) print sizeof(real_path)/sizeof(*real_path) $3 = 260 ``` </details> -- v2: cmd: Skip directories if they exceed MAX_PATH in WCMD_list_directory (ASan). https://gitlab.winehq.org/wine/wine/-/merge_requests/9577

2 4

[PATCH 0/1] MR9587: win32u: Add some extra 4:3 resolutions to the virtual modes.
by Rémi Bernon 25 Nov '25

25 Nov '25

Bloodrayne 2 expects to be able to switch to these. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57972 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9587

1 1