November 2025 - Wine-gitlab

[PATCH 0/5] MR9521: comctl32/updown: Refactor UPDOWN_DrawBuddyBackground() to support drawing...
by Zhiyi Zhang (＠zhiyi) 19 Nov '25

19 Nov '25

This MR marks the end of the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9521

3 6

Re: [PATCH v6 0/2] MR8360: include: Don't evaluate format arguments to ok() unless we need them.
by Bernhard Übelacker 19 Nov '25

19 Nov '25

Hello @yshui, I am sorry, but I think I found an unwanted side effect of this patch. Since a9edbf49 got merged a failure in the [test pattern page of advapi32:registry](https://test.winehq.org/data/patterns.html#advapi32:regi… showed up. ``` registry.c:2267: Test failed: RegQueryValueExA returned: 0 ``` Because I was not able to reproduce it with testbot or a VM I tried to use gitlab CI: - [failure shows up here with a9edbf49](https://gitlab.winehq.org/bernhardu/wine/-/jobs/206300#L82) - [but succeeds here without a9edbf49](https://gitlab.winehq.org/bernhardu/wine/-/jobs/206303#L82) - Unfortunately adding a few traces around the place makes the failure go away like [here](https://gitlab.winehq.org/bernhardu/wine/-/jobs/209460#L82) - Also disabling optimizations for the function containing the test did not help like [here](https://gitlab.winehq.org/bernhardu/wine/-/jobs/209463#L83) (The git history of these Jobs can still be accessed by following the "Commit" at the right side, button "Browse Files", button "History.) What do you think? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8360#note_122996

1 0

Re: [PATCH v2 0/1] MR9477: shell32: Implement the function PickIconDlg.
by Vijay Kiran Kamuju (＠infyquest) 19 Nov '25

19 Nov '25

Please check if it can be split into smaller patches -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9477#note_122995

1 0

[PATCH 0/9] MR9520: VMR7 fixes
by Matteo Bruni (＠Mystral) 19 Nov '25

19 Nov '25

For Resident Evil 2 Classic. These are relatively small and simple patches, but I can certainly cut at 5 or so for the first part. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9520

4 11

Re: [PATCH v6 0/3] MR9382: win32u: Keep internal pixel format and surfaces on the DCs.
by Elizabeth Figura (＠zfigura) 19 Nov '25

19 Nov '25

On Wed Nov 19 18:58:21 2025 +0000, Rémi Bernon wrote: > That's only the case for (D3D) drawables created from a > `wglSetPixelFormatWINE` call, and they should be kept referenced as long > as they are needed? > The window GL drawable(s) created with the window pixel format are kept > with the window itself (at least we keep one unused around). No, that's my bad, I thought we grabbed and released the DC on every frame, but we don't. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9382#note_122988

1 0

Re: [PATCH v6 0/3] MR9382: win32u: Keep internal pixel format and surfaces on the DCs.
by Rémi Bernon 19 Nov '25

19 Nov '25

On Wed Nov 19 18:58:01 2025 +0000, Elizabeth Figura wrote: > > Anyway, it's not needed anymore, I moved the cleanup to ReleaseDC, > limited to the kind of DCs that wined3d uses, it should be good enough > for now. > Wait, does this mean we're destroying the drawable on every ReleaseDC() > call? Isn't that going to kill performance? That's only the case for (D3D) drawables created from a `wglSetPixelFormatWINE` call, and they should be kept referenced as long as they are needed? The window GL drawable(s) created with the window pixel format are kept with the window itself (at least we keep one unused around). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9382#note_122985

1 0

Re: [PATCH v6 0/3] MR9382: win32u: Keep internal pixel format and surfaces on the DCs.
by Elizabeth Figura (＠zfigura) 19 Nov '25

19 Nov '25

> Anyway, it's not needed anymore, I moved the cleanup to ReleaseDC, limited to the kind of DCs that wined3d uses, it should be good enough for now. Wait, does this mean we're destroying the drawable on every ReleaseDC() call? Isn't that going to kill performance? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9382#note_122982

1 0

[PATCH v2 0/6] MR9522: dmsynth: DLS fixes, part 2
by Anton Baskanov (＠baskanov) 19 Nov '25

19 Nov '25

-- v2: dmsynth: Explicitly ignore CONN_DST_EG1_SHUTDOWNTIME. dmsynth: Make voice shutdown instant. dmsynth: Set GEN_EXCLUSIVECLASS to the key group. dmsynth: Handle bipolar transform for LFO connections. https://gitlab.winehq.org/wine/wine/-/merge_requests/9522

4 10

[PATCH 0/2] MR9515: dxgi: Prepare partial presentation tests
by Andrew Boyarshin (＠andrew-boyarshin) 19 Nov '25

19 Nov '25

This is the first part of my partial presentation support patchset. Only the tests and minor implementation changes. Actual implementation will follow in multiple parts: minor refactoring of swapchain backbuffers, then actual implementation for dirty rectangles (with limitations), then limitations will be removed step-by-step, at the very end the scroll will be implemented. I had to mark many new tests as "flaky" (not "todo"). They are not actually flaky, they are perfectly stable on both Windows 8 RTM and one of the latest Windows 11 Canary builds. But since they check multiple pixels and some of them match, this causes the "failures". I saw no better solution which didn't involve new APIs in `wine/test.h`. Their number will drop in the next MRs to 0. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9515

3 5

[PATCH v3 0/2] MR9500: In CreateProcess(), set std handle when passing a pseudo-console.
by eric pouech (＠epo) 19 Nov '25

19 Nov '25

This MR tests and fix the std handles in child process when using CreateProcess with extended information and passing a pseudo-console handle. >From the added tests, and other manual testing (see linked bugzilla entry), it turns out native overrides the (bound) std handles from the parent console with handles on the passed pseudo-console for the child process. But happily inherits other kind of handles. As side notes: - resetting the std handle in RTL_USER_PROCESS_PARAMETERS being console handles could be optimized: potentially, native could just test if the passed handles are bound to the passed console and reset them if not. - hijacked an unused bit in ConsoleFlags to discriminate when to recreate the std handles in child (didn't check-out how native does it though). -- v3: kernelbase: Create std handles from passed pseudo-console. kernel32/tests: Test std handles in CreateProcess with pseudo console. https://gitlab.winehq.org/wine/wine/-/merge_requests/9500

3 4