November 2025 - Wine-gitlab

[PATCH v3 0/5] MR9394: winex11: Lock and flush display in X11DRV_ChangeDisplaySettings.
by Rémi Bernon 13 Nov '25

13 Nov '25

-- v3: winex11: Lock and flush display in X11DRV_ChangeDisplaySettings. winex11: Retrieve full modes before applying new display settings. winex11: Introduce a x11drv_mode structure for full modes. winex11: Always return full modes from settings handlers. winex11: Copy XF86VidModeModeInfo to the DEVMODEW driver data. https://gitlab.winehq.org/wine/wine/-/merge_requests/9394

2 9

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Alexandre Julliard (＠julliard) 13 Nov '25

13 Nov '25

I'd suggest something like !9450. You'd then be able to set WINE_HOST_XDG_DATA_DIRS to hide the distro value and keep the environment to a reasonable size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_121838

1 0

[PATCH 0/3] MR9450: Don't replace WINE_HOST_ variables if they already exist in the environment.
by Alexandre Julliard (＠julliard) 13 Nov '25

13 Nov '25

This makes it possible to override the host value seen by Wine of e.g. XDG_DATA_DIRS by setting WINE_HOST_XDG_DATA_DIRS directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9450

2 3

[PATCH 0/1] MR9439: mf: Return E_NOINTERFACE if service is missing
by Aric Stewart (＠aricstewart) 13 Nov '25

13 Nov '25

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9439

3 4

[PATCH v3 0/8] MR9438: dsound: Various
by Matteo Bruni (＠Mystral) 13 Nov '25

13 Nov '25

Some small dsound fixes I came up with while looking into Wine bug 30639 -- v3: dsound/tests: Mark weird DescriptionW propset failure on the AMD testbot machine. dsound: Return the mmdevapi endpoint ID as module. dsound: Fill all the DSPROPERTY_DIRECTSOUNDDEVICE_ENUMERATE data. dsound: Check data size in propset methods. dsound: Consistently trace locked byte count as an unsigned value. dsound: Print time as an unsigned value. dsound: Simplify check in DSOUND_RecalcFormat(). dsound/tests: Disable a crashing test. https://gitlab.winehq.org/wine/wine/-/merge_requests/9438

3 10

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) 13 Nov '25

13 Nov '25

Also, as Huw mentioned above, it looks like you still didn't fully address the comments from @nsivov that were pointed out [here](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.o…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121819

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) 13 Nov '25

13 Nov '25

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + > + if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) > + { > + ERR("couldn't get IPersistFile interface\n"); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + do { > + WCHAR *link_filename; > + > + if (counter == 1) > + { > + static const WCHAR *fmt = L"%s - %s.lnk"; > + int length = wcslen(filename) + wcslen(shortcutW) + 7; /* length of the format*/ > + link_filename = malloc((length + 1) * sizeof(WCHAR)); Should you check if malloc returns null? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121810

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) 13 Nov '25

13 Nov '25

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + { > + ERR("SetIDList failed\n"); > + return; > + } > + _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH); > + length = wcslen(filename) + wcslen(shortcutW); > + if (length > MAX_PATH) > + { > + ERR("Path maximum length exceeded (%i>%i)\n", length, MAX_PATH); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + SHGetPathFromIDListW(This->pidl, root); > + > + if (!SUCCEEDED(IShellLinkW_QueryInterface(shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) In these failure cases, it's probably possible to write some tests to see what `HRESULT` should be returned. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121808

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) 13 Nov '25

13 Nov '25

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + ILFree(full_pidl); > + if (FAILED(hr)) > + { > + ERR("SetIDList failed\n"); > + return; > + } > + _ILSimpleGetTextW(This->apidl[0], (LPVOID)filename, MAX_PATH); > + length = wcslen(filename) + wcslen(shortcutW); > + if (length > MAX_PATH) > + { > + ERR("Path maximum length exceeded (%i>%i)\n", length, MAX_PATH); > + IShellLinkW_Release(shelllink); > + return; > + } > + > + SHGetPathFromIDListW(This->pidl, root); In other places, we check the return value of this function. Not sure if we should do that here as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121807

1 0

Re: [PATCH v8 0/1] MR5373: shell32: Implement FCIDM_SHVIEW_CREATELINK
by Sven Baars (＠sbaars) 13 Nov '25

13 Nov '25

Sven Baars (@sbaars) commented about dlls/shell32/shlview_cmenu.c: > + ITEMIDLIST *full_pidl; > + HRESULT hr; > + int length; > + int counter = 1; > + > + static const WCHAR *shortcutW = L"Shortcut"; > + > + if (FAILED(IShellLink_Constructor(NULL, &IID_IShellLinkW, (LPVOID*)&shelllink))) > + { > + ERR("couldn't create ShellLink object\n"); > + return; > + } > + full_pidl = ILCombine(This->pidl, This->apidl[0]); > + if (!full_pidl) > + { > + ERR("Out of Memory\n"); Why don't we just return an `HRESULT` here and return that from `ItemMenu_InvokeCommand`, instead of the verbose ERRs? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5373#note_121806

1 0