November 2025 - Wine-gitlab

Re: [PATCH v2 0/3] MR9377: wineandroid, winemac, winex11: Fix ProcessEvents drained return value. - approved
by Alexandre Julliard (＠julliard) 06 Nov '25

06 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9377

1 0

Re: [PATCH v5 0/2] MR9260: winemac: Make macdrv_ime_process_key synchronous. - approved
by Alexandre Julliard (＠julliard) 06 Nov '25

06 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9260

1 0

[PATCH v3 0/3] MR9386: jscript: Implement Uint8ClampedArray.
by Gabriel Ivăncescu 06 Nov '25

06 Nov '25

-- v3: jscript: Return JS_E_OBJECT_EXPECTED in valueOf with NULL disps in IE10+ jscript: Expose Uint8ClampedArray only in ES6 mode. jscript: Implement Uint8ClampedArray. https://gitlab.winehq.org/wine/wine/-/merge_requests/9386

2 4

[PATCH 0/2] MR9388: user32/tests: Add some tests for GetWindow(GW_ENABLEDPOPUP).
by Nikolay Sivov (＠nsivov) 06 Nov '25

06 Nov '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9388

3 4

[PATCH v3 0/3] MR9373: dmusic,dmsynth: Reduce memory usage part 2
by Anton Baskanov (＠baskanov) 06 Nov '25

06 Nov '25

-- v3: dmsynth: Remove format and sample_count from struct wave. dmsynth: Allow zero-copy access to the sample data. dmusic: Defer releasing IDirectMusicDownload when can_free is FALSE. https://gitlab.winehq.org/wine/wine/-/merge_requests/9373

4 8

[PATCH v2 0/2] MR9384: vccorlib140: Implement {Get, Weak}ResolveWeakReference.
by Vibhav Pant (＠vibhavp) 06 Nov '25

06 Nov '25

-- v2: vccorlib140: Implement {Get, Resolve}WeakReference. https://gitlab.winehq.org/wine/wine/-/merge_requests/9384

3 4

[PATCH v2 0/3] MR9386: jscript: Implement Uint8ClampedArray.
by Gabriel Ivăncescu 06 Nov '25

06 Nov '25

-- v2: jscript: Return JS_E_OBJECT_EXPECTED in valueOf with NULL disps in IE10+ jscript: Expose Uint8ClampedArray only in ES6 mode. jscript: Implement Uint8ClampedArray. https://gitlab.winehq.org/wine/wine/-/merge_requests/9386

2 4

[PATCH 0/1] MR9387: po: update Polish translation
by Adam Markowski (＠AMark) 06 Nov '25

06 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9387

2 1

[PATCH 0/3] MR9386: jscript: Implement Uint8ClampedArray.
by Gabriel Ivăncescu 06 Nov '25

06 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9386

1 3

Re: [PATCH v4 0/1] MR9362: opengl32: Simplify extension tokenization.
by Rémi Bernon 06 Nov '25

06 Nov '25

On Thu Nov 6 17:21:53 2025 +0000, Jacek Caban wrote: > First of all, this is your change, so my question is: why do we now have > to use `ARRAY_SIZE`? > Historically, there was a large janitorial effort that introduced > `ARRAY_SIZE` as a Wine extension and replaced many open-coded cases. My > best guess as to why `ARRAYSIZE` (available in the Windows SDK) wasn’t > used at the time is simply oversight and that’s where your usage stats > come from. The latter was added later for MSVC compatibility, and both > have been fine ever since, but if you’re proposing some kind of > unification, I’m not in favor of enforcing the non-compatible variant. I'm sorry but this has been merged without my approval, when I had explicitly requested changes to the code which I found ugly and inconsistent, by squeezing the change to a different MR which I wasn't assigned to. And now I have to spend time on it and justify the changes I had previously requested? I don't really care which one between ARRAY_SIZE or ARRAYSIZE is better, I only see that ARRAY_SIZE is 10 times more widely used than the other, and I believe code should be kept consistent to avoid wasting our time on such considerations. The consistency is in favor of ARRAY_SIZE, period. If you think that Wine should drop ARRAY_SIZE and use ARRAYSIZE everywhere, I'm fine with it, but it should be done at a large scale, not by introducing small diverging usages here and there. Like we did with ULONG types. In the meantime, please stick to ARRAY_SIZE. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9362#note_121051

1 0