December 2025 - Wine-gitlab

Re: [PATCH v2 0/3] MR9666: ntdll: Rewrite arm64 packed unwind info handling. - approved
by Alexandre Julliard (＠julliard) 03 Dec '25

03 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9666

1 0

Re: [PATCH v2 0/1] MR9665: libs/ldap: Consistently use unicode version of QueryContextAttributes(). - approved
by Alexandre Julliard (＠julliard) 03 Dec '25

03 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9665

1 0

Re: [PATCH v3 0/2] MR9664: win32u: Remove scrollbar rect offsets when WS_HSCROLL or WS_VSCROLL is present. - approved
by Alexandre Julliard (＠julliard) 03 Dec '25

03 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9664

1 0

Re: [PATCH v2 0/1] MR9662: win32u: Use asprintf in read_drm_device_prop. - approved
by Alexandre Julliard (＠julliard) 03 Dec '25

03 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9662

1 0

[PATCH v9 0/4] MR9519: dlls/twain_32: Offer TWAIN DSM as twaindsm.dll for 64 Bit and send DAT_ENTRYPOINT earlier.
by Bernd Herd (＠herdsoft) 03 Dec '25

03 Dec '25

64-Bit Windows applications typically expect the Twain Data Source manager to be named twaindsm.dll. Send the DG_CONTROL/DAT_ENTRYPOINT/MSG_SET before DG_CONTROL/DAT_IDENTITY/MSG_OPENDS so sane.ds does not need to know the module name to find the DSM entry point. An explanation for the request to offer the name twaindsm.dll for 64-Bit windows is offered here by the TWAIN organization: https://github.com/twain/twain-dsm/blob/master/TWAIN_DSM/src/readme.doc They cannot update the twain_32.dll installed and maintained by Microsoft, so they choose the new name twaindsm.dll instead. This name is also used at least by Irfanview and oder versions oder LibreOffice (Newer Libreoffice version start a 32-Bit process for 32-Bit TWAIN usage). This Merge request also changes the twain_32.dll so that it send it's entry points earlier, before opening the data source. This is the same behaviour as the twaindsm.dll from the TWAIN organization from [https://github.com/twain/twain-dsm/](https://github.com/twain/twain-dsm/blo… Otherwise sane.ds would in MSG_OPENDS try to find the DSM entry point based on the module-name "twain_32" in sane_main.c:60: ``` if (SANE_dsmentry == NULL) { HMODULE moddsm = GetModuleHandleW(L"twain_32"); if (moddsm) SANE_dsmentry = (void*)GetProcAddress(moddsm, "DSM_Entry"); if (!SANE_dsmentry) { ERR("can't find DSM entry point\n"); return TWRC_FAILURE; } } ``` -- v9: dlls/twaindsm: Recursively search in C:\Windows\twain_xx for installed data sources dlls/twaindsm: Add DG_CONTROL/DAT_CALLBACKx/MSG_REGISTER_CALLBACK to support TWAIN 2.x protocol dlls/twaindsm: Implement DG_CONTROL/DAT_ENTRYPOINT/MSG_GET dlls/twaindsm, dlls/twain_32: Put DSM code into twaindsm.dll and add twain_32.dll wrapper https://gitlab.winehq.org/wine/wine/-/merge_requests/9519

3 7

[PATCH 0/2] MR9668: server: Always allow windows to activate after their creation.
by Rémi Bernon 03 Dec '25

03 Dec '25

When a process closes all of its window then opens a new one, Windows often allows it to get its "foreground process" status back, as long as it didn't actively give foreground to another process. On Wine the activate_other_window logic, or the host window manager, might have given focus to a different, non-parent, process already and we are preventing the old process from activating any window again. This relaxes the restriction a bit more, and allows new windows to be activated once after their creation, regardless of whether their owner is the foreground process or not. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59075 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9668

1 2

[PATCH 0/1] MR9634: dotnetfx35.exe: Add stub program.
by Rémi Bernon 03 Dec '25

03 Dec '25

This overrides native dotnetfx35 installer, which is broken in an unfixable way. Recent Windows also bypass its execution. -- This has been in proton for a long time, it fixes various error popups when 3.5 .NET installer is executed. Native installer could still be attempted with `WINEDLLOVERRIDES` although it's never going to succeed installing with a recent Windows version. I think changing Windows version to XP might help it but it's also a manual step, so having an additional override to set shouldn't make much difference. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9634

3 15

[PATCH v2 0/1] MR9625: dlls/sane.ds: Make UI Non-Modal as required by Twain specification
by Bernd Herd (＠herdsoft) 03 Dec '25

03 Dec '25

This is neccessary according to the Twain specification and also allows much more comfortable user interfaces. The Twain specification is clear that event processing in the main application must be provided while the data source shows it's User Interface: ``` "You cannot use the modal dialog creation call DialogBox( ) to create the Source’s user interface main window. To allow event processing by both the application and the Source, this call cannot be used" ``` This was already documented that way in Twain Specification 1.8. According to the specification, MSG_ENABLEDS only creates the dialog and then returns. But the implementation in ui.c with the call to CreatePropertySheetW equals a "DialogBox" call and returns only when the user clicks OK or CANCEL. This Merge Requests sets PSH_MODELESS to make CreatePropertySheetW create a non-modal dialog and then returns control back to the application. To avoid crashes, some of the pointers passed to CreatePropertySheetW must stay valid as long as the dialog remains open. A pointer to an additional struct SUiData is stored with the activeDS and cleared when the user interface is cleared with DestroyWindow on MSG_DISABLEDS. To reduce the number of changes in the source code, the PROPSHEETHEADERW is not part of the struct as no problems were observable. The user interface is no longer automatically closed after every scan. Depening on the application program, it can stay open, ready for the next scan with just a click on the "Scan" button, which results in a much easier and faster user interface experience. For example the user might modifiy settings like resolution or brightness and start a second scan with the modified parameters with a singe click. The progress dialog is modified * to use the UI dialog as it's parent window. * And get created centered on the user interface dialog instead of the screen. Application orograms I found to profit from the modified behaviour: * IrfanView 4.7.2 if the Button "Close Twain dialog after acquiring an image" is disabled. * The simple memxfer.c source I recently attached to an older merge request. -- v2: dlls/sane.ds: Make UI Non-Modal as required by Twain specification https://gitlab.winehq.org/wine/wine/-/merge_requests/9625

2 1

Re: [PATCH v5 0/1] MR5861: mshtml: Implement visibilitychange event.
by Gabriel Ivăncescu 03 Dec '25

03 Dec '25

On Wed Dec 3 15:43:01 2025 +0000, Jacek Caban wrote: > Note that minimizing a window is just one case where this event should > fire, but there are many others. In regular browsers, switching tabs is > probably the most common source of the event. To support that, we would > need to detect real visibility changes of the document, not just window minimization. > That said, we do not need a complete solution right away, but since even > the limited support already requires awkward hooks, this does not look > very appealing. What exactly is it fixing? Do you have an actual > application that needs it? And what is the observable behavior > difference between this MR and just a stub? For example some games/apps XBox Sign-In is using it (via the Microsoft libs), probably for some sort of telemetry since it also does a bunch of performance timings, though I've no idea of the exact impact vs a stub. I actually wanted to have the tests not skipped on Wine (and also because we didn't have the hook before Esme implemented it, and now wanted to try it out). I mean, even if we do include it in other sources like switching tabs (although I'm unsure how to do that from mshtml without IE? aren't tabs in iexplore instead?), we'd still have to handle minimization somehow. And at least that one is more important since it works 100% without iexplore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5861#note_124564

1 0

Re: [PATCH v8 0/1] MR9406: wined3d: texture.c split vulkan and opengl for cleaner clarity
by Stian Low (＠stianlow) 03 Dec '25

03 Dec '25

Closing because these changes have been merged by: https://gitlab.winehq.org/wine/wine/-/merge_requests/9523 Comparing the diffs reveals nearly identical changes except for a few functions that were copied to different files. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9406#note_124552

1 0