December 2025 - Wine-gitlab

[PATCH v2 0/5] MR9843: wtsapi32: Fix session id and desktop handling when using CreateProcessAsUserW with tokens from WTSQueryUserToken
by Katharina Bogad (＠hackathi) 31 Dec '25

31 Dec '25

This Merge request resolves [Wine-Bug #58588](https://bugs.winehq.org/show_bug.cgi?id=58588). The underlying problem was that services started on their own, non-interactive winstation, but within the current user's session. This is trivially not the case for system services on Windows: they run, by design, in other user contexts (e.g. NTAUTHORITY\SYSTEM). Whenever a service wants to start a process within another user's graphical session, it needs to set the session id to the correct value. This may be done using the WTS API. This MR implements this functionality in a (hopefully) wine-compatible way: 1. Patch wineserver so tokens can be transferred to other sessions 2. Implement NtSetInformationToken for TokenSessionId 3. Change the session of non-interactive services to session 0 (from the default session 1) in addition to setting their desktop to `__wineservice_winstation\Default` 4. Let CreateProcessAsUserW reset the desktop to the default value `__winsta0\Default` if the session of the to-be-created process is not a service session. This avoids implementing all user and session handling in-depth while still allowing the underlying functionality to work. A real-world user of this mechanism is the Dassault 3DEXPERIENCE launcher, which runs as a system service and wants to open interactive child processes within a user's scope. -- v2: kernelbase: Let CreateProcessInternalW overwrite the desktop if needed services: start services with session id 0 wtsapi32: Make WTSQueryUserToken return a token with correct session id ntdll: Implement NtSetInformationToken for TokenSessionId https://gitlab.winehq.org/wine/wine/-/merge_requests/9843

2 6

[PATCH v13 0/2] MR9832: win32u: Fix xdg-toplevel-icon Wayland protocol.
by Alex Schwartz (＠alexschwartz01) 31 Dec '25

31 Dec '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=59149 -- v13: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9832

2 3

[PATCH 0/5] MR9843: wtsapi32: Fix session id and desktop handling when using CreateProcessW with tokens from WTSQueryUserToken
by Katharina Bogad (＠hackathi) 31 Dec '25

31 Dec '25

This Merge request resolves [Wine-Bug #58588](https://bugs.winehq.org/show_bug.cgi?id=58588). The underlying problem was that services started on their own, non-interactive winstation, but within the current User's session. This is trivially not the case for system services on Windows; they run, by design, in other user contexted (e.g. NTAUTHORITY\SYSTEM). Whenever a service wants to start a process within another user's graphical session, it needs to set the session id to the correct value. This may be done using the WTS API. This MR implements this functionality in a (hopefully) wine-compatible way: 1. Patch wineserver so tokens can be transferred to other sessions 2. Implement NtSetInformationToken for TokenSessionId 3. Change the session of non-interactive services to session 0 (from the default session 1) in addition to setting their desktop to `__wineservice_winstation\Default` 4. Let CreateProcessAsUserW reset the desktop to the default value `__winsta0\Default` if the session of the to-be-created process is not a service session. This avoids implementing all user and session handling in-depth while still allowing the underlying functionality to work. A real-world user of this mechanism is the Dassault 3DEXPERIENCE launcher, which runs as a system service and wants to open interactive child processes within a user's scope. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9843

2 6

[PATCH 0/1] MR9842: winewayland: Fix non-square icons with xdg-toplevel-icon protocol
by Alex Schwartz (＠alexschwartz01) 31 Dec '25

31 Dec '25

**Requires https://gitlab.winehq.org/wine/wine/-/merge_requests/9832 to be merged first** before this PR: if you launch an app that has a different width than height (non-square), wine will refuse to launch the app ``` [destroyed object]: error 1: Icon buffer is not a square ``` this PR fixes that by centering the original icon onto a square icon buffer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9842

2 2

[PATCH v11 0/2] MR9832: win32u: Fix xdg-toplevel-icon Wayland protocol.
by Alex Schwartz (＠alexschwartz01) 31 Dec '25

31 Dec '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=59149 -- v11: winewayland: Fix non-square icons with xdg-toplevel-icon protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9832

2 2

[PATCH v10 0/1] MR9832: win32u: Fix xdg-toplevel-icon Wayland protocol.
by Alex Schwartz (＠alexschwartz01) 31 Dec '25

31 Dec '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=59149 -- v10: win32u: Fix xdg-toplevel-icon Wayland protocol. https://gitlab.winehq.org/wine/wine/-/merge_requests/9832

2 3

Re: [PATCH v28 0/1] MR9442: comctl32/treeview: check for child item before SendExpanding
by Thomas Csovcsity (＠thc13) 30 Dec '25

30 Dec '25

On Thu Dec 18 01:04:31 2025 +0000, Zhiyi Zhang wrote: > Please stop rebasing this MR every day. It triggers a notification each > time you rebase the MR. The change in this MR seems simple. Try to see > how to reproduce the bug in a test. That will help you get this MR in > sooner. Otherwise, I will need to figure it out myself when I have time. Ok. Sorry, will stop it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9442#note_126265

1 0

[PATCH v3 0/4] MR9822: Fix possible EA launcher hangs.
by Zhiyi Zhang (＠zhiyi) 30 Dec '25

30 Dec '25

Registering window classes in DllMain() is prone to deadlocks. Tests show that comctl32 window classes should probably be registered in RegisterClassNameW(). Fix possible EA launcher hangs due to deadlocks. A deadlock can happen, like the following, based on Tim Clem's findings. Say there are two threads, T1 and T2. T1: does some COM stuff that results in registering the window class OleMainThreadWndClass.\ T1: NtUserRegisterClassExWOW() does get_desktop_window(). Because this is not a built-in class.\ T1: doesn't yet have a desktop window, so it makes one and calls register_builtin_classes().\ T1: starts the pthread_once in register_builtin_classes() to actually register the classes.\ T1: starts calling NtUserRegisterClassExWOW() with its classes.\ T2: loads comctl32.dll, calls its PROCESS_ATTACH. It grabs the loader lock.\ T2: comctl32's DllMain starts registering its classes.\ T2: comctl32's attempts to register classes also call get_desktop_window().\ T2: get_desktop_window hits the pthread_once in register_builtin_classes() and starts waiting for T1 to finish it.\ T1: some built-in class registration results in a LoadImageW call for a class's cursor.\ T1: LoadImage has to grab a resource, so it tries to grab the loader lock.\ T1: the loader lock is held by T2. Deadlock; T2 is waiting on T1, which is waiting on T2. -- v3: comctl32: Register window classes in RegisterClassNameW() instead of DllMain(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9822

3 6

Re: [PATCH v3 0/1] MR9834: user32: Test DlgDirList in a temp directory. - approved
by Alexandre Julliard (＠julliard) 30 Dec '25

30 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9834

1 0

Re: [PATCH v2 0/1] MR9836: wow64: Only compare the valid segment selector part - approved
by Alexandre Julliard (＠julliard) 30 Dec '25

30 Dec '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9836

1 0