February 2025 - Wine-gitlab

[PATCH 0/1] MR3720: wtsapi/tests: Use a heap buffer for the user SID.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55227 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3720

3 2

[PATCH 0/1] MR3721: webservices/tests: Fully initialize xmlstr.
by Hans Leidekker (＠hans) 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3721

3 2

[PATCH 0/1] MR3719: d3d9/tests: Don't fail d3d9ex if the window manager restores focus too soon.
by Stefan Dösinger 09 Mar '25

09 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3719

4 5

[PATCH v4 0/4] MR3675: dmsynth/tests: Test the synthesizer components and render some samples from MIDI.
by Rémi Bernon 08 Mar '25

08 Mar '25

-- v4: dmsynth/tests: Test DirectMusicSynth class in isolation. dmsynth/tests: Test DirectMusicSynthSink class in isolation. dmsynth/tests: Import and use a check_interface helper. dmsynth/tests: Avoid dynamic format string. https://gitlab.winehq.org/wine/wine/-/merge_requests/3675

3 10

[PATCH 0/1] MR7290: Draft: kernelbase: Handle correctly paths with forward slashes in ReplaceFileW.
by Roman Pišl 08 Mar '25

08 Mar '25

PathRemoveFileSpecW keeps only the drive if the path contains all forward slashes as shown in tests. But then the temporary file is created in the root folder which fails for drive Z:. This fixes a corner case when using CMake in Wine. Another usage of PathRemoveFileSpecW is in PathRelativePathToW which should be also checked. I'm leaving this as a draft until getting some feedback and adding tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7290

2 5

[PATCH v36 0/9] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 07 Mar '25

07 Mar '25

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v36: advapi32: Fake the SeLockMemoryPrivilege right in LsaEnumerateAccountRights. psapi: Add tests for querying information for large pages. ntdll: Use PAGEMAP_SCAN ioctl to implement get_working_set_ex, if available. kernel32: Add tests for large pages support. ntdll: Support allocating virtual memory, creating and mapping files backed by large/huge pages. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

3 11

[PATCH 0/1] MR7306: winex11.drv: Don't call NtUserGetWindowLongW() from X11DRV_GetWindowStateUpdates() with win_data_mutex held.
by Paul Gofman (＠gofman) 07 Mar '25

07 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7306

3 8

[PATCH 0/9] MR5057: Draft: winewayland.drv: Use virtual display devices to implement mode change emulation
by Alexandros Frantzis (＠afrantzis) 07 Mar '25

07 Mar '25

This WIP branch prototypes the usage of virtual display devices (through "virtual desktop" mode at the moment) to support display mode emulation in the Wayland driver. It works by allowing the driver to mark each host adapter with a virtual_id, which, if present, signals to win32u that it should include the adapter in the virtual display configuration. The virtual configuration (along with the virtual ids) is reported back to the driver though a new user driver function. If none of the host adapters is marked with a virtual id (i.e., all other drivers) we fall back to the single virtual display mode as before. Some deficiencies and open questions with the prototype: 1. Virtual desktop mode implies a lot of behavior that we don't want at this point the Wayland driver (e.g., taskbar window, changing the display mode to the virtual desktop resolution at startup, some changes in fsclip behavior). One way forward would be to have a "virtual display devices" mode separate from the "virtual desktop" mode, so that drivers can opt in only to the desired behavior (virtual desktop would imply virtual devices, to maintain the current behavior). 2. It's not clear to me what would be the best way for a driver to opt in or out of certain core behavior. Perhaps the driver would change some volatile registry key which other components would consult? Or introduce a user driver function for core to query the driver about such features on demand? Is there some precedence I can get inspiration from? 3. At the moment, the prototype calls the new "NotifyVirtualDevices" user driver callback only in the process which the display update occurred. This means that other processes don't get notified of the virtual devices mapping to host devices, so, in the Wayland driver case, we are not able to scale windows from those processes properly. One approach would be for core to ensure that the NotifyVirtualDevices callback is called once in all processes, but I am not sure what's the best way to achieve this (or even if this is the preferred approach). Another way would be to have a mechanism for the driver to query the virtual device info (+mappings) on demand, and just broadcast a message to all windows. In this case it could even be done internally by the driver (so more in line with what the part-12 MR is doing), if we don't want to introduce a more global behavior. Perhaps there is some even better mechanism, which would also be more fitting to how we envision the virtual display/devic es to evolve going forward. Let me know what you think! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5057

5 25

[PATCH v3 0/7] MR6752: include: More fixes to build libc++.
by Rémi Bernon 05 Mar '25

05 Mar '25

-- v3: include: Fix wmemchr C++ warning. include: Fix InlineIsEqualGUID C++ warning. include: Add some _BitScanForward(64) declarations in intrin.h. include: Add a __shiftright128 intrinsic definition. include: Add a _umul128 intrinsic definition. include: Move FILE_DISPOSITION_INFO after DeleteFile(A|W). include: Add a MB_CUR_MAX definition in ctype.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/6752

2 14

[PATCH 0/3] MR7416: wined3d: Interpret Y'CbCr values as being from the reduced range.
by Elizabeth Figura (＠zfigura) 04 Mar '25

04 Mar '25

This is an adjustment of 7324. d3d9:visual already has a test that's relatively close to what a simplified version of the tests in 7324 looked like, so I made the few changes to expand that test to match and then ported it to ddraw. Implementation-wise, this removes the SD/HD difference (which only exists on NVidia and is not necessary to improve the mentioned application). It also removes the clamping of YUV values, which as the tests show is not correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7416

6 8