February 2025 - Wine-gitlab

Re: [PATCH v5 0/5] MR7391: winebth.sys part 4: Implement IOCTL_BTH_GET_DEVICE_INFO. - approved
by Alexandre Julliard (＠julliard) 22 Feb '25

22 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7391

1 0

Re: [PATCH v2 0/4] MR7395: oleaut32/tests: Add some tests for loading and saving EMF using IPicture interface. - approved
by Alexandre Julliard (＠julliard) 22 Feb '25

22 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7395

1 0

Re: [PATCH v2 0/4] MR7393: kernelbase: Implement GetDiskSpaceInformation(). - approved
by Alexandre Julliard (＠julliard) 22 Feb '25

22 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7393

1 0

[PATCH v8 0/5] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri 22 Feb '25

22 Feb '25

This MR intends to add support for the case FileAllocationInformation in function SetFileInformationByHandle of library kernelbase.dll. The code is based on my understanding of [MS documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/d… No test was added, because other cases that could have helped doing so (FileEndOfFileInformation) do not have neither. -- v8: Added build condition for apple platform https://gitlab.winehq.org/wine/wine/-/merge_requests/7115

2 5

[PATCH v7 0/4] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri 22 Feb '25

22 Feb '25

This MR intends to add support for the case FileAllocationInformation in function SetFileInformationByHandle of library kernelbase.dll. The code is based on my understanding of [MS documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/d… No test was added, because other cases that could have helped doing so (FileEndOfFileInformation) do not have neither. -- v7: removed probably useless FALLOC_FL_ZERO_RANGE flag Switched back to fallocate, with FALLOC_FL_KEEP_SIZE Used posix_fallocate in place of ftruncate + added related test Added support of sub function FileAllocationInformation in SetFileInformationByHandle https://gitlab.winehq.org/wine/wine/-/merge_requests/7115

3 6

[PATCH v6 0/4] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri 22 Feb '25

22 Feb '25

This MR intends to add support for the case FileAllocationInformation in function SetFileInformationByHandle of library kernelbase.dll. The code is based on my understanding of [MS documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/d… No test was added, because other cases that could have helped doing so (FileEndOfFileInformation) do not have neither. -- v6: removed probably useless FALLOC_FL_ZERO_RANGE flag https://gitlab.winehq.org/wine/wine/-/merge_requests/7115

2 4

[PATCH v2 0/8] MR7376: windowscodecs/gif: Store Image descriptor offset when reading GIF data.
by Nikolay Sivov (＠nsivov) 22 Feb '25

22 Feb '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: windowscodecs/decoder: Implement metadata readers enumerator for the common decoder. windowscodecs/decoder: Reuse metadata readers instances. windowscodecs: Use common decoder for GIF format. windowscodecs/decoder: Add support for IWICBitmapDecoder::CopyPalette() in common decoder. windowscodecs/decoder: Add support for metadata block reader at decoder level. windowscodecs/decoder: Separate metadata block reader to a reusable structure. windowscodecs/metadata: Add an option to initialize reader from a memory block. windowscodecs/gif: Store Image descriptor offset when reading GIF data. https://gitlab.winehq.org/wine/wine/-/merge_requests/7376

3 10

[PATCH v3 0/4] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) 22 Feb '25

22 Feb '25

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: test-linux32: Disable broken tests that are already released broken dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

3 4

[PATCH 0/2] MR7403: user32: Call UpdateWindow() after showing a dialog.
by Elizabeth Figura (＠zfigura) 22 Feb '25

22 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7403

4 4

Re: [PATCH v4 0/1] MR7400: cmd: Allow any key to continue past DIR /P pauses.
by eric pouech (＠epo) 22 Feb '25

22 Feb '25

yes `dir /p` needs to be fixed, and what you propose does work for the regular use (cmd in interactive mode...) did some testing on windows which confirm that ENABLE_PROCESSED_INPUT should be kept in wait operation * piping ctrl-c character in input stream doesn't stop the `dir /p` command * while hitting ctrl-c from keyboard (from the same pipe command) does * this means that the console is always kept in processed mode, and the ctrl-c is always returned through the ctrl-c handler and not as a character in input stream actually, I'd prefer to have a dedicated helper to only wait for user input (it doesn't prevent to have another helper which does {print message(); wait for input(); print \\r\\n}); and we tend to place generic helpers in wcmdmain.c there are some functional points to consider: * may be setting console mode to ENABLE_PROCESSED_INPUT only is too aggressive; it looks like only clearing ENABLE_LINE_INPUT could be sufficient (you may want to keep ENABLE_ECHO_INPUT to have character printed) * console mode isn't reset on error path * the most annoying bit is that the ctrl-c isn't handled * this may end up a bit complicated as you need to wait on two objects; WCMD_choice could help for some waitable reads, but not all the input handles are opened in overlapped mode \<g\> * and also, it must ensure that the callers to that helper correctly support the STATUS_CONTROL_C_EXIT (`pause` seems to ignore it, `dir` now has support for ctrl-c return code) note: builtin cmd doesn't properly implement pipes between commands, so don't try test it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7400#note_95627

1 0