February 2025 - Wine-gitlab

[PATCH v2 0/2] MR7324: Use Microsoft provided coefficients for YUV to RGB conversion.
by Brendan McGrath (＠redmcg) 15 Feb '25

15 Feb '25

The current YUV to RGB conversion provides values in studio-range [16-235], but full-range is required [0-255]. As a result, we currently write the value of 16 to represent black, and so we get gray instead. This MR changes the coefficients used in the conversion so that the resultant output is in full-range. It actually uses two sets of coefficients as these differ between SD and HD. Also included is a number of Direct Draw 7 tests. The coefficients used are documented here: https://learn.microsoft.com/en-us/windows/win32/medfound/recommended-8-bit-… -- v2: wined3d: Use Microsoft provided coefficients for YUV to RGB conversion. ddraw/tests: Test yuv to rgb blt in ddraw7. https://gitlab.winehq.org/wine/wine/-/merge_requests/7324

3 8

[PATCH v9 0/4] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 15 Feb '25

15 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- v9: winewayland: Post IME update for preedit text. winewayland: Implement SetIMECompositionRect. winewayland: Post IME update for committed text. https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

2 4

[PATCH v7 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) 15 Feb '25

15 Feb '25

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v7: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

5 9

[PATCH v8 0/4] MR7241: winewayland: Basic input method support.
by Attila Fidan (＠atticf) 15 Feb '25

15 Feb '25

This MR tries to implement the SetIMECompositionRect user driver function and partially the WINE_IME_POST_UPDATE message call. It requires support for zwp_text_input_v3 from the compositor. It supports submitting committed text to the win32 side and notifying the compositor about the area of the text cursor rectangle. This doesn't add support for embedded pre-edit because I couldn't immediately get it to appear. Either I did something incorrect, or it has something to do with Wayland. On X11, the pre-edit appears completely separated to the application window and doesn't move with it, which doesn't seem to be compatible with Wayland. If Windows has the surrounding text feature, it does not seem possible to support it here with the provided interface. The IME is always enabled on the focused surface, like on X11. If Windows has a facility that applications can use to say that it does or does not accept text entry at certain parts of the UI, it does not seem possible to support it here with the provided interface. -- v8: winewayland: Post IME update for preedit text. winewayland: Implement SetIMECompositionRect. winewayland: Post IME update for committed text. https://gitlab.winehq.org/wine/wine/-/merge_requests/7241

2 5

[PATCH 0/5] MR7195: setuapi: Implement a few cfgmgr functions.
by Paul Gofman (＠gofman) 15 Feb '25

15 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7195

4 8

[PATCH v2 0/1] MR7210: setupapi: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 15 Feb '25

15 Feb '25

-- v2: setupapi: Use wide character string literals. https://gitlab.winehq.org/wine/wine/-/merge_requests/7210

3 2

Re: [PATCH v10 0/4] MR7216: winebth.sys part 3: Introduce IOCTLs related to radio discoverability, connectability and device inquiry.
by Elizabeth Figura (＠zfigura) 15 Feb '25

15 Feb '25

Sorry for the late review, I don't have any good excuse. In general, these ioctls are a bit odd without the code on the bluetoothapis side to hook them up. It's probably reasonable to add those to this merge request. >From 1/4: ``` +NTSTATUS winebluetooth_radio_set_property( winebluetooth_radio_t radio, + winebluetooth_radio_props_mask_t prop, + union winebluetooth_property *property ) ``` The "property" parameter is not used. ``` + switch (prop) + { + case WINEBLUETOOTH_RADIO_PROPERTY_CONNECTABLE: + case WINEBLUETOOTH_RADIO_PROPERTY_DISCOVERABLE: + case WINEBLUETOOTH_RADIO_PROPERTY_PAIRABLE: + break; + default: + return STATUS_INVALID_PARAMETER; + } ``` The Unix side returns STATUS_INVALID_PARAMETER for the others anyway, so you might as well just get rid of this whole switch. ``` + case LOCAL_RADIO_CONNECTABLE: + status = + winebluetooth_radio_set_property( ext->radio, WINEBLUETOOTH_RADIO_PROPERTY_CONNECTABLE, &prop_value ); + + break; + case LOCAL_RADIO_DISCOVERABLE: + status = + winebluetooth_radio_set_property( ext->radio, WINEBLUETOOTH_RADIO_PROPERTY_DISCOVERABLE, &prop_value ); + break; ``` Why are we translating to a different flags enum? Why not pass this flag enum directly? You also implement the PAIRABLE property, but that code is never reached. ``` + status = UNIX_BLUETOOTH_CALL( bluetooth_adapter_set_prop, &params ); + + if (status != STATUS_SUCCESS) return status; + + return STATUS_SUCCESS; ``` This could just be "return UNIX_BLUETOOTH_CALL( ... )". To each their own style, I guess, but in general there are a lot of helpers that seem quite redundant... >From 2/4: ``` + if (filter->le && filter->bredr) + transport = WINEBLUETOOTH_DISCOVERY_TRANSPORT_AUTO; + else if (filter->le) + transport = WINEBLUETOOTH_DISCOVERY_TRANSPORT_LE; + else if (filter->bredr) + transport = WINEBLUETOOTH_DISCOVERY_TRANSPORT_BR_EDR; + else + transport = WINEBLUETOOTH_DISCOVERY_TRANSPORT_DEFAULT; ``` Why convert to an intermediate set of flags instead of just passing the params directly to the Unix side? Aside from the fact that the bitfield might not work, but it's pretty unnecessary anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7216#note_94694

1 0

[PATCH v5 0/3] MR7237: Draft: include: Fix ReadNoFence64 on i386.
by Jinoh Kang (＠iamahuman) 15 Feb '25

15 Feb '25

64-bit volatile accesses are not atomic on i386. Both i686-w64-mingw32-gcc and x86 MSVC splits 64-bit loads into a pair of load/store ops. Fix this by using a FILD/FISTP pair, which is also used to implement C11 atomics by i686-w64-mingw32-gcc. Fixes: f82b1c1fcf770a5d6fa02c3f286282be79a201b8 -- v5: include: Prevent misuse of __WINE_ATOMIC_* helper macros for non-atomic large accesses. server: Fix incorrect usage of __WINE_ATOMIC_STORE_RELEASE in SHARED_WRITE_BEGIN/SHARED_WRITE_END. include: Fix ReadNoFence64 on i386. https://gitlab.winehq.org/wine/wine/-/merge_requests/7237

4 13

[PATCH v2 0/2] MR6006: dwmapi: Simulate DwmFlush blocking behavior.
by Grazvydas Ignotas (＠notaz) 14 Feb '25

14 Feb '25

The documentation states it's a blocking call. There are reports of it being used for WaitForVBlank-like purposes [1]. Without blocking Softube VST plugin logic breaks and they never update their UIs. [1] https://news.ycombinator.com/item?id=34501612 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56935 -- v2: dwmapi: Simulate DwmFlush blocking behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/6006

5 10

[PATCH 0/3] MR7338: Add FlushProcessWriteBuffers() tests
by Jinoh Kang (＠iamahuman) 14 Feb '25

14 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7338

3 4