February 2025 - Wine-gitlab

[PATCH 0/1] MR7285: urlmon/tests: Use wide character string literals.
by Alex Henrie (＠alexhenrie) 07 Feb '25

07 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7285

3 2

[PATCH v7 0/14] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v7: dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG dlls/oleaut32: Scope indexer to loops in fn[Is|Find]Name() dlls/oleaut32: Factor out TLB_get_funcparams_by_name() dlls/oleaut32: Factor out TLB_get_funcdesc_by_name() dlls/oleaut32: Validate args of ITypeLib2_fnIsName() dlls/oleaut32: fn(Is|Find)Name should set szNameBuf with correct case dlls/oleaut32: Use consistent param identifiers in fnFindName dlls/oleaut32: Mostly mirror fnFindName impl in typelib.c dlls/oleaut32: Use common and correct identifiers in typelib.c dlls/oleaut32: Consistently use lstrcmpiW() while looking for names https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 14

Re: [PATCH v5 0/2] MR7230: dmime: Fix loading and default soundfont collection. - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

1 0

Re: [PATCH v2 0/2] MR7280: gdiplus/tests: Extend a GdipGetPathGradientBlend() test with excessive output buffer size. - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7280

1 0

Re: [PATCH v18 0/4] MR4551: Server-side thread priorities implementation (Part 1) - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

1 0

Re: [PATCH v2 0/6] MR7284: Splay tree part 5 - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7284

1 0

Re: [PATCH v4 0/2] MR7283: documentation: Mac OS X became macOS from 10.12 - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7283

1 0

Re: [PATCH v2 0/2] MR7282: winemac: Fix issues found with Main Thread Checker - approved
by Alexandre Julliard (＠julliard) 07 Feb '25

07 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7282

1 0

[PATCH v6 0/15] MR7286: dlls/oleaut32: Vastly cleanup and make consistent fnIsName() and fnFindName()
by Edward OC (＠funfunctor) 07 Feb '25

07 Feb '25

Make both method calls; 1. Consistently written with parameter names as per spec. 2. Fix parameter validation to be consistent with spec. 3. Fix szNameBuf parameter semantics as per spec. 4. Fix szNameBuf casing str search as per spec. 5. Factor out common code into TLB_ helpers vastly improves readability. -- v6: dlls/oleaut32: Fix nonsensical memory access in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Avoid ptr arithmetic in MSFT_DoVars() dlls/oleaut32: Avoid ptr arithmetic in ITypeLib2_Constructor_SLTG() dlls/oleaut32: Fix GetRefTypeInfo() test dlls/oleaut32: Shink down ITypeLibComp_fnBind() verbosity some dlls/oleaut32: ptr_size should be a ULONG https://gitlab.winehq.org/wine/wine/-/merge_requests/7286

2 15

[PATCH v4 0/2] MR7230: dmime: Fix loading and default soundfont collection.
by Yuxuan Shui (＠yshui) 07 Feb '25

07 Feb '25

* * * BTW I did try to create tests to make sure we connect collection the same way Windows does it. Problem is `GUID_ConnectToDLSCollection` is not gettable. Then I tried to create a `IDirectMusicPerformance` implementation and intercept `DownloadInstrument`. Interestingly Windows `IDirectMusicSegment::Download` doesn't call `DownloadInstrument` at all, instead it downloads instruments through a private, undocumented interface. So there seems to be no way to test this. -- v4: dmimi: Connect default collection to MIDI bandtrack. dmime: Handle IStream EOF correctly in MIDI parser. https://gitlab.winehq.org/wine/wine/-/merge_requests/7230

3 3