February 2025 - Wine-gitlab

[PATCH v20 0/3] MR7131: DIR command improvements: Make /o by itself behave equal to how it does in Windows
by Joe Souza (＠JoeS209) 05 Feb '25

05 Feb '25

"DIR /o" (no order specifier after /o) hasn't functioned the same as it does on Windows. This change makes the functionality of /o by itself equivalent to behavior on Windows. -- v20: programs/cmd: Remove @todo_wine@ from working tests. programs/cmd: Cleanup DIR /O logic. programs/cmd: Add tests patch from @epo. https://gitlab.winehq.org/wine/wine/-/merge_requests/7131

2 3

Re: [PATCH v3 0/3] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 05 Feb '25

05 Feb '25

On Tue Feb 4 17:55:14 2025 +0000, Tim Clem wrote: > I think this calls for a quick comment (or at least a note in the commit > message) as to why we're using this function. Added a comment, explaining the rationale there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7256#note_93649

1 0

[PATCH v2 0/3] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 05 Feb '25

05 Feb '25

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- v2: ntdll: Replace '0' with 'NULL' in gettimeofday() calls. ntdll: Use __commpage_gettimeofday in NtQuerySystemTime on macOS. ntdll: Always use mach_continuous_approximate_time on macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

2 4

[PATCH 0/2] MR7256: ntdll: monotonic_counter and NtQuerySystemTime performance improvements on macOS.
by Marc-Aurel Zent (＠mzent) 05 Feb '25

05 Feb '25

`mach_continuous_approximate_time()` has the necessary precision for win32 ticks and can be up to 4x faster than `mach_continuous_time()`. Also `clock_gettime( CLOCK_REALTIME, &ts )` calls always end up in `__commpage_gettimeofday( struct timeval *tp )`: ``` * frame #0: 0x00007ff806788763 libsystem_kernel.dylib`__commpage_gettimeofday frame #1: 0x00007ff8066709a3 libsystem_c.dylib`gettimeofday + 45 frame #2: 0x00007ff806678b31 libsystem_c.dylib`clock_gettime + 117 ``` These extra calls, setup and converting from one struct format to another costs another 60 CPU cycles and in my testing makes `NtQuerySystemTime` approximately 30% faster as well with this MR. This is a fairly hot code path (especially when using certain out-of-tree in process synchronization patch sets), so probably worth the optimization here. All of these APIs are available since 10.12. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7256

5 12

Re: [PATCH v3 0/1] MR7115: Added support of case FileAllocationInformation in SetFileInformationByHandle
by Stéphane Bacri 05 Feb '25

05 Feb '25

@julliard Thanks for taking the time to review. About the file size increase, it sounds like a direct consequence of what this function is supposed to do, since it shall allocate some space for a file. Can you detail your thoughts about it? About the tests, I guess you mean unit tests, right? Or did you mean tests on the parameters (say check that size is aligned with cluster size, or > to current size)? In the first case, I'm gonna try to add something, as digging a bit more the code showed that there is a basis. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7115#note_93641

1 0

Re: [PATCH v7 0/1] MR7068: vbscript: class single line multivar - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

1 0

Re: [PATCH v9 0/3] MR7158: wine.inf: Add UBR key - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

1 0

Re: [PATCH v2 0/1] MR7253: po: Update some Russian strings. - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7253

1 0

Re: [PATCH v4 0/1] MR7229: ntdll: Stub NtQuerySystemInformation(SystemLeapSecondInformation). - approved
by Alexandre Julliard (＠julliard) 05 Feb '25

05 Feb '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7229

1 0

[PATCH 0/4] MR7260: wined3d: Clean up some FFP settings a bit.
by Elizabeth Figura (＠zfigura) 05 Feb '25

05 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7260

3 5