March 2025 - Wine-gitlab - list.winehq.org

[PATCH v5 0/1] MR7657: win32u: Store window styles in a DWORD (Coverity).
by Sven Baars (＠sbaars) 26 Mar '25

26 Mar '25

`WS_POPUP` for instance is `0x80000000`, which overflows a `LONG`. Coverity complained about this. The return type of `get_window_long()` already was `DWORD`. -- v5: win32u: Store window styles in a DWORD (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/7657

2 1

[PATCH v4 0/1] MR7657: win32u: Store window styles in a UINT (Coverity).
by Sven Baars (＠sbaars) 26 Mar '25

26 Mar '25

`WS_POPUP` for instance is `0x80000000`, which overflows a `LONG`. Coverity complained about this. The return type of `get_window_long()` already was `DWORD`. -- v4: win32u: Store window styles in a UINT (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/7657

3 4

[PATCH 0/2] MR7661: gdiplus: Fix GdipReversePath for mixed Bezier and Line points in subpath
by Bartosz Kosiorek (＠gang65) 26 Mar '25

26 Mar '25

Fixes Reverse_Pie test in Mono: https://github.com/madewokherd/mono/blob/develop/mcs/class/System.Drawing/T… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7661

3 4

Re: [PATCH v3 0/3] MR7653: windowscodecs/metadata: Always initialize handler pointer. - approved
by Esme Povirk (＠madewokherd) 26 Mar '25

26 Mar '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7653

1 0

[PATCH v4 0/5] MR7636: d3dx9: Implement saving to DDS files in D3DXSaveTextureToFileInMemory().
by Connor McAdams (＠cmcadams) 26 Mar '25

26 Mar '25

The last of the saving patches for d3dx9. :) -- v4: d3dx9: Add support for saving IDirect3DVolumeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DCubeTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9: Add support for saving IDirect3DTexture9 textures to DDS files in D3DXSaveTextureToFileInMemory(). d3dx9/tests: Add more tests for saving textures to DDS files. d3dx9/tests: Add a test for reading back a texture saved as D3DXIFF_JPG. https://gitlab.winehq.org/wine/wine/-/merge_requests/7636

3 12

[PATCH v12 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu 25 Mar '25

25 Mar '25

-- v12: server: Handle hardlinks and casefolding when renaming the same file. server: Handle renames to destinations containing trailing slashes. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

2 8

[PATCH v3 0/2] MR7641: ntdll: Added side effect of KiUserCallbackDispatcher needed for SkyrimSE CreationKit
by Keaton Ens (＠kgzod) 25 Mar '25

25 Mar '25

Push 0x7fff to the stack in __wine_syscall_dispatcher to recreate side effect of KiUserCallbackDispatcher needed by Skyrim Special Edition: Creation Kit to fix a menu resolution bug. Wine Bug: https://bugs.winehq.org/show_bug.cgi?id=58003 -- v3: Revert "Merge branch wine:master into master" https://gitlab.winehq.org/wine/wine/-/merge_requests/7641

5 10

[PATCH v67 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 25 Mar '25

25 Mar '25

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v67: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

8 22

[PATCH 0/1] MR7662: dmime/tests: Use wine_dbgstr_longlong.
by Sven Baars (＠sbaars) 25 Mar '25

25 Mar '25

This fixes a compilation warning on my system. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7662

3 3

[PATCH v2 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 25 Mar '25

25 Mar '25

Follow-up of !2786, which appears to have been abandoned. -- v2: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 6