March 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/5] MR7608: server: Avoid delegating console waits to other objects.
by Elizabeth Figura (＠zfigura) 18 Mar '25

18 Mar '25

Some console objects currently do several unique things: * Delegate waits onto the queue of another object. This is not really a problem for in-process waits, since we can just return the sync object for the delegate. However, it's also unnecessary, adds to the complexity of the server logic, and is one out of one places where this is done. * Make the wait state dependent on the process. This is difficult to emulate with ntsync and would require creating separate server objects for each process, hacking into duplicate_handle. * Fail a wait entirely in certain circumstances. This is pretty much impossible to emulate with in-process waits. Although ntsync has been in development for some time, I have regrettably failed to notice these problems until now. Fortunately, none of these behaviours happen on modern Windows. Although I/O on unbound handles delegates to the console of the current process, the signaled state does not. As the tests here show, the signaled state of a handle depends on the active console of the process in which the handle was created. If that console no longer exists, the signaled state is no longer updated [with one rather inexplicable exception]. Crucially, in current Windows waits never fail, and the state of an object is the same across all process which hold handles to it. Therefore this patch brings our behaviour to closer match current Windows. In theory these are fds and should use default_fd_signaled(). However, the points at which the handles are signaled are completely different, and I/O does not trigger console handles to become signaled when it normally would. Therefore for the time being I've kept the code using custom signaled ops. There is one other oddity related to consoles, which is the existence of console_add_queue(), which seeks to lazily create an input thread when a console is first waited on. This is one out of two places, after this patch, when the wait process is hijacked (the other being message queues). Fortunately this is easy to handle for in-process synchronization objects, by queueing the ioctl from the callback used to retrieve the in-process synchronization object itself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7608

2 5

[PATCH v11 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu 18 Mar '25

18 Mar '25

-- v11: server: Handle hardlinks and casefolding when renaming the same file. server: Handle renames to destinations containing trailing slashes. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

2 11

Re: [PATCH v5 0/1] MR7550: ntdll: Print name for TOKEN_INFORMATION_CLASS - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7550

1 0

Re: [PATCH v2 0/1] MR7398: winex11.drv: Don't add MWM_DECOR_BORDER to windows without a caption. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7398

1 0

Re: [PATCH v3 0/2] MR7601: bluetoothapis: Implement BluetoothGetDeviceInfo. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7601

1 0

Re: [PATCH v3 0/2] MR7595: comctl32/tests: Add a test for LVM_FINDITEM with LVS_OWNERDATA. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7595

1 0

Re: [PATCH v4 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594

1 0

Re: [PATCH v2 0/6] MR7605: PDB rewrite #3 - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7605

1 0

Re: [PATCH v6 0/2] MR7290: kernelbase: Handle correctly paths with forward slashes in ReplaceFileW. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7290

1 0

Re: [PATCH v2 0/1] MR7603: kerberos: Fix imported target name leak. - approved
by Alexandre Julliard (＠julliard) 18 Mar '25

18 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7603

1 0