March 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR7592: d3dx9/tests: Skip some shader tests if we can't create a D3D object.
by Matteo Bruni (＠Mystral) 17 Mar '25

17 Mar '25

Hopefully it should help with some crashes on Rémi's test machines -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7592

2 2

[PATCH 0/1] MR7582: comctl32: Implement EVENT_OBJECT_VALUECHANGE for datetime control.
by Esme Povirk (＠madewokherd) 17 Mar '25

17 Mar '25

Windows implemented this event only for comctl32 v6. Making this behavior version-specific in Wine would be difficult, and I don't expect it to matter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7582

3 2

[PATCH v10 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu 17 Mar '25

17 Mar '25

-- v10: server: Handle hardlinks and casefolding when renaming the same file. server: Handle renames to destinations containing trailing slashes. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

2 8

[PATCH v2 0/8] MR7402: comctl32: Implement IAccessible methods.
by Esme Povirk (＠madewokherd) 17 Mar '25

17 Mar '25

-- v2: comctl32: Implement IOleWindow for SysLink. comctl32: Implement accChild for SysLink. comctl32: Implement get_accChildCount for SysLink. comctl32: Implement accLocation for SysLink. comctl32: Implement get_accDefaultAction for SysLink. comctl32: Implement acc_getName for SysLink. comctl32: Implement get_accState for SysLink controls. comctl32: Include only link items as IAccessible children. https://gitlab.winehq.org/wine/wine/-/merge_requests/7402

3 9

Re: [PATCH v2 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag.
by Piotr Caban (＠piotr) 17 Mar '25

17 Mar '25

The patch generally looks good. It needs some changes for ucrtbase (see comment above). Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594#note_98087

1 0

Re: [PATCH v2 0/1] MR7594: msvcrt: Add _IONBF flag check in _filbuf to avoid dead loop in application which sets the flag.
by Piotr Caban (＠piotr) 17 Mar '25

17 Mar '25

Piotr Caban (@piotr) commented about dlls/msvcrt/file.c: > return EOF; > } > > - if(!(file->_flag & (_IOMYBUF | MSVCRT__USERBUF))) { > + if(!(file->_flag & (_IONBF | _IOMYBUF | MSVCRT__USERBUF))) { ```suggestion:-0+0 if(!(file->_flag & (MSVCRT__NOBUF | _IOMYBUF | MSVCRT__USERBUF))) { ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7594#note_98086

1 0

[PATCH v2 0/5] MR7559: cfgmgr32: Implement CM_Register_Notification and CM_Unregister_Notification.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

The methods are needed to implement Bluetooth device pairing in `bluetoothapis.dll` without having to create a dummy window for `RegisterDeviceNotification`, as that may break CLI applications. `CM_Register_Notification` is implemented as a thin wrapper over `I_ScRegisterDeviceNotification`, mapping `DBT_*` flags to their associated `CM_NOTIFY_*` constants. -- v2: user32: Remove incorrect FIXME warning while registering for DBT_DEVTYP_HANDLE notifications. cfgmgr32: Implement CM_Register_Notification and CM_Unregister_Notification. dinput/tests: Add tests for CM_Register_Notification. cfgmgr32/tests: Add basic tests for CM_(Un)Register_Notification. https://gitlab.winehq.org/wine/wine/-/merge_requests/7559

2 7

Re: [PATCH v10 0/7] MR7472: winebth.sys part 6: Add support for device inquiry/scanning.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

On Mon Mar 17 12:34:11 2025 +0000, Rémi Bernon wrote: > This broke some test validation, see > https://test.winehq.org/data/patterns.html#bluetoothapis:device. The > issue is about using skip from a different file than the test module > being executed. You need to either add a "subtest" call with the other > file name, or pass __FILE__ from the executing test module to the skip_ call. Sorry about that, I have created !7598 to fix this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7472#note_98080

1 0

[PATCH 0/1] MR7598: bluetoothapis/tests: Use the correct file name while skipping tests when no radios are found.
by Vibhav Pant (＠vibhavp) 17 Mar '25

17 Mar '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7598

2 1

[PATCH v3 0/7] MR7565: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Source().
by Mohamad Al-Jaf (＠maljaf) 17 Mar '25

17 Mar '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55759 -- v3: windows.system.profile.systemid: Implement ISystemIdentificationInfo::get_Source(). windows.system.profile.systemid/tests: Add ISystemIdentificationInfo::get_Source() tests. windows.system.profile.systemid: Partially implement ISystemIdentificationStatics::GetSystemIdForPublisher(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7565

3 8