March 2025 - Wine-gitlab - list.winehq.org

[PATCH v5 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v5: ntdll/tests: Add tests for process and thread priority. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 17

Re: [PATCH v2 0/1] MR7526: weraphi.h: Add WerRegisterCustomMetadata(wstr wstr) - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7526

1 0

Re: [PATCH v3 0/1] MR7184: vbscript: Correct resource text for VBSE_PARAMETER_NOT_OPTIONAL - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7184

1 0

Re: [PATCH v3 0/2] MR7493: mp3dmod: Implement an IMFTransform interface. - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7493

1 0

Re: [PATCH v3 0/3] MR7416: wined3d: Interpret Y'CbCr values as being from the reduced range. - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7416

1 0

Re: [PATCH v2 0/2] MR7527: include: Introduce minwinbase.h and sysinfoapi.h header files. - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7527

1 0

Re: [PATCH v2 0/4] MR7518: include: Add some missing D3D declarations. - approved
by Alexandre Julliard (＠julliard) 07 Mar '25

07 Mar '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7518

1 0

[PATCH v4 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v4: ntdll/tests: Add tests for process and thread priority. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 19

[PATCH v3 0/15] MR7516: Server-side thread priorities implementation (Part 3)
by Marc-Aurel Zent (＠mzent) 07 Mar '25

07 Mar '25

This is the continuation of https://gitlab.winehq.org/wine/wine/-/merge_requests/7317. There are a lot of smaller commits (some even no-op renames), because there are some inconsistencies in the codebase currently of what an NT thread priority vs a base thread priority should be and I hope that this clears that up a bit. I tried making the commits as atomic as possible I hope this is fine... There are still a few tiny details missing like fixing up the `list_processes` request and `KeSetPriorityThread` and friends which are either stubs or not correctly working as well. There are also probably a few tests that can be written here (after thread priority boosting has been disabled, cause that makes the behavior on windows very flaky and dynamic). In fact on windows there is some thread priority boost decay going on after the message has been processed (and probably other boosting mechanisms), which this MR does not properly capture, but are also probably not reasonable to implement. This also reverts the commits of https://gitlab.winehq.org/wine/wine/-/merge_requests/1232, which are being effectively overwritten anyways. The `get_thread_priority_info` request was added, because the reply in `get_thread_info` would be otherwise larger than 64 bytes, so it had to be split. -- v3: ntdll/tests: Add tests for process and thread priority. server, ntdll: Fetch both process priority and base_priority. server: Add process base priority helper. kernelbase: Use ProcessPriorityClass info class in GetPriorityClass. kernelbase: Use correct priority in GetThreadPriority. server, ntdll: Fetch both thread priority and base_priority. server, ntdll: Move last thread information to get_thread_info flags. ntdll: Implement ThreadPriority class in NtSetInformationThread. server: Implement setting thread priority directly. server: Add set_thread_priority helper. server: Rename thread priority to base_priority. server: Rename base_priority to effective_priority in apply_thread_priority. server: Infer process priority class in set_thread_priority. include: Use correct PROCESS_PRIORITY_CLASS_* names. include: Add thread priority constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/7516

2 18

[PATCH 0/1] MR7529: msxml3: Correct looping of Document Element properties.
by Spencer Wallace (＠spencerwallace) 07 Mar '25

07 Mar '25

The attribute index is incorrectly incremented when the element contains properties, causing the wrong namespace to be fetched. https://testbot.winehq.org/JobDetails.pl?Key=151709 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7529

2 1