April 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR7927: windowscodecs: Also initialize FlipRotator.bpp field. - approved
by Alexandre Julliard (＠julliard) 30 Apr '25

30 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7927

1 0

[PATCH 0/1] MR7824: winegstreamer: Handle the Stream Group Done event.
by Brendan McGrath (＠redmcg) 30 Apr '25

30 Apr '25

This event indicates that there will be no more data. Handling it like an EOS fixes a dead lock that occurs when a stream completes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7824

3 6

[PATCH v2 0/2] MR7934: mshtml: Validate builtin host functions in IE9+ using prototype_id rather than tid where possible.
by Gabriel Ivăncescu 30 Apr '25

30 Apr '25

-- v2: mshtml: Validate builtin host functions in IE9+ using prototype_id rather mshtml: Store the object_id of the last object in the prototype chain that https://gitlab.winehq.org/wine/wine/-/merge_requests/7934

2 4

[PATCH 0/4] MR7822: wined3d: Move FFP extra states away from STATE_RENDER, part 3/4.
by Elizabeth Figura (＠zfigura) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7822

3 5

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + { > + sock->addr.un.sun_family = WS_AF_UNIX; > + memcpy(sock->addr.un.sun_path, params->addr.sa_data, sizeof(sock->addr.un.sun_path)); > + sock->addr_len = sizeof(sock->addr.un); > + } > + else > + sock->addr_len = sockaddr_from_unix( &bind_addr, &sock->addr.addr, sizeof(sock->addr) ); > } > > update_addr_usage( sock, &bind_addr, v6only ); > > if (get_reply_max_size() >= sock->addr_len) > set_reply_data( &sock->addr, sock->addr_len ); > + > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); here also -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102242

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(params + 1) + params->addr_len, unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) At https://gitlab.winehq.org/wine/wine/-/merge_requests/7519 it is pointed out that changing the working directory may not be a good idea, so it should be checked whether this can be avoided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102237

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > return; > } > > + if (sock->family == WS_AF_UNIX && *addr->sa_data) > + fchdir(server_dir_fd); Here the working directory is also changed, which needs to be reviewed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102239

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > + if (!(unix_path = mem_alloc( unix_path_len + 1 ))) > + return; > + > + memcpy( unix_path, (char *)(&params->addr) + sizeof(struct WS_sockaddr_un), unix_path_len ); > + unix_path[unix_path_len] = '\0'; > + > + base_name = strrchr(unix_path, '/'); > + if (base_name) > + { > + if (base_name != unix_path) > + (++base_name)[-1] = '\0'; > + } > + else > + base_name = unix_path; > + > + if (chdir( unix_path ) == -1) chdir() is also used here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102240

1 0

Re: [PATCH v25 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 30 Apr '25

30 Apr '25

Ralf Habacker (@rhabacker) commented about server/sock.c: > if (errno == EADDRINUSE && sock->reuseaddr) > errno = EACCES; > > - set_error( sock_get_ntstatus( errno ) ); > - return; > + /* Windows' AF_UNIX implementation has an edge case allowing for a socket to bind to > + * an empty path. Linux doesn't, so it throws EINVAL. We check for this situation > + * here and avoid early-exiting if it's the case. */ > + if (!(errno == EINVAL && sock->family == WS_AF_UNIX && !*params->addr.sa_data)) > + { > + set_error( sock_get_ntstatus( errno ) ); > + if (sock->family == WS_AF_UNIX && *params->addr.sa_data) > + fchdir(server_dir_fd); This should be changed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_102241

1 0

[PATCH 0/4] MR7939: ntdll: Implement ProcessBasePriority class in NtSetInformationProcess.
by Marc-Aurel Zent (＠mzent) 30 Apr '25

30 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7939

2 4