April 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + csbi.dwCursorPosition.X = 0; /* First column in the row. */ > + cCount -= chars; > + } > +} > + > +static void SetCursorVisible(const HANDLE hOutput, const BOOL visible) > +{ > + CONSOLE_CURSOR_INFO cursorInfo; > + > + if (GetConsoleCursorInfo(hOutput, &cursorInfo)) { > + cursorInfo.bVisible = visible; > + SetConsoleCursorInfo(hOutput, &cursorInfo); > + } > +} > + > +static void FindSearchPos(const WCHAR *inputBuffer, int len, PSEARCH_CONTEXT sc) same remark as above: please use WCMD_parameter to loop across words and determine which word contains current cursor positiion -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101931

1 0

Re: [PATCH v21 0/1] MR7843: cmd: Implement tab completion for command line entry.
by eric pouech (＠epo) 26 Apr '25

26 Apr '25

eric pouech (@epo) commented about programs/cmd/lineedit.c: > + /* curPos is often numRead - 1, but not always, as in the case where history is retrieved > + * and then user backspaces to somewhere mid-string and then hits Tab. > + */ > + TRACE("numRead: %lu, curPos: %u\n", *numRead, curPos); > + > + switch (inputBuffer[curPos]) { > + case L'\t': > + TRACE("TAB: [%s]\n", wine_dbgstr_w(inputBuffer)); > + inputBuffer[curPos] = L'\0'; > + len = curPos; > + sc.haveSearchResult = FALSE; > + > + /* See if we need to reset an existing search. */ > + if (sc.hSearch != INVALID_HANDLE_VALUE) { > + /* If tab key was hit at a different location than last time */ > + if (curPos != oldCurPos) { that's not sufficient, you have also to compare that inputbuffer up to current pos hasn't changed since previous call (eg directory with za, za2 and zb zb2 files... circle twice from "za", replace "za" by "zb" and circle with tab...) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_101932

1 0

[PATCH v3 0/2] MR7908: Fix macOS winetest timeout in kernel32:virtual
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

Work around slow runtime of current FlushProcessWriteBuffers() implementation on macOS. The total iteration count becomes: ``` - positive half: 32768 * 1 (old) = 8192 * 4 (new) - negative half: 32768 * 1 (old) > 8192 * 1 (new) ``` -- v3: kernel32/tests: Shorten time for negative half of litmus test for FlushProcessWriteBuffers(). kernel32/tests: Run store_buffer_litmus_test() in a single-iteration loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/7908

2 2

[PATCH v2 0/2] MR7908: Fix macOS winetest timeout in kernel32:virtual
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

Work around slow runtime of current FlushProcessWriteBuffers() implementation on macOS. The total iteration count becomes: ``` - positive half: 32768 * 1 (old) = 8192 * 4 (new) - negative half: 32768 * 1 (old) > 8192 * 1 (new) ``` -- v2: kernel32/tests: Shorten time for negative half of litmus test for FlushProcessWriteBuffers(). https://gitlab.winehq.org/wine/wine/-/merge_requests/7908

2 2

[PATCH v2 0/2] MR7895: Revert "kernel32/tests: Don't use _ReadWriteBarrier on ARM platforms."
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

This reverts commit 504a305a60849704f2d83b55e9aabb26d89edf11. The choice of weak barrier was by design. The stronger barrier broke the positive half of the litmus test for FlushProcessWriteBuffers(): > virtual.c:4568: Test failed: expected write-read reordering with compiler barrier > only (got 0 reorderings) FlushProcessWriteBuffers() is used in tandem with a compiler-only barrier to implement fast synchronization, where only one side is executed frequently and the other side only occassionally (e.g., garbage collection). Prominent applications include .NET and HotSpot JVM. Although _ReadWriteBarrier() is "marked deprecated," it is in fact used by Microsoft's own STL library (with explicit suppression of warning) to implement a compiler-only memory barrier[^1]. The deprecation notice suggests C++11 atomics as the (only?) alternative. [^1]: https://github.com/microsoft/STL/blob/b5df16a98934319e2e6864d6036cbe9cd9c74… -- v2: kernel32/tests: Don't use _ReadWriteBarrier() on clang. https://gitlab.winehq.org/wine/wine/-/merge_requests/7895

2 3

[PATCH 0/1] MR7895: Revert "kernel32/tests: Don't use _ReadWriteBarrier on ARM platforms."
by Jinoh Kang (＠iamahuman) 26 Apr '25

26 Apr '25

This reverts commit 504a305a60849704f2d83b55e9aabb26d89edf11. The choice of weak barrier was by design. The stronger barrier broke the positive half of the litmus test for FlushProcessWriteBuffers(): > virtual.c:4568: Test failed: expected write-read reordering with compiler barrier > only (got 0 reorderings) FlushProcessWriteBuffers() is used in tandem with a compiler-only barrier to implement fast synchronization, where only one side is executed frequently and the other side only occassionally (e.g., garbage collection). Prominent applications include .NET and HotSpot JVM. Although _ReadWriteBarrier() is "marked deprecated," it is in fact used by Microsoft's own STL library (with explicit suppression of warning) to implement a compiler-only memory barrier[^1]. The deprecation notice suggests C++11 atomics as the (only?) alternative. [^1]: https://github.com/microsoft/STL/blob/b5df16a98934319e2e6864d6036cbe9cd9c74… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7895

4 4

[PATCH 0/3] MR7907: vwin32.vxd: Fix support for vwin32 IOCTLs
by Pali Rohár 26 Apr '25

26 Apr '25

* Remove cases for vwin32 IOCTLs 0x10 and 0x29 numbers as they are unsupported by Windows 9x * Fix functions accepted by IOCTLs VWIN32_DIOC_DOS_IOCTL and VWIN32_DIOC_DOS_DRIVEINFO * Add missing IOCTL VWIN32_DIOC_DOS_INT13 case for TRACE log -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7907

1 3

[PATCH 0/6] MR7861: krnl386: Fixes for DPMI functions
by Pali Rohár 26 Apr '25

26 Apr '25

* Set carry flag for every failed DPMI call * Fix return value for DPMI calls 0102h, 0202h and 0900h-0902h * Fix comments and FIXME -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7861

4 14

[PATCH v4 0/4] MR6885: Draft: cmd: Use the console output codepage to read batch files.
by Akihiro Sagawa (＠sgwaki) 26 Apr '25

26 Apr '25

To prevent performance degradation, we will cache the result of GetConsoleOutputCP() after executing every external command. -- v4: cmd: Use the console output code page to read batch files. programs/cmd: Factor out code_page when searching for a label. cmd/tests: Add updated code page test in batch file. cmd: Use the OEM code page if GetConsoleOutputCP fails. https://gitlab.winehq.org/wine/wine/-/merge_requests/6885

4 7

[PATCH 0/1] MR7904: krnl386: Fix return value for DPMI 0900h-0902h calls (Virtual Interrupt State)
by Pali Rohár 26 Apr '25

26 Apr '25

According to the DPMI specification, DPMI functions 0900h-0902h related to Virtual Interrupt State has to always return state in AL register. As wine does not support disabling virtual interrupt flag, report that interrupts are always enabled (AL=1). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7904

1 1