April 2025 - Wine-gitlab - list.winehq.org

[PATCH v4 0/2] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) 24 Apr '25

24 Apr '25

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8) (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v4: v3: Only print pointer in FIXME. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

2 2

[PATCH v2 0/1] MR7859: gdi32/tests: Remove one test for NtGdiMakeFontDir.
by Bernhard Übelacker 24 Apr '25

24 Apr '25

The call to NtGdiMakeFontDir fails just below Windows 10-1607, therefore this test fails in Windows 10-1607 and above. Followup of 5a6a75a5ff. [Link to the pattern page.](https://test.winehq.org/data/patterns.html#gdi32:font) Edit: Outdated, was the first version of the patch: [A testbot run with this patch.](https://testbot.winehq.org/JobDetails.pl?Key=157999) -- v2: gdi32/tests: Remove one test for NtGdiMakeFontDir. https://gitlab.winehq.org/wine/wine/-/merge_requests/7859

2 4

[PATCH 0/1] MR7891: winewayland: Support building with older EGL headers.
by Alexandros Frantzis (＠afrantzis) 24 Apr '25

24 Apr '25

Support building on systems with older EGL headers, which may not include the EGL_EXT_present_opaque extension. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57941 -- Note that this MR doesn't change the runtime requirement for EGL_EXT_present_opaque. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7891

2 1

[PATCH v3 0/1] MR7781: combase: Add stub for RoOriginateErrorW.
by Louis Lenders (＠xe) 24 Apr '25

24 Apr '25

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8) (After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs) -- v3: combase: Add stub for RoOriginateErrorW. https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

4 3

[PATCH 0/2] MR7890: msvcrt: Avoid dynamic allocation when storing locale name.
by Piotr Caban (＠piotr) 24 Apr '25

24 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7890

2 2

[PATCH v5 0/2] MR7672: Draft: mfplat/tests: Add tests for Byte Stream Output.
by Brendan McGrath (＠redmcg) 24 Apr '25

24 Apr '25

This MR adds tests that examine the values of the samples output by the byte stream handlers. It is marked as draft as it is dependent on the fixes included within MR !7569. I've also renamed the tests as they previously exclusively tested the sample output timestamps. The tests now also look at the number of buffers included in a sample and total size of the buffers within a sample. -- v5: mfplat/tests: Add tests for MP3 Byte Stream Output. mfplat/tests: Add tests for Byte Stream Output. https://gitlab.winehq.org/wine/wine/-/merge_requests/7672

2 2

[PATCH v2 0/1] MR7669: Draft: ntdll/server: Make robust to spurious short writes
by Bernhard Übelacker 24 Apr '25

24 Apr '25

Version 1 of the patch by Keno Fischer. -- v2: ntdll/server: Make robust to spurious short writes https://gitlab.winehq.org/wine/wine/-/merge_requests/7669

3 5

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 23 Apr '25

23 Apr '25

On Wed Apr 23 23:51:29 2025 +0000, Brendan McGrath wrote: > > Just so I understand, SAR clock jumps to pts + \<time it actually took > to play this sample/time it would take according to sample rate\> or it > jumps blindly to pts + mf sample duration, ignoring actual playback > time? I don't know how well sample duration is validated against actual > buffer sizes. > It will jump to PTS and then progress from there at the playback rate. I > don't think it uses the duration value, just buffer size to determine > duration (which is easy to calculate based on frame size and sample rate). I should add that the clock stops once playback of the provided sample(s) are complete. It won't start again until it receives another sample. But if that happens, it seems to add an implicit discontinuity. And after a discontinuity (either implicit as described above, or explicit via a sample attribute) it doesn't just jump forward anymore. It will instead insert a period of silence, so the clock will progress at the playback rate until the next PTS, and at that point it'll start playing the next sample. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101769

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 23 Apr '25

23 Apr '25

> Just so I understand, SAR clock jumps to pts + \<time it actually took to play this sample/time it would take according to sample rate\> or it jumps blindly to pts + mf sample duration, ignoring actual playback time? I don't know how well sample duration is validated against actual buffer sizes. It will jump to PTS and then progress from there at the playback rate. I don't think it uses the duration value, just buffer size to determine duration (which is easy to calculate based on frame size and sample rate). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101767

1 0

Re: [PATCH v5 0/2] MR7833: mf: Update state and start clock for both paused and stopped.
by Brendan McGrath (＠redmcg) 23 Apr '25

23 Apr '25

> Is this an artifact of your tracing or OnClockRestart() is actually never used? It was calling `OnClockStart`, but it turns out that was because I had hard-coded the value in my `MESourceStarted` and `MEStreamStarted` events. After changing these events to instead use `pvarStartPosition` passed in `IMFMediaSource::Start`, I get: ``` 1330.024952|10088|source_mock_Start: format: {00000000-0000-0000-0000-000000000000} (GUID_NULL) position: <EMPTY> 1330.025598|10088|clock_sink_OnClockRestart: system time 13300255028 ``` So sending those events with a hard-coded `VT_I8` value of zero caused `OnClockStart` to be called, but now those events have a value of `VT_EMPTY` and `OnClockRestart` is called. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101766

1 0