April 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > process_wayland.zwp_relative_pointer_manager_v1, > pointer->wl_pointer); > zwp_relative_pointer_v1_add_listener(pointer->zwp_relative_pointer_v1, > - &relative_pointer_v1_listener, NULL); > + &relative_pointer_v1_listener, &accum); Let's place the accumulated x and y values in wayland_pointer, since it's really a per-pointer state (currently per-process since we have a single pointer). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101263

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > pointer_handle_axis_discrete > }; > > +/********************************************************************** > + * wayland_motion_delta_to_window > + * > + * Converts the surface-local delta to window (logical) coordinate delta. > + */ > +static void wayland_motion_delta_to_window(struct wayland_surface *surface, > + double surface_x, double surface_y, > + double *window_x, double *window_y) Nit: Align with parameters above -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101262

1 0

Re: [PATCH v4 0/1] MR7806: winewayland: Implement relative motion accumulator
by Alexandros Frantzis (＠afrantzis) 17 Apr '25

17 Apr '25

Alexandros Frantzis (@afrantzis) commented about dlls/winewayland.drv/wayland_pointer.c: > { > INPUT input = {0}; > HWND hwnd; > - POINT screen; > + struct wayland_point screen = {0.0}, *d_accum = private; > struct wayland_win_data *data; > > if (!(hwnd = wayland_pointer_get_focused_hwnd())) return; > if (!(data = wayland_win_data_get(hwnd))) return; > + if (!private) return; > > - wayland_surface_coords_to_window(data->wayland_surface, > + wayland_motion_delta_to_window(data->wayland_surface, > wl_fixed_to_double(dx), Nit: realign to arguments above -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7806#note_101264

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 17 Apr '25

17 Apr '25

I'm using this demo player based on mfplay https://github.com/microsoft/Windows-classic-samples/tree/main/Samples/Win7…, and start->pause->restart works fine there for the audio. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101261

1 0

Re: [PATCH v2 0/1] MR7833: mf: Update state and start clock for both paused and stopped.
by Nikolay Sivov (＠nsivov) 17 Apr '25

17 Apr '25

This is already working using OnClockRestart(). How does it break in your testing? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7833#note_101260

1 0

[PATCH 0/4] MR7826: ntdll: Fix some more Valgrind warnings.
by Sven Baars (＠sbaars) 17 Apr '25

17 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7826

3 5

[PATCH v3 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- v3: bcrypt: Add BCryptKeyDerivation partial implementation (PBKDF2 algorithm). https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

2 8

[PATCH v2 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- v2: bcrypt: Add BCryptKeyDerivation partial implementation (PBKDF2 algorithm). bcrypt: Reorganize hash_handle_from_desc helper so it can be reused. bcrypt: Handle PBKDF2 in BCryptGenerateSymmetricKey. bcrypt: Handle PBKDF2 in BCryptGetProperty. bcrypt: Add PBKDF2 algorithm provider. bcrypt: Fix BcryptDeriveKeyPBKDF2 with NULL salt. include: Add some PBKDF2 related definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

3 9

[PATCH 0/7] MR7836: bcrypt: Partial BCryptKeyDerivation implementation (PBKDF2).
by Piotr Caban (＠piotr) 17 Apr '25

17 Apr '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7836

3 9

Re: [PATCH v5 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.
by Brendan McGrath (＠redmcg) 17 Apr '25

17 Apr '25

On Thu Apr 17 07:54:50 2025 +0000, Rémi Bernon wrote: > Have you tried GstVideoTimeCodeMeta / do you know what it does? No, I didn't look at that. But taking a look now, it looks like it might be good for Video PTS/DTS, but wouldn't work for audio. I'm not sure for duration either. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7623#note_101244

1 0