April 2025 - Wine-gitlab - list.winehq.org

[PATCH v4 0/1] MR7810: cryptext: Implement CryptExtOpenCER.
by Dmitry Timoshkov (＠dmitry) 15 Apr '25

15 Apr '25

-- v4: cryptext: Implement CryptExtOpenCER. https://gitlab.winehq.org/wine/wine/-/merge_requests/7810

3 3

[PATCH v6 0/2] MR7796: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE.
by Charlotte Pabst (＠CharlottePabst) 15 Apr '25

15 Apr '25

This fixes a misbehaving proton game that sets MF_XVP_PLAYBACK_MODE. MF_XVP_PLAYBACK_MODE isn't mentioned in microsoft docs, but it's explained and used in the MIT-licensed [Windows-classic-samples](https://github.com/microsoft/Windows-classic-sampl… Not sure if mfplat is the right place to add the tests for this since the code is in winegstreamer, but it's very similar to the existing mfplat tests and the test does not interface with winegstreamer directly. It should be noted that on windows, ProcessOutput errors out if we provide a pSample with MF_XVP_PLAYBACK_MODE unset, wine simply ignores it. -- v6: winegstreamer: Allow caller to allocate samples in MF_XVP_PLAYBACK_MODE. mfplat/tests: Add test for MF_XVP_PLAYBACK_MODE. https://gitlab.winehq.org/wine/wine/-/merge_requests/7796

3 4

[PATCH v3 0/5] MR7812: win32u: Add more CompStrAttr, CompStrClause implementation using cursor_begin, cursor_end concept.
by Byeongsik Jeon (＠bsjeon) 15 Apr '25

15 Apr '25

If CompStrAttr and CompStrClause are properly configured, Japanese input will be more comfortable. Inspired by cursor_begin and cursor_end from Wayland zwp_text_input_v3 preedit_string, I extended the cursor_pos concept as follows: cursor_pos = MAKELONG( cursor_begin, cursor_end ); ime_to_tascii_ex() uses this to construct CompStrAttr, CompStrClause. MS Windows native CompStrAttr, CompStrClause is a bit more complicated than this, but the concept is useful enough. It requires additional implementation in the Wine ime_ui_window proc and richedit control. However, it is useful for applications that inline ime composition string. This can be tested with MS Office Word, Excel. LANG=ja_JP.UTF-8 wine EXCEL.EXE Test key sequences: - “n-i-h-o-n-g-o-n-o-m-o-j-i-d-e-s-u-.-SPACE”. - And, RIGHT, LEFT, Shift+LEFT, Shift+RIGHT, SPACE, UP, DOWN, ESC, etc. -- v3: winex11: Update only when caret pos changed in xic_preedit_caret. winex11: Extend cursor_pos using cursor_begin, cursor_end. winemac: Extend cursor_pos using cursor_begin, cursor_end. winewayland: Extend cursor_pos using cursor_begin, cursor_end. win32u: Add more CompAttr, CompClause implementation using cursor_begin, cursor_end concept. https://gitlab.winehq.org/wine/wine/-/merge_requests/7812

2 6

[PATCH v17 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v17: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

2 6

[PATCH v16 0/7] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Follow-up of !2786, which appears to have been abandoned. -- v16: server: Fixup for deleting socket files https://gitlab.winehq.org/wine/wine/-/merge_requests/7650

3 10

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > set_error( STATUS_OBJECT_NAME_COLLISION ); > goto error; > } > ftruncate( fd->unix_fd, 0 ); Here is a direct usage of the `unix_fd`, which may be a problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100892

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:51:04 2025 +0000, Ralf Habacker wrote: > and added to the opened inode list. This is normal behavior and not fd_unix related. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100890

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:43 2025 +0000, Ralf Habacker wrote: > and is set as the `fd->closed` Here is no fd_unix related issue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100888

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

On Tue Apr 15 07:50:06 2025 +0000, Ralf Habacker wrote: > Here the `unix_fd` is saved for closing the file, which is -1 in the > case of sockets. `unix_fd` is used in `inode_close_pending()`, `inode_destroy()`, `inode_add_closed_fd()`, `fd_destroy()` and `unmount_fd()` to close the file. In any of the mentioned location the call to close() is guarded with `if (fd->unix_fd != -1)`, so these function are already save the socket case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100886

1 0

Re: [PATCH v15 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Ralf Habacker (＠rhabacker) 15 Apr '25

15 Apr '25

Ralf Habacker (@rhabacker) commented about server/fd.c: > fd->inode = inode; > fd->closed = closed_fd; > fd->cacheable = !inode->device->removable; > list_add_head( &inode->open, &fd->inode_entry ); and added to the opened inode list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100884

1 0