May 2025 - Wine-gitlab - list.winehq.org

[PATCH v2 0/6] MR7989: include: Fix some typoed vtable call macros.
by Alfred Agrell (＠Alcaro) 08 May '25

08 May '25

One of them found by @zfigura, the rest found by `grep -rI '\->lpVtbl->' | grep -P '#\s*define\s+I\w*_(\w+)\s*\(.*->lpVtbl->' | grep -vP '#\s*define\s+I\w*_(\w+)\s*\(.*->lpVtbl->(?:\w+_)?\1'` [02:21:31] \<zf> #define IXACT3Cue_Play(p) (p)->lpVtbl->Destroy(p) [02:21:44] \<zf> this kind of nonsense is why I want to compile everything with widl [02:21:56] \<zf> this took me hours to find -- v2: include/xact3.h: Fix some typoed vtable call macros. include/xact.h: Fix some typoed vtable call macros. include/objbase.h: Fix some typoed comments. include/mapidefs.h: Fix some typoed vtable call macros. include/dpnathlp.h: Fix a typoed vtable call macro. include/d3drmobj.h: Fix some typoed vtable call macros. https://gitlab.winehq.org/wine/wine/-/merge_requests/7989

2 6

[PATCH 0/6] MR7989: include: Fix some typoed vtable call macros.
by Alfred Agrell (＠Alcaro) 08 May '25

08 May '25

One of them found by @zfigura, the rest found by `grep -rI '\->lpVtbl->' | grep -P '#\s*define\s+I\w*_(\w+)\s*\(.*->lpVtbl->' | grep -vP '#\s*define\s+I\w*_(\w+)\s*\(.*->lpVtbl->(?:\w+_)?\1'` [02:21:31] \<zf> #define IXACT3Cue_Play(p) (p)->lpVtbl->Destroy(p) [02:21:44] \<zf> this kind of nonsense is why I want to compile everything with widl [02:21:56] \<zf> this took me hours to find -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7989

2 6

[PATCH 0/1] MR7988: notepad: Restructure menus and make hot-keys unique.
by Mike Swanson (＠chungy) 08 May '25

08 May '25

Some of the hot-keys, such as “Edit→Cut” and “Edit→Time/Date” had identical “T” hot-keys, as well as “Search→Search” and “Search→Search Next” both being on “S”. With this change, the menus are restructured to match the Windows XP Notepad menus, in item names, capitalization, and hot-keys. Notably the usability issue with conflicting hot-keys is eliminated. Users familiar with the Microsoft Windows Notepad menus and their hot-keys should be able to use Wine Notepad without changing any workflow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7988

2 1

Re: [PATCH v2 0/1] MR7972: ntdll: Treat TokenElevationTypeDefault tokens in the admin group as elevated.
by Rémi Bernon 08 May '25

08 May '25

The test fails on many Windows versions: https://test.winehq.org/data/patterns.html#advapi32:security -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7972#note_102825

1 0

[PATCH 0/2] MR7984: libs: Enable JPEG codec in libtiff.
by Nikolay Sivov (＠nsivov) 08 May '25

08 May '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7984

3 3

Re: [PATCH v3 0/2] MR7654: gdiplus: Implement path to region conversion without gdi32.
by Esme Povirk (＠madewokherd) 08 May '25

08 May '25

On Thu May 8 01:59:54 2025 +0000, Bernhard Übelacker wrote: > @madewokherd: I fear this probably caused a regression: https://bugs.winehq.org/show_bug.cgi?id=58203 The stack trace suggests it's GdipFlattenPath that's actually broken. We wouldn't have been using it before. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7654#note_102821

1 0

[PATCH v2 0/1] MR7961: msvcrt: Fix buffer overflow in __STRINGTOLD_L
by Yuxuan Shui (＠yshui) 07 May '25

07 May '25

__STRINGTOLD_L expects a pointer to a `_LDOUBLE` as its first argument, which we internally declare as `MSVCRT__LDOUBLE`. Problem is, `_LDOUBLE` is 10 bytes long, whereas `MSVCRT__LDOUBLE` is 12 bytes long (ULONG * 3). Writing into the third ULONG is technically a buffer overflow. Declare `MSVCRT__LDOUBLE` instead as 2 ULONGs plus a USHORT. -- v2: msvcrt: Use _LDOUBLE type in exported functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/7961

3 3

Re: [PATCH v4 0/1] MR7872: shell32: Avoid writing past end of xlpFile or lpResult in SHELL_FindExecutable(). - approved
by Alexandre Julliard (＠julliard) 07 May '25

07 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7872

1 0

Re: [PATCH v3 0/7] MR7945: shell32: Rework FO_COPY operation. - approved
by Alexandre Julliard (＠julliard) 07 May '25

07 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7945

1 0

Re: [PATCH v3 0/1] MR7964: quartz/tests: Increase the timeout of a pause test in test_media_event. - approved
by Alexandre Julliard (＠julliard) 07 May '25

07 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7964

1 0