May 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR7964: quartz/tests: Mark a pause test in test_media_event as flaky.
by Alex Henrie (＠alexhenrie) 06 May '25

06 May '25

This test failed on Linux 2 out of the last 67 times on test.winehq.org because IMediaControl_GetState returned VFW_S_STATE_INTERMEDIATE, evidently meaning that the command to pause had been received but not yet carried out. Since pausing is an asynchronous operation in Wine's implementation, mark the test as flaky. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7964

3 3

[PATCH v2 0/7] MR7945: shell32: Rework FO_COPY operation.
by Ziqing Hui (＠zhui) 06 May '25

06 May '25

-- v2: shell32: Add overwrite confirmation for FO_COPY. shell32: Remove useless bFromRelative member. shell32: Rework FO_COPY operation. shell32: Remove a useless index variable in parse_file_list. shell32: Introduce file_entry_{init,destroy} helpers. shell32: Fail if wildcards are in target file names. shell32/tests: More use of check_file_operation helper in test_copy. https://gitlab.winehq.org/wine/wine/-/merge_requests/7945

2 7

Re: [PATCH v2 0/1] MR7965: quartz: Clamp MediaSeeking_GetCurrentPosition to the stop position.
by Elizabeth Figura (＠zfigura) 05 May '25

05 May '25

On Mon May 5 22:39:51 2025 +0000, Elizabeth Figura wrote: > Yeah. It's not quite obvious that this is actually the right thing to do > (native doesn't always do the sensible thing), but a manual test bears > it out, as attached. It could be made into an automatic test, but it's > timing-dependent enough that I'm hesitant to do so. Meh, I forgot to actually attach the test: ``` diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c index df1f02cfd00..cf3a86c0c2e 100644 --- a/dlls/quartz/tests/filtergraph.c +++ b/dlls/quartz/tests/filtergraph.c @@ -5151,9 +5151,11 @@ static void test_graph_seeking(void) hr = IMediaControl_Run(control); ok(hr == S_OK, "Got hr %#lx.\n", hr); +Sleep(6000); hr = IMediaSeeking_GetCurrentPosition(seeking, &time); ok(hr == S_OK, "Got hr %#lx.\n", hr); ok(time < 5000 * 10000, "Got time %s.\n", wine_dbgstr_longlong(time)); + trace("%I64d\n", time); hr = IMediaEventSink_Notify(eventsink, EC_COMPLETE, S_OK, (LONG_PTR)&filter1.IBaseFilter_iface); ok(hr == S_OK, "Got hr %#lx.\n", hr); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7965#note_102623

1 0

Re: [PATCH v2 0/1] MR7966: odbc32: SQLColAttributesW accept field id SQL_COLUMN_NAME. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7966

1 0

Re: [PATCH v2 0/1] MR7965: quartz: Clamp MediaSeeking_GetCurrentPosition to the stop position. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7965

1 0

Re: [PATCH v2 0/2] MR7969: windows.ui: Implement IUISettings5 stub. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7969

1 0

Re: [PATCH v2 0/5] MR7971: netapi32: WOW64 related improvements. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7971

1 0

Re: [PATCH v2 0/1] MR7963: mfmediaengine/tests: Mark a refcount test in test_SetCurrentTime as flaky. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7963

1 0

Re: [PATCH v2 0/1] MR7958: opcservices: Fix string comparison in opc_part_uri_get_rels_uri. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7958

1 0

Re: [PATCH v2 0/3] MR7943: windowscodecs: Fix information strings for the Ico decoder. - approved
by Alexandre Julliard (＠julliard) 05 May '25

05 May '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7943

1 0