June 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Vibhav Pant (＠vibhavp) 30 Jun '25

30 Jun '25

It might be better to make this an enum, and add some documentation for how different values affect how `MaxCapacity` and `RemainingCapacity` get calculated. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108347

1 0

Re: [PATCH v5 0/5] MR8438: cfgmgr32: Device Query API part 1: Add a basic implementation for DevGetObjects.
by Rémi Bernon 30 Jun '25

30 Jun '25

77622615b657feedfb379f51346b4d05a2cbd0c4 still fails with: ``` cfgmgr32.c:561: Test succeeded inside todo block: got len 0 cfgmgr32.c:562: Test succeeded inside todo block: got objects 0000000000000000 cfgmgr32.c:566: Test succeeded inside todo block: got len 0 cfgmgr32.c:567: Test succeeded inside todo block: got objects 0000000000000000 ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8438#note_108344

1 0

Re: [PATCH v3 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Tomas-Mendes-ai (＠Tomas-Mendes-ai) 30 Jun '25

30 Jun '25

On Mon Jun 30 15:44:52 2025 +0000, Vibhav Pant wrote: > Shouldn't this be `!bat->present`? Hi Vibhav, Fear it should, yes. Thank you for catching that. Anything else you'd like to add before I edit the commit and rerun the pipeline? Thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108343

1 0

Re: [PATCH v3 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Tomas-Mendes-ai (＠Tomas-Mendes-ai) 30 Jun '25

30 Jun '25

On Mon Jun 30 10:40:44 2025 +0000, Rémi Bernon wrote: > Are you an AI yourself? Has this been written with an AI? Hi Rémi. No on both accounts. Just an unfortunate automatic suggestion made by github when LLMs were not really a _thing_ yet. That being said, if somethings seems off about the code it's probably because I haven't dabbed in C since college. Any critiques or suggestions are much appreciated. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108342

1 0

Re: [PATCH v3 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Vibhav Pant (＠vibhavp) 30 Jun '25

30 Jun '25

Shouldn't this be `!bat->present`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108339

1 0

Re: [PATCH v5 0/0] MR8378: urlmon: Add PersistentZoneIdentifier COM object - closed
by Mike Kozelkov (＠augenzi) 30 Jun '25

30 Jun '25

This merge request was closed by Mike Kozelkov. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8378

1 0

Re: [PATCH v3 0/5] MR8460: ntdll: Add support for multi-battery systems and energy-reporting batteries on Linux
by Rémi Bernon 30 Jun '25

30 Jun '25

Are you an AI yourself? Has this been written with an AI? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8460#note_108336

1 0

Re: [PATCH v2 0/1] MR8455: kernel32: Update len in the absolute path case.
by Huw Davies (＠huw) 30 Jun '25

30 Jun '25

As pointed out in !8457, this previously failed to deal with the case when the file didn't exist. There are many ways of fixing this; here's one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8455#note_108334

1 0

[PATCH v2 0/1] MR8378: urlmon: Add PersistentZoneIdentifier COM object
by Mike Kozelkov (＠augenzi) 26 Jun '25

26 Jun '25

-- v2: urlmon: Add PersistentZoneIdentifier COM object https://gitlab.winehq.org/wine/wine/-/merge_requests/8378

4 12

[PATCH v2 0/1] MR8436: Draft: mfplat: Optimise 1d Lock of 2d buffer when pitch equals width.
by Brendan McGrath (＠redmcg) 26 Jun '25

26 Jun '25

When the pitch and width are the same, the original 2D buffer can be used. This saves a potentially expensive allocation and memory copy. -- v2: mfplat: Optimise 1d Lock of 2d buffer when pitch equals width. https://gitlab.winehq.org/wine/wine/-/merge_requests/8436

3 5