June 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/6] MR8383: win32u: Move more GL drawable tracking out of the drivers. - approved
by Huw Davies (＠huw) 23 Jun '25

23 Jun '25

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8383

1 0

[PATCH v11 0/7] MR6788: dlls/structuredquery part 1: Introduce new DLL, add stubs.
by Vibhav Pant (＠vibhavp) 23 Jun '25

23 Jun '25

structuredquery is required to support AQS filters in Windows.Devices.Enumeration's `FindAllAsync` methods, this adds a basic set of stubs to get the ball rolling. -- v11: dlls/structuredquery: Add stubs for IQueryParserManager. dlls/structuredquery/tests: Add conformance tests for IQueryParserManager. https://gitlab.winehq.org/wine/wine/-/merge_requests/6788

3 12

[PATCH v7 0/4] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Vibhav Pant (＠vibhavp) 23 Jun '25

23 Jun '25

There seem to be a few special cases here, of which the main one is `DEVPKEY_DeviceInterface_Enabled`. This property key does not have an actual registry entry, but the value read by `SetupDiGetDeviceInterfacePropertyW` corresponds to whether the interface is enabled/linked or not. Likewise, the key cannot be written to either, with `SetupDiSetDeviceInterfacePropertyW` returning `ERROR_ACCESS DENIED`. -- v7: ntoskrnl.exe/test: Add tests for SetupDiGetDeviceInterfacePropertyW with enabled interfaces. setupapi: Implement SetupDiGetDeviceInterfacePropertyW. setupapi: Implement SetupDiSetDeviceInterfacePropertyW. setupapi/tests: Add tests for SetupDi{Set,Get}DeviceInterfacePropertyW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8379

2 5

[PATCH 0/1] MR8345: Draft: windows.web/tests: Fix checking of non-null terminated json.
by Yuxuan Shui (＠yshui) 23 Jun '25

23 Jun '25

check_json_ uses wcslen on the passed json string, which is no good for non-null terminated ones. It should have a length parameter. * * * (made a draft since i am not sure what this test is meant to test, see comment.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8345

3 4

[PATCH 0/2] MR8403: ntdll/tests: Add a test to automatically resize mapped disk file.
by Nikolay Sivov (＠nsivov) 23 Jun '25

23 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8403

2 2

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Conor McCarthy (＠cmccarthy) 23 Jun '25

23 Jun '25

On Mon Jun 23 10:22:32 2025 +0000, Conor McCarthy wrote: > IIRC it was improved by handling MF_E_SHUTDOWN returned by > BeginGetEvent(), but could still get stuck waiting for an event from the > source which can't be received because having the event queue call > Invoke() after shutdown is not Windows behaviour (but did fix the issue > in testing). Robustness against unexpected shutdown in Windows has something to do with the source, because when I tested it with a custom source, the Windows media session would hang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107612

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Conor McCarthy (＠cmccarthy) 23 Jun '25

23 Jun '25

On Mon Jun 23 10:20:43 2025 +0000, Nikolay Sivov wrote: > @rbernon we don't need to remove it in this MR, but other comments apply regardless. IIRC it was improved by handling MF_E_SHUTDOWN returned by BeginGetEvent(), but could still get stuck waiting for an event from the source which can't be received because having the event queue call Invoke() after shutdown is not Windows behaviour (but did fix the issue in testing). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107611

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Nikolay Sivov (＠nsivov) 23 Jun '25

23 Jun '25

On Mon Jun 23 10:13:20 2025 +0000, Nikolay Sivov wrote: > Official code samples for Media Foundation sources do not have anything > like that. If there is a pending request we could respond with > MEMediaSample(MF_E_SHUTDOWN), and any following RequestSample will > return MF_E_SHUTDOWN. Is this not enough? @rbernon we don't need to remove it in this MR, but other comments apply regardless. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107610

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Nikolay Sivov (＠nsivov) 23 Jun '25

23 Jun '25

On Mon Jun 23 10:09:37 2025 +0000, Conor McCarthy wrote: > I wasn't able to prove it uses a callback, but it definitely has some > means for notifying the session, and it wasn't the event queue. Official code samples for Media Foundation sources do not have anything like that. If there is a pending request we could respond with MEMediaSample(MF_E_SHUTDOWN), and any following RequestSample will return MF_E_SHUTDOWN. Is this not enough? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107609

1 0

Re: [PATCH v2 0/2] MR8402: mf/session: Use a dedicated state when source is shutdown.
by Conor McCarthy (＠cmccarthy) 23 Jun '25

23 Jun '25

On Mon Jun 23 10:02:49 2025 +0000, Rémi Bernon wrote: > > And we should get rid of IMFMediaShutdownNotify, I think I missed when > it was added. We should not need any custom interfaces to handle this. > IIRC it was required because shutting down the source also shuts down > its event queue, it's then not possible for the session to be reliably > notified of the shutdown without a dedicated callback. I believe > @cmccarthy checked that it's also using a direct callback on Windows. I wasn't able to prove it uses a callback, but it definitely has some means for notifying the session, and it wasn't the event queue. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8402#note_107608

1 0