June 2025 - Wine-gitlab - list.winehq.org

[PATCH v3 0/3] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Vibhav Pant (＠vibhavp) 20 Jun '25

20 Jun '25

There seem to be a few special cases here, of which the main one is `DEVPKEY_DeviceInterface_Enabled`. This property key does not have an actual registry entry, but the value read by `SetupDiGetDeviceInterfacePropertyW` corresponds to whether the interface is enabled/linked or not. Likewise, the key cannot be written to either, with `SetupDiSetDeviceInterfacePropertyW` returning `ERROR_ACCESS DENIED`. -- v3: setupapi: Implement SetupDiGetDeviceInterfacePropertyW. setupapi: Implement SetupDiSetDeviceInterfacePropertyW. https://gitlab.winehq.org/wine/wine/-/merge_requests/8379

2 3

[PATCH v4 0/4] MR8375: widl: Add rows for the overload attribute.
by Hans Leidekker (＠hans) 20 Jun '25

20 Jun '25

-- v4: widl: Add rows for the deprecated attribute. widl: Add rows for the default_overload attribute. widl: Add rows for the overload attribute. widl: Use a define for maximum name length. https://gitlab.winehq.org/wine/wine/-/merge_requests/8375

4 8

[PATCH v13 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon 20 Jun '25

20 Jun '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v13: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

1 7

[PATCH v12 0/5] MR7848: server: Use events as a sync for several objects.
by Rémi Bernon 20 Jun '25

20 Jun '25

Instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/7815, for https://gitlab.winehq.org/wine/wine/-/merge_requests/7226, this only split the sync ops to a separate vtable and let objects delegate theirs to a separate object. This starts using a event-like interface for most objects, leaving the decision regarding if/how to split sync themselves / integrate inproc syncs for later. -- v12: server: Use an event sync for fd objects. server: Introduce a new event sync object. server: Redirect fd-based objects sync to the fd. server: Add an operation to retrieve an object sync. server: Move object grab/release out of (add|remove)_queue. https://gitlab.winehq.org/wine/wine/-/merge_requests/7848

2 8

[PATCH 0/6] MR8385: ntdll: More integral atoms tests and fixes.
by Rémi Bernon 20 Jun '25

20 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8385

1 6

[PATCH 0/1] MR8384: win32u: Avoid reading GL data past the end of the memory DC bitmap.
by Rémi Bernon 20 Jun '25

20 Jun '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58384 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8384

1 1

[PATCH v3 0/3] MR8375: widl: Add rows for the overload attribute.
by Hans Leidekker (＠hans) 20 Jun '25

20 Jun '25

-- v3: widl: Add rows for the deprecated attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/8375

2 3

[PATCH 0/7] MR8383: win32u: Move more GL drawable tracking out of the drivers.
by Rémi Bernon 20 Jun '25

20 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8383

1 7

[PATCH 0/2] MR8382: msvcr120/tests: Add tests for expf.
by Daniel Lehman (＠dlehman25) 20 Jun '25

20 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8382

3 3

Re: [PATCH v2 0/3] MR8379: setupapi: Implement support for device interface properties (SetupDi{Set,Get}DeviceInterfacePropertyW).
by Etaash Mathamsetty (＠etaash.mathamsetty) 20 Jun '25

20 Jun '25

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/setupapi/devinst.c: > + { > + SETUPDI_GuidToString( &key->fmtid, prop_path + 11 ); > + swprintf( prop_path + 49, ARRAY_SIZE( prop_path ) - 49, L"\\%04X", key->pid ); > + if (!(ret = RegOpenKeyExW( iface->refstr_key, prop_path, 0, KEY_QUERY_VALUE, &property ))) > + { > + size = buf_size; > + ret = RegQueryValueExW( property, NULL, NULL, &val_type, buf, &size ); > + RegCloseKey( property ); > + } > + > + switch (ret) > + { > + case ERROR_SUCCESS: > + case ERROR_MORE_DATA: > + *type = val_type & 0xffff; > + ret = (ret == ERROR_MORE_DATA || !buf) ? ERROR_INSUFFICIENT_BUFFER : ERROR_SUCCESS; If it can't be refactored, you missed a indent here :p -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8379#note_107338

1 0