June 2025 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR8347: musl: Don't use __builtin_rint in clang builds.
by Piotr Caban (＠piotr) 17 Jun '25

17 Jun '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58381 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8347

3 2

[PATCH 0/1] MR8348: wintrust: Fix data length mix-up in asn decoder.
by Yuxuan Shui (＠yshui) 17 Jun '25

17 Jun '25

(I think this is right? realLenBytes is skipped so what's left should be realDataLen bytes? and bytesNeeded also uses realDataLen, not dataLen). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8348

2 1

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Rémi Bernon 17 Jun '25

17 Jun '25

On Tue Jun 17 15:09:00 2025 +0000, Paul Gofman wrote: > This is not the case in practice, SwapBuffers works with NULL context in > WGL and GLX. I recall it is depended on in practice, IIRC the launcher > of Black Desert. Okay well I'm going to change this again to move the surfaces to the DCs in the near future, so it won't be needing the context anymore. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106853

1 0

[PATCH 0/1] MR8343: usp10/tests: Avoid out-of-bound use of glyphItems when nGlyphs mismatches.
by Yuxuan Shui (＠yshui) 17 Jun '25

17 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8343

2 1

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Paul Gofman (＠gofman) 17 Jun '25

17 Jun '25

On Tue Jun 17 13:41:22 2025 +0000, Rémi Bernon wrote: > Hmm, I think it might be needed in theory but I kind of expect apps to > always call wglSwapBuffer with an active context. This is not the case in practice, SwapBuffers works with NULL context in WGL and GLX. I recall it is depended on in practice, IIRC the launcher of Black Desert. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106850

1 0

[PATCH 0/2] MR8341: user32/tests: Fix 2 out-of-bound accesses in dde tests.
by Yuxuan Shui (＠yshui) 17 Jun '25

17 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8341

2 2

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Rémi Bernon 17 Jun '25

17 Jun '25

On Tue Jun 17 13:37:42 2025 +0000, Fabian Maurer wrote: > The `context` nullcheck is now pointless, since it's dereferenced > anyways. Is that nullcheck superflous now, or should another nullcheck > be added? Hmm, I think it might be needed in theory but I kind of expect apps to always call wglSwapBuffer with an active context. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106843

1 0

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL.
by Fabian Maurer (＠DarkShadow44) 17 Jun '25

17 Jun '25

Fabian Maurer (@DarkShadow44) commented about dlls/win32u/opengl.c: > + const struct opengl_funcs *funcs = &display_funcs; > int interval; > HWND hwnd; > > - if (!(funcs = get_dc_funcs( hdc, NULL ))) > - { > - RtlSetLastWin32Error( ERROR_DC_NOT_FOUND ); > - return FALSE; > - } > - driver_funcs = funcs == &display_funcs ? display_driver_funcs : memory_driver_funcs; > - > if (!(hwnd = NtUserWindowFromDC( hdc ))) interval = 0; > else interval = get_window_swap_interval( hwnd ); > > + if (context->memory_pbuffer) return flush_memory_pbuffer( context, hdc, FALSE, funcs->p_glFlush ); > return driver_funcs->p_swap_buffers( context ? context->driver_private : NULL, hwnd, hdc, interval ); The `context` nullcheck is now pointless, since it's dereferenced anyways. Is that nullcheck superflous now, or should another nullcheck be added? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210#note_106842

1 0

[PATCH v10 0/5] MR8174: winebth.sys part 12: Introduce support for Low Energy GATT services
by Vibhav Pant (＠vibhavp) 17 Jun '25

17 Jun '25

Generic ATTribute Profile (GATT) is a protocol used by BLE devices for data exchange. Broadly, every LE device contains one or more GATT services, with each service having multiple characteristics, which contain the actual piece of data to be exchanged. The Win32 BLE api is defined in [`bluetoothleapis.h`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/), and operates on `HANDLE`s to PDOs created by the driver to remote devices and services, using the `GUID_BLUETOOTHLE_DEVICE_INTERFACE` and `GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE` class interfaces respectively. This MR introduces initial support for accessing GATT services on LE devices: * Create PDOs for remote devices that we discover GATT services on, and enabling `GUID_BLUETOOTHLE_DEVICE_INTERFACE` for them. * Because the driver also creates PDOs for bluetooth radios, a tagged union is used to distinguish between device extension values to dispatch IOCTL and PnP IRPs appropriately. * Enumerate through all `org.bluez.GattService1` objects on BlueZ, and store them on the PE driver inside the associated devices. * Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES for device PDOs. * Use the newly added IOCTL to implement [`BluetoothGATTGetServices`](https://learn.microsoft.com/en-us/windows/win32/api/bluetoothleapis/nf-bluetoothleapis-bluetoothgattgetservices). -- v10: bluetoothapis/tests: Add tests for BluetoothGATTGetServices. bluetoothapis: Implement BluetoothGATTGetServices. winebth.sys: Implement IOCTL_WINEBTH_LE_DEVICE_GET_GATT_SERVICES. https://gitlab.winehq.org/wine/wine/-/merge_requests/8174

2 5

[PATCH 0/1] MR8339: oleaut32: In VarFormat do not count '#' in exponent into fractional digits.
by Bernhard Übelacker 17 Jun '25

17 Jun '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58372 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8339

1 1