June 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR8290: secur32/tests: Fix test failure on Windows 11. - approved
by Alexandre Julliard (＠julliard) 12 Jun '25

12 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8290

1 0

Re: [PATCH v6 0/4] MR8210: win32u: Use a pbuffer instead of OSmesa for memory DCs GL. - approved
by Alexandre Julliard (＠julliard) 12 Jun '25

12 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8210

1 0

Re: [PATCH v2 0/1] MR8289: win32u: Fix copy of vulkan surfaces list on window destruction. - approved
by Alexandre Julliard (＠julliard) 12 Jun '25

12 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8289

1 0

Re: [PATCH v2 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8.
by Bernhard Übelacker 12 Jun '25

12 Jun '25

On Thu Jun 12 20:43:38 2025 +0000, eric pouech wrote: > to summarize: > * win7 (and below) don't have new form of console handles (bound ones), > so test shall be skipped (skip_nt) > * test can be run in Window8 (checking that console handles in child are > not closed), but without using NtCompareObject > this new MR disables the tests in Win8 which is not what the initlal intent > so this MR should be reverted, and replaced by reintroducing the logic > in first version of MR!8162 to handle the absence of NtCompareObject by > clearing the corresponding flag Thanks for the hints, I put it together in merge request !8301. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271#note_106404

1 0

Re: [PATCH v2 0/5] MR8281: amstream: More fallout from dynamic format change.
by Elizabeth Figura (＠zfigura) 12 Jun '25

12 Jun '25

Thanks, I've sent 8300. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8281#note_106397

1 0

[PATCH 0/2] MR8300: amstream/tests: Fix two test failures.
by Elizabeth Figura (＠zfigura) 12 Jun '25

12 Jun '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8300

2 2

[PATCH v17 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) 12 Jun '25

12 Jun '25

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- v17: cmd: Allow '+' as delimiter for tab-completion, e.g. 'copy file+file2'. cmd/tests: Add tests to verify COPY command output. cmd: COPY should output file names as they are copied. https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

2 3

[PATCH v16 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) 12 Jun '25

12 Jun '25

In native Windows, the COPY command will display the names of the files as they are copied. Wine should do the same. This change enables that. -- v16: cmd: COPY should output file names as they are copied. cmd: Allow '+' as delimiter for tab-completion, e.g. 'copy file+file2'. https://gitlab.winehq.org/wine/wine/-/merge_requests/8200

2 3

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) 12 Jun '25

12 Jun '25

On Thu Jun 12 17:34:38 2025 +0000, eric pouech wrote: > you should support the same parameters as below > likely you'd better have the {cc=len; } body when > parameter_with_delims() fails I'm not sure that I understand the question. There are the delimiters that WCMD_parameter uses to parse the entire command line into different paths. Then for tab-completion, I need to parse for the search and insert points within each path. These delimiters are not the same. For example, given the following string: DIR C:\tmp C:\windows\sys<tab> WCMD_parameters needs to parse that into the separate paths. Then, once I have C:\windows\sys<tab>, I have to search for C:\windows\sys*, and then insert the results at the last \, i.e. replace sys<tab> with system, etc. There is no need to parse the path for characters like \t, etc., because that cannot exist in a legal path and would have already been parsed out previously by the call to WCMD_parameter. Further, the code at line 141 exists at all because in the case of COPY file1+<tab>, WCMD_parameter finds file1 as the last parameter, but for tab-completion I need to perform a wildcard search starting after the +. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106387

1 0

Re: [PATCH v15 0/3] MR8200: cmd: COPY should output file names as they are copied.
by Joe Souza (＠JoeS209) 12 Jun '25

12 Jun '25

On Thu Jun 12 17:34:46 2025 +0000, eric pouech wrote: > ditto is there a reason to not handle the other delimiters here? Mainly same reason as other answer, that the delimiters that I need to parse within a given path are not the same as the delimiters needed by WCMD_parameter to pass a multi-path string into separate paths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_106386

1 0