June 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR8252: nsiproxy.sys: Fix size mismatch writing into ipstatlist. - approved
by Alexandre Julliard (＠julliard) 11 Jun '25

11 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8252

1 0

Re: [PATCH v2 0/1] MR8276: wbemprox: Pass current directory correctly to CreateProcessW() in process_create(). - approved
by Alexandre Julliard (＠julliard) 11 Jun '25

11 Jun '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8276

1 0

Re: [PATCH v2 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8.
by Alexandre Julliard (＠julliard) 11 Jun '25

11 Jun '25

I don't think it matters much if some tests are skipped on Win8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271#note_106264

1 0

[PATCH v2 0/6] MR8254: msi: Fix installing 64 bit library from 32 bit installer if 32 bit version of it is loaded into installer.
by Paul Gofman (＠gofman) 11 Jun '25

11 Jun '25

-- v2: msi: Fix getting version info for library loaded into wow64 process. msi: Get system directory just once. msi: Allocate buffer in msi_get_file_version_info(). msi/tests: Test insalling 64 bit library loaded into wow64 installer process. version/tests: Test GetFileVersionInfoW() with wow64 FS redirection. kernel32/tests: Test loading dll as resource or datafile with wow64 FS redirection disabled. https://gitlab.winehq.org/wine/wine/-/merge_requests/8254

2 8

Re: [PATCH v2 0/1] MR8271: kernel32/tests: Don't call pNtCompareObjects in Windows 8.
by eric pouech (＠epo) 11 Jun '25

11 Jun '25

to summarize: * win7 (and below) don't have new form of console handles (bound ones), so test shall be skipped (skip_nt) * test can be run in Window8 (checking that console handles in child are not closed), but without using NtCompareObject this new MR disables the tests in Win8 which is not what the initlal intent so this MR should be reverted, and replaced by reintroducing the logic in first version of MR!8162 to handle the absence of NtCompareObject by clearing the corresponding flag -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8271#note_106246

1 0

Re: [PATCH v2 0/1] MR8288: msvcrt: Don't release io memory in msvcrt_free_io.
by Piotr Caban (＠piotr) 11 Jun '25

11 Jun '25

The data needs to be freed when process is not exiting. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8288#note_106245

1 0

Re: [PATCH 0/1] MR8288: msvcrt: Don't release io memory in msvcrt_free_io.
by Yuxuan Shui (＠yshui) 11 Jun '25

11 Jun '25

Maybe `_fcloseall` needs to be removed too? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8288#note_106243

1 0

[PATCH 0/1] MR8273: msvcrt: Make ioinfo for stdio fds static.
by Yuxuan Shui (＠yshui) 11 Jun '25

11 Jun '25

In kernel32/tests/loader.c, child_process will try to write to stdout after calling LdrShutdownProcess. LdrShutdownProcess calls DLL_PROCESS_DETACH on msvcrt, which calls msvcrt_free_io, which frees the ioinfo blocks. So to prevent use after free in this case, we keep the ioinfos for stdin/out/err static. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8273

3 5

[PATCH v2 0/1] MR8228: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo.
by Yuxuan Shui (＠yshui) 11 Jun '25

11 Jun '25

IWinInetHttpInfo_QueryInfo returns a multibyte string, not a wide string. We were also wrongly expecting it to have a NUL terminator. * * * this one doesn't feel good. IWinInetHttpInfo_QueryInfo calls HttpInfo_QueryInfo (urlmon), which calls HttpQueryInfoA (wininet), so it returns char*. but inside, HttpQueryInfoA is calling HttpQueryInfoW and does charset conversion. so we are converting the string to multibyte and back. maybe there's an API that returns wchar* i don't know about. -- v2: mshtml: Fix misuse of IWinInetHttpInfo_QueryInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/8228

4 8

[PATCH 0/1] MR8287: include: Add GetCurrentThreadStackLimits() prototype.
by Nikolay Sivov (＠nsivov) 11 Jun '25

11 Jun '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8287

2 1