June 2025 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR2362: gitlab: Build-Depend on libpcsclite-dev for winscard.
by Francois Gouget (＠fgouget) 20 Aug '25

20 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54656 -- v2: gitlab: Install libpcsclite-dev and pcscd for winscard. https://gitlab.winehq.org/wine/wine/-/merge_requests/2362

4 4

[PATCH 0/3] MR7909: include: Fix IMAGE_OS2_HEADER structure
by Pali Rohár 19 Aug '25

19 Aug '25

This merge request contains fixes for the Windows New Executable structure IMAGE_OS2_HEADER defined in include file winnt.h and used by wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7909

4 13

[PATCH v2 0/1] MR6288: wintypes: Partially implement RoResolveNamespace and add 'Windows.winmd'
by Aaron Hill (＠Aaron1011) 18 Aug '25

18 Aug '25

The Visual Studio 2022 installer needs to be able to lookup a valid WinMD file for the 'Windows.Networking.Connectivity' namespace in order for the installation to start. A normal Windows installation contains lots of individual '.winmd' files (e.g. 'Windows.Networking.winmd'), which we cannot redistribute. Fortunately, Microsoft provides an open-source project called 'windows-rs', which contains a combined 'Windows.winmd' file that is explicitly MIT-licensed: https://github.com/microsoft/windows-rs/blob/master/crates/libs/bindgen/def… Make RoResolveNamespace resolve anything starting with 'Windows' by just pointing to this giant file. A full implementation will require us to actually walk the 'WinMetadata' directory (if the caller provides a custom path) and parse the matched '.winmd' file. However, this implementation is good enough for Visual Studio 2022 To actually run the vs2022 installer, a patch for the SHELL_execute trailing-space bug https://bugs.winehq.org/show_bug.cgi?id=56940 is needed: https://gitlab.winehq.org/wine/wine/-/merge_requests/6079 -- v2: wintypes: Partially implement RoResolveNamespace and add 'Windows.winmd' https://gitlab.winehq.org/wine/wine/-/merge_requests/6288

8 10

[PATCH 0/1] MR5155: user32: add stub for GetPointerDeviceRects.
by Etaash Mathamsetty (＠etaash.mathamsetty) 13 Aug '25

13 Aug '25

might fix https://bugs.winehq.org/show_bug.cgi?id=56363, waiting for a reply -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5155

3 4

[PATCH v3 0/6] MR8445: server: Create inproc sync events for message queues.
by Rémi Bernon 07 Aug '25

07 Aug '25

The message queue needs both an inproc sync, to wake inproc waits on a message and trigger a server request, and a server sync, for when the wait is only on the queue and should be optimized into a single server request. It could be better to avoid a dedicated request to retrieve the queue inproc sync fd, for instance by sending an fd on thread init, but we can use this to duality to gradually introduce inproc syncs requests instead and avoid dead code (even though the code ultimately returns STATUS_NOT_IMPLEMENTED for now). We can change the way queue inproc sync fds are retrieved later on. -- v3: ntdll: Check inproc sync handle access rights on wait. server: Add a request to retrieve the inproc sync fds. server: Create inproc sync events for message queues. ntdll: Retrieve and cache an ntsync device on process init. ntdll: Add stub functions for in-process synchronization. ntdll: Add some traces to synchronization methods. https://gitlab.winehq.org/wine/wine/-/merge_requests/8445

4 12

[PATCH 0/7] MR6971: mshtml: Implement attribute nodes properly in IE9+ modes and prototype chain.
by Gabriel Ivăncescu 07 Aug '25

07 Aug '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6971

2 16

[PATCH v2 0/1] MR8338: gameinput: Add stub dll.
by Oleg Makarenko (＠JacKeTUs) 07 Aug '25

07 Aug '25

Certain games have started using the newest GameInput API and linking to GameInput.dll. Adding a stub library allows these games to launch and enables them to fall back to the DirectInput API if `GameInputCreate` returns an error. Affected games: Le Mans Ultimate -- v2: gameinput: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/8338

5 10

[PATCH v2 0/4] MR3334: Add vccorlib140.dll stub dll.
by Etaash Mathamsetty (＠etaash.mathamsetty) 07 Aug '25

07 Aug '25

When using native xinput in WRC9, vccorlib is needed to make sure xinput doesn't crash. -- v2: wincorlib: Add stub for platform_details_uninit_data. wincorlib: Add stub for platform_details_init_data. vccorlib140: Add stub dll. wincorlib: Add stub dll. https://gitlab.winehq.org/wine/wine/-/merge_requests/3334

4 10

[PATCH 0/1] MR8177: user32/tests: Add tests for DrawTextExW.
by JiangYi Chen (＠meshine) 06 Aug '25

06 Aug '25

@alexhenrie @zhiyi The corresponding Windows test demo is as follows: [test_DrawTextExW.exe](/uploads/ff1eafc9c58ac03b598699a93136484c/test_DrawTextExW.exe) [test_DrawTextExW.c](/uploads/a41719a33c2ee0e057c911933bf55180/test_DrawTextExW.c) Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: I64052ba8aa8161ad83c1811d642aedbe462ef5ea -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8177

2 2

[PATCH 0/1] MR8270: mf: Prevent double submission of session commands.
by Yuxuan Shui (＠yshui) 06 Aug '25

06 Aug '25

This is not the right fix, and I need some help. Let me explain. `session_submit_command` checks that: 1. `session->commands` is empty, and 2. `SESSION_FLAG_PENDING_COMMAND` is NOT set before submitting the `session_op`. The assumption is, if there are queued commands, or if there is a command currently running, that pending command will submit subsequent commands when it completes. However, in this call chain: ``` #0 0x00006fffe1d27ad7 in create_async_result (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1229 #1 0x00006fffe1d222d5 in RtwqCreateAsyncResult (object=object(a)entry=0x0, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0, out=out(a)entry=0x7e6242bac7a0) at ../dlls/rtworkq/queue.c:1245 #2 0x00006fffd45e2096 in MFPutWorkItem (queue=queue(a)entry=1, callback=callback(a)entry=0x7e62489f1c08, state=state(a)entry=0x7e61cb5322b0) at ../dlls/mfplat/queue.c:46 #3 0x00006fffe41244ee in session_command_complete (session=0x7e62489f1be0) at ../dlls/mf/session.c:975 #4 0x00006fffe412d00f in session_reset (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:1051 #5 0x00006fffe41299fc in session_handle_source_shutdown (session=session(a)entry=0x7e62489f1be0) at ../dlls/mf/session.c:2957 #6 0x00006fffe4126e90 in session_events_callback_Invoke (iface=0x7e62489f1c20, result=<optimized out>) at ../dlls/mf/session.c:4445 ``` nowhere was the `SESSION_FLAG_PENDING_COMMAND` flag set. In addition to that, `session_events_callback_Invoke` is not a command. So this could happend: ``` Thread 1 | Thread 2 call session_events_callback_Invoke | | call session_submit_command | <critical section> | list_empty(&session->commands) is true, and PENDING_COMMAND not set | MFPutWorkItem(op) | list_add(&session->commands, op) <- (1) | </critical_section> call session_handle_source_shutdown | <critical_section> | call session_reset | call session_command_complete | list_head(&session->commands) | op is returned because of (1) | MFPutWorkItem(op) again | </critical_section> | ``` The result is this op will be executed twice, and also double freed, because `session_commands_callback_Invoke` releases the `op`. * * * There is even another way an `op` can be submitted twice, `session_handle_start_error` calls `session_reset`, which already calls `session_command_complete`, and later it calls `session_command_complete_with_event` again. I think a missing return? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8270

3 7