July 2025 - Wine-gitlab - list.winehq.org

[PATCH v2 0/11] MR8653: mmdevapi/tests: Add a lot of rendering tests.
by Giovanni Mascellani (＠giomasce) 29 Jul '25

29 Jul '25

!8598 will require some more work, so I wrote a number of tests in preparation for it. There will be another MR for capturing tests. This MR also enable 32-bit PCM samples for PulseAudio, since they're already enabled for other drivers and it's useful to have some uniformity between the drivers in order to avoid making writing todo conditions even more of a nightmare than it already is. 32-bit samples are already enabled to extensible wave formats, so it doesn't seem intentional that they were not enabled for non-extensible formats. -- v2: mmdevapi/tests: Test extensible wave formats when rendering. mmdevapi/tests: Test flag AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM when rendering. mmdevapi/tests: Test flag AUDCLNT_STREAMFLAGS_RATEADJUST when rendering. mmdevapi/tests: Check that Initialize() matches IsFormatSupported() when rendering. mmdevapi/tests: Simplify checking IsFormatSupported() result when rendering. mmdevapi/tests: Test more audio formats when rendering. mmdevapi/tests: Iterate independently on sampling rates, channel counts and sample formats when rendering. winecoreaudio.drv: Do not spam fixmes for unknown channels. https://gitlab.winehq.org/wine/wine/-/merge_requests/8653

3 15

[PATCH v10 0/7] MR8556: winebth.sys part 13: Add support for retrieving GATT characteristics
by Vibhav Pant (＠vibhavp) 29 Jul '25

29 Jul '25

-- v10: winebth.sys: Set additional properties for remote Bluetooth devices. bluetoothapis/tests: Implement tests for BluetoothGATTGetCharacteristics. https://gitlab.winehq.org/wine/wine/-/merge_requests/8556

2 7

[PATCH v9 0/7] MR8556: winebth.sys part 13: Add support for retrieving GATT characteristics
by Vibhav Pant (＠vibhavp) 29 Jul '25

29 Jul '25

-- v9: winebth.sys: Set additional properties for remote Bluetooth devices. bluetoothapis/tests: Implement tests for BluetoothGATTGetCharacteristics. bluetoothapis: Implement BluetoothGATTGetCharacteristics. https://gitlab.winehq.org/wine/wine/-/merge_requests/8556

2 7

[PATCH v2 0/1] MR8659: ntdll: Ensure %cs is correct in sigcontext on x86_64 macOS.
by Brendan Shanks (＠bshanks) 29 Jul '25

29 Jul '25

On x86_64 macOS (real Intel/not under Rosetta), a signal delivered to a thread inside a syscall will have CS in `sigcontext` set to the kernel's selector (0x07, `SYSCALL_CS` in xnu source) instead of the user selector (`cs64_sel`: 0x2b, `USER64_CS`). This causes crashes when running a 32-bit CEF sample or Steam: those do lots of async I/O, SIGUSR1 is received often, and `CS_sig` is `0x07` if received while in `_thread_set_tsd_base`. `get_wow_context()` later compares `SegCs` to `cs64_sel`, sees that it's different, assumes that we are in 32-bit code, and the 32-bit context is used. The top 32-bits of `RIP` and every register are stripped off, and the thread crashes when it tries to return after handling the signal. To fix this, set `CS_sig` to `cs64_sel` unless it's set to `cs32_sel`. As far as I know, these are the only `%cs` values that Wine is expecting to see. It appears that macOS has always done this (I tested back to 10.12), but it wasn't an issue until 3a16aabbf55be5e0416c53b498ed1d085b8d410d/!6866 started doing `_thread_set_tsd_base()` outside of a Wine/NT syscall. -- v2: ntdll: Ensure %cs is correct in sigcontext on x86_64 macOS. https://gitlab.winehq.org/wine/wine/-/merge_requests/8659

2 1

Re: [PATCH v7 0/2] MR8608: comdlg32: Display filter specs in itemdlg File Type combo box - approved
by Esme Povirk (＠madewokherd) 29 Jul '25

29 Jul '25

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8608

1 0

Re: [PATCH v2 0/1] MR8468: winewayland: Only detach/attach client surface if it is different.
by Wilson Simanjuntak (＠wilsontulus) 29 Jul '25

29 Jul '25

This MR might have potentially introduced a regression to certain software using Vulkan child-windowing on Wayland: https://bugs.winehq.org/show_bug.cgi?id=58547 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8468#note_111261

1 0

[PATCH 0/1] MR8659: ntdll: Ensure %cs is correct in sigcontext on x86_64 macOS.
by Brendan Shanks (＠bshanks) 29 Jul '25

29 Jul '25

On x86_64 macOS (real Intel/not under Rosetta), a signal delivered to a thread inside a syscall will have CS in `sigcontext` set to the kernel's selector (0x07, `SYSCALL_CS` in xnu source) instead of the user selector (`cs64_sel`: 0x2b, `USER64_CS`). This causes crashes when running a 32-bit CEF sample or Steam: those do lots of async I/O, SIGUSR1 is received often, and `CS_sig` is `0x07` if received while in `_thread_set_tsd_base`. `get_wow_context()` later compares `SegCs` to `cs64_sel`, sees that it's different, assumes that we are in 32-bit code, and the 32-bit context is used. The top 32-bits of `RIP` and every register are stripped off, and the thread crashes when it tries to return after handling the signal. To fix this, set `CS_sig` to `cs64_sel` unless it's set to `cs32_sel`. As far as I know, these are the only `%cs` values that Wine is expecting to see. It appears that macOS has always done this (I tested back to 10.12), but it wasn't an issue until 3a16aabbf55be5e0416c53b498ed1d085b8d410d/!6866 started doing `_thread_set_tsd_base()` outside of a Wine/NT syscall. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8659

3 3

[PATCH v3 0/7] MR8490: d3dx{9,10}: Beginnings of d3dx code sharing.
by Connor McAdams (＠cmcadams) 28 Jul '25

28 Jul '25

These are the first steps towards code sharing, finally :) Patch 4 is a bit big, but it's just copying code from various source files into a single source file. I can attempt to split if if that's preferable for review purposes. -- v3: d3dx10: Use shared d3dx code in get_image_info when possible. d3dx9: Don't include d3dx9 header in d3dx_helpers. d3dx9: Get rid of ID3DXBuffer usage in d3dx_helpers. d3dx9: Move functions intended for code sharing into a separate source file. d3dx9: Introduce d3dx_image_file_format enumeration. d3dx9: Introduce d3dx_resource_type enumeration. d3dx9: Replace D3DFORMAT constants with enum d3dx_pixel_format_id constants. https://gitlab.winehq.org/wine/wine/-/merge_requests/8490

3 11

[PATCH v3 0/2] MR8658: opengl32: Move thunks declarations to generated header.
by Jacek Caban (＠jacek) 28 Jul '25

28 Jul '25

-- v3: opengl32: Move thunks declarations to generated header. opengl32: Move manual wow64 thunks declarations to generated header. https://gitlab.winehq.org/wine/wine/-/merge_requests/8658

2 3

[PATCH v2 0/2] MR8658: opengl32: Move thunks declarations to generated header.
by Jacek Caban (＠jacek) 28 Jul '25

28 Jul '25

-- v2: opengl32: Move thunks declarations to generated header. opengl32: Move manual wow64 thunks declarations to generated header. https://gitlab.winehq.org/wine/wine/-/merge_requests/8658

3 3