July 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v4 0/2] MR8285: kernelbase: Support extended paths in GetFinalPathNameByHandleW
by Michael Stopa (＠stomy) 21 Jul '25

21 Jul '25

Sorry to ping you @julliard but I didn't see a dedicated maintainer for `kernelbase` and would like to get this reviewed. I'd appreciate it if I could get this into the same release as !8293 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8285#note_110467

1 0

[PATCH v5 0/4] MR8595: comctl32: Separate v5 and v6.
by Zhiyi Zhang (＠zhiyi) 21 Jul '25

21 Jul '25

This MR separates comctl32 into v5 and v6. A full branch is at https://gitlab.winehq.org/zhiyi/wine/-/commits/comctl32-separation. The remaining commits are to remove items that shouldn't be in v5. comctl32-version_6 in wine-staging can be dropped after this MR. -- v5: comctl32: Separate v5 and v6. https://gitlab.winehq.org/wine/wine/-/merge_requests/8595

4 17

Re: [PATCH v8 0/1] MR8573: cmd: tab completion: Treat most delimiters as literals if user specified quotes.
by Joe Souza (＠JoeS209) 20 Jul '25

20 Jul '25

On Sun Jul 20 18:46:01 2025 +0000, Joe Souza wrote: > WCMD_parameter does not handle tab completion. This code here does. > The example path in the comment in this MR above does not work with tab > completion in current code. These changes fix that. Try the example > path with current code and then with my changes here to see for yourself. To be completely clear about this, create a directory named "[2025] Tax Documents" (without the quotes). Then, type ```"[2025] Ta<tab>```. Without my changes here, note that this is incorrectly completed to "[2025][2025] Tax Documents" (note the doubled "[2025][2025]"). This is mentioned in the original comment for the merge request above, but perhaps it wasn't clear. Next, create a file named something like "fil]e1.txt" (or a file containing pretty much any of the other delimiter characters), and test tab completion with those. The results will be incorrect with current code. My changes here fix that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8573#note_110453

1 0

[PATCH v19 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 20 Jul '25

20 Jul '25

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v19: propsys: Implement IPropertyDescription for several known system properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 9

[PATCH 0/1] MR8606: ntdll: Add a stub for RtlQueryProcessHeapInformation().
by Jake Coppinger (＠jakecopp) 20 Jul '25

20 Jul '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8606

2 1

[PATCH v6 0/2] MR8367: shell32: Try to lookup icon, with fallback on failure
by James McDonnell (＠ElementalWarrior) 20 Jul '25

20 Jul '25

Try to lookup icon information from shell32.dll. If an icon is not found, default to the file icon. Instead of defaulting to -1, which was failing for Affinity Photo's installer. -- v6: shell32: add shield icon shell32: Try to lookup icon, with fallback on failure https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

2 2

Re: [PATCH v8 0/1] MR8573: cmd: tab completion: Treat most delimiters as literals if user specified quotes.
by Joe Souza (＠JoeS209) 20 Jul '25

20 Jul '25

On Sun Jul 20 18:46:01 2025 +0000, eric pouech wrote: > I don't fully get why you need specific code here as WCMD_parameter (and > its variants) should already take care of not handling delimiters inside quotes WCMD_parameter does not handle tab completion. This code here does. The example path in the comment in this MR above does not work with tab completion in current code. These changes fix that. Try the example path with current code and then with my changes here to see for yourself. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8573#note_110438

1 0

[PATCH v18 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 20 Jul '25

20 Jul '25

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v18: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. propsys: Add stubs for PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

3 9

[PATCH v2 0/6] MR8261: comctl32/tests: Check RGB value in test_alpha.
by Ziqing Hui (＠zhui) 20 Jul '25

20 Jul '25

We only check alpha value before, now also check red, green, blue. -- v2: comctl32/tests: Also test v5 with test_alpha() comctl32/tests: Test image flags in test_alpha. comctl32/tests: Use winetest_{push,pop}_context in test_alpha. comctl32/tests: Test adding 32bpp images with alpha to 24bpp image list. comctl32/tests: Test image bitmap bits in test_alpha. comctl32/tests: Check RGB value in test_alpha. https://gitlab.winehq.org/wine/wine/-/merge_requests/8261

4 10

[PATCH 0/1] MR8605: winebus: Set FFB autcenter to 0 instead of 100 on device reset
by Tomasz Pakuła 20 Jul '25

20 Jul '25

FFB Autocenter introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/4911 had one major misunderstanding. The USB PID standard doesn't actually define any explicit way to autocenter a device. One could of course use the spring effect with a deadzone of 0 and dead band of 0. This is what I'm actually working on for the Linux PID driver (spring + friction/damper). Some devices implement autocenter in firmware when they receive the DC Disable Actuators command. Very few, if not just one, implement this weird autocenter effect on slot 1. This is, from what I can gather, only implemented on the MS SideWinder joystick(s) and the Windows' USB PID driver is created around these devices. Windows PID driver is a bit out of spec, is quite permissive when it comes to fields missing in the descriptor (basically, only effect types and their effect type blocks are optional). Another thing it does is handling of this out-of-spec autocentering for their joysticks. Funnliy enough, the creator of the Linux PID driver based the initial code on testing with MS Sidewinder so it's autocentering is supported. This is where the autocentering mentioned in the MR comes from. It's not the directinput api that does it but the Windows PID driver. As such, autocentering on reset should be left to the drivers, not handeled by Wine. SDL lacks full reset support and Linux is even more barebones, whre it's not even possible to query the device state, effects etc (something I'm working on slowly). As such, when games send out RESET to prepare the device, the device starts autocentering for no good reason and the effect is not removed once other effect are uploaded and played which would be the case for MS sidewinder. tl;dr Set autocentering to 0 instead of max value when DISFFC_RESET is reveived to remove the unwanted autocenter behavior. Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8605

1 2