July 2025 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR8519: kernel32: Add a stub for CreateBoundaryDescriptorA(). - approved
by Alexandre Julliard (＠julliard) 08 Jul '25

08 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8519

1 0

Re: [PATCH v2 0/1] MR8523: win32u: Fix incorrect length in font extension check. - approved
by Alexandre Julliard (＠julliard) 08 Jul '25

08 Jul '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8523

1 0

[PATCH 0/1] MR8528: server: Strip trailing slashes from NT paths for fds.
by Tim Clem (＠tclem) 08 Jul '25

08 Jul '25

Fixes a regression with af35741d. --- The EA Games launcher depends on `GetFinalPathNameByHandleW` returning a path *without* a trailing slash for directories, even if the handle was opened with one. After af35741d, we now use the server's notion of the fd path (via `NtQueryObject(ObjectNameInformation)`), which will include a trailing slash if that's how the path was specified when opened. A quick test on Windows show that `NtQueryObject(ObjectNameInformation)` for file handles returns a `\Device\...` path. (This is why I didn't add tests for its behavior.) For directories, `ObjectNameInformation` will only return a trailing slash for the root of a device - e.g. `\Device\HarddiskVolume3\` for `C:\`, but `\Device\HarddiskVolume3\Windows` for `C:\Windows\`. Since our `NtQueryObject(ObjectNameInformation)` already doesn't match native (we return `\??\` paths), arguably this change should be made in `GetFinalPathNameByHandleW`. It seemed cleaner in the server though, as we immediately know whether a path points to a directory. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8528

3 2

[PATCH v4 0/3] MR5988: winegstreamer: Output compressed samples from the media source.
by Elizabeth Figura (＠zfigura) 08 Jul '25

08 Jul '25

-- v4: winegstreamer: Output compressed samples from the media source. winegstreamer: Stop on unparsed H.264 in autoplug-continue. winegstreamer: Explicitly append an H.264 parser for H.264. https://gitlab.winehq.org/wine/wine/-/merge_requests/5988

2 3

[PATCH 0/1] MR8529: hhctrl.ocx: Add a search button to the search tab.
by Jacob Czekalla (＠JacobCzekalla) 08 Jul '25

08 Jul '25

Currently the only way to search is to press enter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8529

2 1

[PATCH v5 0/7] MR8415: mf: Get rid of the IMFMediaShutdownNotify interface.
by Rémi Bernon 08 Jul '25

08 Jul '25

As discussed in !8402. @cmccarthy what do you think of this? I think queueing an event right before shutting down the queue is enough to get the media session notified? It won't get the actual event but it will be able to see the MF_E_SHUTDOWN error after calling `EndGetEvent`? -- v5: include: Remove now unnecessary IMFMediaShutdownNotify interface. mf/session: Remove now unnecessary IMFMediaShutdownNotify. winegstreamer: Remove now unnecessary IMFMediaShutdownNotify. mf/session: Handle an optional MEError event from sources on shutdown. winegstreamer: Queue an event before shutting down the event queues. mfsrcsnk: Queue an event before shutting down the event queues. mfplat/tests: Add more tests for event queue shutdown. https://gitlab.winehq.org/wine/wine/-/merge_requests/8415

2 11

[PATCH v2 0/8] MR8505: mfsrcsnk, winegstreamer: Implement thinning.
by Charlotte Pabst (＠CharlottePabst) 08 Jul '25

08 Jul '25

Follow-up to !8184. This also adds a bunch of helpers for writing media source tests (without involving the mf session) in mfsrcsnk, these could be helpful for more tests of this kind in the future. I'm somewhat unsure as to why we haven't done tests for source behavior so far: while those are plugins, applications rely on a bunch of things in the builtin sources that microsoft provides. Since this affects both mfsrcsnk and winegstreamer sources, tests should be run both with `HKCU\\Software\\Wine\\MediaFoundation\\DisableGstByteStreamHandler` enabled and disabled. Due to this I figured it'd make sense to implement everything first and then remove the test todo_wine's and the statements rejecting the thin parameter in a single commit ("Allow thinning"). Perhaps this could be solved more nicely by setting the registry key in the tests themselves? I'm unsure if that is something we do in tests, generally. `MEStreamThinMode` events need to be emitted between the last sample using the outdated thinning parameter and the first sample using the updated thinning parameter. The winegstreamer implementation for this turned out a bit complex, if there is a simpler way to do this please let me know. Regarding winegstreamer, note that buffers need to be intercepted before the decoder because decoders often discard `GST_BUFFER_FLAG_DELTA_UNIT` flags (which is already annoying in itself - it causes all samples to be marked as `MFSampleExtension_CleanPoint`, this should potentially be worked around in the future). But even besides that, intercepting before the decoder is the "proper" implementation, since the point of thinning is increasing decoding speed by skipping delta frames, tho there are some games that rely on the semantics as well. -- v2: mfsrcsnk: Emit MEStreamThinMode event. mfsrcsnk: Move media_source_send_sample. mfsrcsnk: Implement thinning. winedmo: Implement thinning. winedmo: Generate timestamps if missing. winegstreamer: Implement thinning in media source. winegstreamer: Implement thinning in wg_parser. mfsrcsnk/tests: Add tests for thinning. https://gitlab.winehq.org/wine/wine/-/merge_requests/8505

2 9

[PATCH 0/1] MR8520: quartz: Decommit the allocator before entering the streaming CS in AVIDec.
by Anton Baskanov (＠baskanov) 08 Jul '25

08 Jul '25

This prevents a deadlock when the streaming thread is waiting for a buffer in avi_decompressor_sink_Receive(). Reproducible in Earth 2150 - Escape from the Blue Planet (GOG) when trying to skip the intro video and in Commandos 2 - Men of Courage (GOG). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8520

3 3

[PATCH v3 0/2] MR8282: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer.
by Brendan McGrath (＠redmcg) 08 Jul '25

08 Jul '25

This fixes a looping audio issue during seek in VRChat. The issue is that on Windows the stop request in handled immediately thus the AVPro MFT (which loops the audio) can be immediately flushed. Wine currently waits for a pending sample request to be completed before handling the stop request. As a result, the AVPro MFT loops audio whilst it waits for another sample (or to be flushed). This MR releases the source CS before calling `wg_parser_stream_get_buffer` so it does not delay the handling of the stop request. This appears to be safe as the Unix side of `wg_parser_stream_get_buffer` has its own set of primitives. -- v3: winegstreamer: Don't hold lock during wg_parser_stream_get_buffer. https://gitlab.winehq.org/wine/wine/-/merge_requests/8282

3 11

[PATCH 0/1] MR8311: quartz/tests: Fix out-of-bound use of video_types in test_connect_pin.
by Yuxuan Shui (＠yshui) 08 Jul '25

08 Jul '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8311

3 2