September 2025 - Wine-gitlab

[PATCH v2 0/1] MR9052: win32u: Handle errors when creating EGL context
by Vasiliy Stelmachenok (＠ventureoo) 30 Sep '25

30 Sep '25

Some background: I wanted to test EGL backend on my old laptop with Intel graphics limited with OpenGL 2.1 / GLES 2.0. When trying to run any game this led to a crash with NULL GL_RENDERER, but not with GLX. Tracing has shown that wined3d tries to create a context with high `WGL_CONTEXT_MAJOR_VERSION_ARB`/`WGL_CONTEXT_MINOR_VERSION`, which is not supported by hardware, resulting in the creation of nil context in EGL, but due to lack of error handling it's always assumed to be successful. In GLX this results in an error and creating a context does not lead to success, after which it tries again to create a context with a lower `WGL_CONTEXT_MAJOR_VERSION_ARB` / `WGL_CONTEXT_MINOR_VERSION` until the actual context is created. Proper error handling when creating EGL context as in this patch also allows wined3d to work on such hardware. -- v2: win32u: Handle errors when creating EGL context https://gitlab.winehq.org/wine/wine/-/merge_requests/9052

3 2

[PATCH v3 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Connor McAdams (＠cmcadams) 30 Sep '25

30 Sep '25

These patches implement the existing functionality of `load_texture_data()` using shared code. -- v3: d3dx10: Exclusively use shared code in load_texture_data(). d3dx10: Exclusively use shared code to load DDS files in load_texture_data(). d3dx10: Add support for compressing BC4 and BC5 formats. d3dx10: Add support for decompressing BC4 and BC5 formats. d3dx10: Ignore alpha channel values for WICPixelFormat32bppBGR BMP images. d3dx10: Use shared code in load_texture_data() when possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/9034

3 10

[PATCH v10 0/4] MR9010: cfgmgr32: Device query API part 5: Implement support for logical boolean operators in DEVPROP_FILTER_EXPRESSION.
by Vibhav Pant (＠vibhavp) 30 Sep '25

30 Sep '25

Additionally, add explicit rules to the AQS parser for resolving shift/reduce conflicts involving NOT/OR clauses. -- v10: cfgmgr32: Implement support for logical operators in DEVPROP_FILTER_EXPRESSION. cfgmgr32/tests: Add additional tests for device query filters. windows.devices.enumeration: Ensure that all AQS logical operators bind left to right. windows.devices.enumeration/tests: Allow timing out on native while waiting for the Enumerated event on a DeviceWatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/9010

3 7

[PATCH 0/5] MR9075: cfgmgr32: Implement support for logical operators in DEVPROP_FILTER_EXPRESSION.
by Rémi Bernon 30 Sep '25

30 Sep '25

What about doing this for !9010? I think it'd be simpler. I left the test timeout change aside, as commented on the other MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9075

3 7

[PATCH 0/4] MR9076: xmllite/tests: Add more tests for name validation when writing.
by Nikolay Sivov (＠nsivov) 30 Sep '25

30 Sep '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9076

3 5

[PATCH 0/1] MR9052: win32u: Handle errors when creating EGL context
by Vasiliy Stelmachenok (＠ventureoo) 30 Sep '25

30 Sep '25

Some background: I wanted to test EGL backend on my old laptop with Intel graphics limited with OpenGL 2.1 / GLES 2.0. When trying to run any game this led to a crash with NULL GL_RENDERER, but not with GLX. Tracing has shown that wined3d tries to create a context with high `WGL_CONTEXT_MAJOR_VERSION_ARB`/`WGL_CONTEXT_MINOR_VERSION`, which is not supported by hardware, resulting in the creation of nil context in EGL, but due to lack of error handling it's always assumed to be successful. In GLX this results in an error and creating a context does not lead to success, after which it tries again to create a context with a lower `WGL_CONTEXT_MAJOR_VERSION_ARB` / `WGL_CONTEXT_MINOR_VERSION` until the actual context is created. Proper error handling when creating EGL context as in this patch also allows wined3d to work on such hardware. I think the real issue is somewhere in wined3d/wgl and passing wrong version of GL for context at first, but I don’t have proper code base knowledge to talk about it exactly. Anyway, I think that error handling when creating a context like with GLX is necessary in case of such errors. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9052

3 3

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Connor McAdams (＠cmcadams) 30 Sep '25

30 Sep '25

On Mon Sep 29 21:59:33 2025 +0000, Matteo Bruni wrote: > Just a question in passing, unrelated to the patch: do we know if > `D3DX10_FILTER_POINT` is actually the default filter? I've yet to find any explicit mention of the default filter type for d3dx10/d3dx11 in the documentation, but I doubt that it's a point filter :) I intend on writing some tests to try and figure it out now that I have some understanding of the different filter types. Since we don't handle the `Filter` member in the passed in `D3DX10_IMAGE_LOAD_INFO` and the default type is unknown, I've just defaulted to point here. I can print a `FIXME()` somewhere around here if that'd help clarify, or maybe a code comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117155

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Connor McAdams (＠cmcadams) 30 Sep '25

30 Sep '25

On Mon Sep 29 21:59:33 2025 +0000, Matteo Bruni wrote: > If I understand correctly, this affects the output. In which case I'd > avoid calling it an optimization, both in the comment and the commit subject. > It's a bit of a pet peeve of mine, please bear with me... I wrote this patch awhile ago, I _think_ I used the term optimization to bolster my argument for changing this behavior. It technically should be faster as it lets us get out of this function earlier. The decompressed values don't change with this "optimization". The actual compressed data values shouldn't really matter, what should matter is the decompressed values. But, in `check_texture{2d,3d}_data()`, we check for compressed values. What would be a better term to use here? Just "Wine specific change"? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117153

1 0

[PATCH 0/5] MR9073: Cmd engine rewrite (part XXXVII)
by eric pouech (＠epo) 30 Sep '25

30 Sep '25

This MR finishes the eradication of WCMD_ReadFile in favor of WCMD_fgets started in previous MR. A couple of enhancements to MORE command. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9073

2 5

[PATCH 0/6] MR9072: win32u: Implement D3DKMT object sharing through NT handles.
by Rémi Bernon 30 Sep '25

30 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9072

1 6