September 2025 - Wine-gitlab

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) 29 Sep '25

29 Sep '25

Very minor comments, looks good. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117123

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) 29 Sep '25

29 Sep '25

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/stb_dxt.h: > dest[1] = (unsigned char)mn; > dest += 2; > > + /* > + * Wine specific optimization to more closely match Windows behavior: If > + * max is equal to minimum, just set all bits to 0 (which means the value > + * is the value of max in this case). > + */ > + if (mx == mn) { > + memset(dest, 0, 6); > + return; > + } If I understand correctly, this affects the output. In which case I'd avoid calling it an optimization, both in the comment and the commit subject. It's a bit of a pet peeve of mine, please bear with me... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117120

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) 29 Sep '25

29 Sep '25

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/d3dx_helpers.c: > expected_src_data_size = (image->layer_pitch * image->layer_count) + header_size; > if (src_data_size < expected_src_data_size) > { > + const uint32_t dxt10_info_only_flags = D3DX_IMAGE_INFO_ONLY | D3DX_IMAGE_SUPPORT_DXT10; > + > WARN("File is too short %u, expected at least %u bytes.\n", src_data_size, expected_src_data_size); > - /* D3DX10/D3DX11 do not validate the size of the pixels, only the header. */ > - if (!(flags & D3DX_IMAGE_SUPPORT_DXT10)) > + /* > + * D3DX10/D3DX11 do not validate the size of the pixels, only the header. > + * However, if we're loading the image data, don't match native > + * behavior. > + */ I'd mention explicitly that we're doing it to be safe and until we find reason to do otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117121

1 0

Re: [PATCH v2 0/7] MR9034: d3dx10: Add support for creating textures from images using shared code.
by Matteo Bruni (＠Mystral) 29 Sep '25

29 Sep '25

Matteo Bruni (@Mystral) commented about dlls/d3dx10_43/texture.c: > + struct d3dx_pixels src_pixels, dst_pixels; > + uint32_t dst_row_pitch, dst_slice_pitch; > + > + hr = d3dx_image_get_pixels(&image, i, j, &src_pixels); > + if (FAILED(hr)) > + break; > + > + hr = d3dx_calculate_pixels_size(fmt_desc->format, dst_size.width, dst_size.height, &dst_row_pitch, > + &dst_slice_pitch); > + if (FAILED(hr)) > + break; > + > + set_d3dx_pixels(&dst_pixels, pixels_buffer, dst_row_pitch, dst_slice_pitch, NULL, dst_size.width, > + dst_size.height, dst_size.depth, &unaligned_rect); > + > + hr = d3dx_load_pixels_from_pixels(&dst_pixels, fmt_desc, &src_pixels, src_desc, D3DX10_FILTER_POINT, 0); Just a question in passing, unrelated to the patch: do we know if `D3DX10_FILTER_POINT` is actually the default filter? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9034#note_117122

1 0

[PATCH v2 0/1] MR9048: libs/fluidsynth: Fix data race in g_get_monotonic_time().
by Jinoh Kang (＠iamahuman) 29 Sep '25

29 Sep '25

Fixes: f768d6b31bebc35fbaf751d0cd57c8bd302a8d60 -- v2: libs/fluidsynth: Fix data race in g_get_monotonic_time(). https://gitlab.winehq.org/wine/wine/-/merge_requests/9048

3 3

Re: [PATCH v2 0/1] MR9055: gdiplus: Handle PixelFormatPAlpha separately in alpha_blend_hdc_pixels(). - approved
by Alexandre Julliard (＠julliard) 29 Sep '25

29 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9055

1 0

Re: [PATCH v2 0/5] MR9029: ole32: Various IPropertyStorage fixes. - approved
by Alexandre Julliard (＠julliard) 29 Sep '25

29 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9029

1 0

Re: [PATCH v3 0/2] MR9046: ws2_32/tests: Add a simple test for WSAProviderConfigChange(). - approved
by Alexandre Julliard (＠julliard) 29 Sep '25

29 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9046

1 0

Re: [PATCH v3 0/6] MR9066: xmllite/tests: Add a few more tests for WriteDocType(). - approved
by Alexandre Julliard (＠julliard) 29 Sep '25

29 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9066

1 0

Re: [PATCH v2 0/6] MR9020: Cmd engine rewrite (part XXXVI) - approved
by Alexandre Julliard (＠julliard) 29 Sep '25

29 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9020

1 0