September 2025 - Wine-gitlab

[PATCH 0/5] MR8930: Fix check for early IRP cancellation
by Matteo Bruni (＠Mystral) 09 Sep '25

09 Sep '25

This matches https://learn.microsoft.com/en-us/windows-hardware/drivers/kernel/using-a-d… and, as far as I can see, is the intended idea and what the comment implies. The idea, as I understand it, is to avoid a TOCTOU hazard by first setting the cancel routine and only afterwards checking the Cancel flag. If it's set while the previous cancel routine (returned by the second IoSetCancelRoutine call) is not NULL, that means it's been enabled before our first IoSetCancelRoutine call and we have to take care of it. Conversely, if there is no previous routine set, it must mean that ntoskrnl has removed the routine we just set and it's going to call it, or has already called it (and it's probably now trying to acquire the spinlock). In that case we leave handling the cancellation to the routine and do nothing special here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8930

5 8

[PATCH v3 0/7] MR8934: win32u: Hook VK_KHR_external_(semaphore|fence)_win32 related functions.
by Rémi Bernon 09 Sep '25

09 Sep '25

-- v3: win32u: Hook VK_KHR_external_fence_win32 related functions. win32u: Hook VK_KHR_external_semaphore_win32 related functions. win32u: Hook VK_KHR_win32_keyed_mutex related functions. win32u: Hook vkQueueSubmit and vkQueueSubmit2 functions. winevulkan: Move command buffer wrapper to vulkan_driver.h. winevulkan: Force copying the VkSubmitInfo(2) struct chains. winevulkan: Force copying wrapped handle arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8934

1 7

Re: [PATCH v2 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Nikolay Sivov (＠nsivov) 09 Sep '25

09 Sep '25

Hi, Have you found an application that's using this method? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115425

1 0

[PATCH 0/1] MR8937: windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) 09 Sep '25

09 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8937

3 5

[PATCH 0/5] MR1035: oleaut32/tests: Use IMallocSpy to test VariantClear(VT_RECORD).
by Kevin Puetz (＠puetzk) 09 Sep '25

09 Sep '25

Salvage tests and fix a leak found in another review: see https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9175 points 1 and 2. 3. is why !897 was reverted. This does not contain the (incorrect) changes to VariantCopyInd, but instead fixes the leak identified in VariantClear (VT_RECORD needs to free pvRecord), and the wrong allocator being used in VariantCopy (it should have been IMalloc, rather than `HeapAlloc`, as shown by the fact IMallocSpy observes these allocations). This also cleans up some dubious behavior by the test IRecordInfoImpl, which was modifying a VARIANT that it did not own or receive as an argument in the middle of VariantClear. This was likely undefined behavior, and in any case concealed the heap leak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1035

4 12

Re: [PATCH v2 0/1] MR8928: msxml3/tests: add test for IXMLDOMElement_removeAttributeNode.
by Reinhold Gschweicher (＠neroburner) 09 Sep '25

09 Sep '25

rebased onto 3cfbf9e3cd99dd01d3215c6952ae18ce88207d22 which fixes the pipelines :tada: Updated WineTestBot run (all green :white_check_mark: ): https://testbot.winehq.org/JobDetails.pl?Key=159816 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8928#note_115416

1 0

[PATCH v15 0/6] MR8829: windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance().
by Mohamad Al-Jaf (＠maljaf) 09 Sep '25

09 Sep '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v15: windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). windows.media.playback.backgroundmediaplayer: Add IBackgroundMediaPlayerStatics stub. include: Add IMediaPlayer definition. widl: Support additional deprecated declarations. windows.media.playback.backgroundmediaplayer: Add stub dll. include: Add windows.media.playback.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

3 10

[PATCH v4 0/5] MR8922: win32u/tests: Test D3DKMT object creation and sharing.
by Rémi Bernon 09 Sep '25

09 Sep '25

-- v4: win32u/tests: Test D3DKMT objects NT handle sharing. win32u/tests: Test D3DKMT allocation object creation. win32u/tests: Test D3DKMT keyed mutex object creation. win32u/tests: Test D3DKMT synchronization object creation. win32u: Stub NtGdiDdDDIOpenNtHandleFromName. https://gitlab.winehq.org/wine/wine/-/merge_requests/8922

1 6

[PATCH v2 0/7] MR8934: win32u: Hook VK_KHR_external_(semaphore|fence)_win32 related functions.
by Rémi Bernon 09 Sep '25

09 Sep '25

-- v2: win32u: Hook VK_KHR_external_fence_win32 related functions. win32u: Hook VK_KHR_external_semaphore_win32 related functions. win32u: Hook VK_KHR_win32_keyed_mutex related functions. win32u: Hook vkQueueSubmit and vkQueueSubmit2 functions. winevulkan: Move command buffer wrapper to vulkan_driver.h. winevulkan: Force copying the VkSubmitInfo(2) struct chains. winevulkan: Force copying wrapped handle arrays. https://gitlab.winehq.org/wine/wine/-/merge_requests/8934

1 7

[PATCH v2 0/1] MR8918: wineboot: Fix a memory leak in create_computer_name_keys.
by Alex Henrie (＠alexhenrie) 09 Sep '25

09 Sep '25

If the canonical hostname was "localhost", the address info was not freed. Don't bother checking whether ai_canonname is NULL because if there is no canonical name, getaddrinfo must set ai_canonname to the input name. Fixes: ca5a6d07dc92ba631b178ec175e6b3fd5295e3d6 -- v2: wineboot: Fix a memory leak in create_computer_name_keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/8918

2 2