September 2025 - Wine-gitlab

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) 07 Sep '25

07 Sep '25

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > > static HRESULT clsid_from_string_reg(LPCOLESTR progid, CLSID *clsid) > { > - WCHAR buf2[CHARS_IN_GUID]; > + WCHAR buf2[CHARS_IN_GUID],buf3[CHARS_IN_GUID]; > LONG buf2len = sizeof(buf2); > + LONG buf3len = sizeof(buf3); Those should be renamed to something more intuitive. Also buf3 here does not contain a stringified GUID but ProgID, so using CHARS_IN_GUID length is incorrect. What happens if ProgID referenced with CurVer itself contains another CurVer, is it followed? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115151

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) 07 Sep '25

07 Sep '25

Nikolay Sivov (@nsivov) commented about dlls/combase/combase.c: > if (open_classes_key(HKEY_CLASSES_ROOT, buf, MAXIMUM_ALLOWED, &xhkey)) > { > - free(buf); > - WARN("couldn't open key for ProgID %s\n", debugstr_w(progid)); > - return CO_E_CLASSSTRING; > + lstrcpyW(buf, progid); > + lstrcatW(buf, L"\\CurVer"); > + if (RegQueryValueW(HKEY_CLASSES_ROOT, buf, buf3, &buf3len)) > + { > + free(buf); > + WARN("couldn't query CurVer value for ProgID %s\n", debugstr_w(progid)); > + return CO_E_CLASSSTRING; > + } > + > + lstrcpyW(buf, buf3); > + lstrcatW(buf, L"\\CLSID"); Size of 'buf' has no relation to size of 'buf3', so you can't assume you can copy things and not overrun it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115152

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) 07 Sep '25

07 Sep '25

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ This comment does not belong to this new test. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115150

1 0

Re: [PATCH v4 0/2] MR7539: combase : clsid_from_string_reg() add read of CurVer key value.
by Nikolay Sivov (＠nsivov) 07 Sep '25

07 Sep '25

Nikolay Sivov (@nsivov) commented about dlls/ole32/tests/compobj.c: > ok(IsEqualCLSID(&clsid, &CLSID_StdFont), "clsid wasn't equal to CLSID_StdFont\n"); > > /* test some failure cases */ > + StringFromGUID2(&CLSID_non_existent, clsidstr, ARRAYSIZE(clsidstr)); > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest\\CurVer", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)L"MyApp.DocumentTest.1", (wcslen(L"MyApp.DocumentTest.1") + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + if (RegCreateKeyExW(HKEY_CLASSES_ROOT, L"MyApp.DocumentTest.1\\CLSID", 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hKey, NULL) == ERROR_SUCCESS) { > + RegSetValueExW(hKey, NULL, 0, REG_SZ, (const BYTE *)clsidstr, (wcslen(clsidstr) + 1) * sizeof(WCHAR)); > + RegCloseKey(hKey); > + } > + hr = CLSIDFromProgID(L"MyApp.DocumentTest", &clsid); > + ok(hr == S_OK, "CLSIDFromProgID failed with error 0x%08lx\n", hr); > + ok(IsEqualCLSID(&clsid, &CLSID_non_existent), "got wrong clsid %s\n", wine_dbgstr_guid(&clsid)); This needs a test for when both CurVer and CLSID are present. The test should clean up entries it creates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7539#note_115149

1 0

[PATCH v3 0/1] MR8650: urlmon/tests: fixed argument size passed to GetTempPathW
by Marcus Meissner (＠msmeissn) 07 Sep '25

07 Sep '25

Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> -- v3: urlmon/tests: fixed argument size passed to GetTempPathW https://gitlab.winehq.org/wine/wine/-/merge_requests/8650

3 3

[PATCH v4 0/3] MR7375: dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND
by Edward OC (＠funfunctor) 07 Sep '25

07 Sep '25

Trivial, small set of cleanups patches to start with, non-controversial and NOP functionally speaking. These are to help get the review process going in making ways towards the bar being lowered for contributing to the oleaut32 implementation. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v4: dlls/oleaut32: Invert if-stmt in ITypeLib2_fnRelease() dlls/oleaut32: Invert if stmt for clarity dlls/oleaut32: Consistently use TLB_REF_NOT_FOUND https://gitlab.winehq.org/wine/wine/-/merge_requests/7375

3 5

[PATCH v3 0/10] MR7449: oleaut32: Fix methods relating typeinfo substructures around names, guids and friends
by Edward OC (＠funfunctor) 07 Sep '25

07 Sep '25

- Clean up method implementations to be consistent and pass tests. - Factor out common code. - Validate arguments. - Correctly match szNameBuf user passed strings as case-insensitive as per documentation. - Match method parameter identifiers to be as per documentation. - Rewrite where required to use common helpers. Signed-off-by: Edward O'Callaghan <edward(a)antitrust.cc> -- v3: oleaut32: Factor out TLB_get_typeinfo_by_guid() https://gitlab.winehq.org/wine/wine/-/merge_requests/7449

3 12

[PATCH v11 0/24] MR7203: dlls/oleaut32: Cleanups
by Edward OC (＠funfunctor) 07 Sep '25

07 Sep '25

The intention is to have ICreateTypeLib2_fnDeleteTypeInfo() fully implemented such that Cashbooks can run on Linux. I believe this should fix a number of other Windows apps that lean heavily on oleaut32.dll as well. -- v11: dlls/oleaut32: ptr_size should be a ULONG This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7203

2 2

[PATCH v7 0/2] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) 07 Sep '25

07 Sep '25

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v7: win32u: Fix ExtCreateRegion when parameters are wrong. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

4 6

[PATCH 0/1] MR8917: gdi32: From Windows 2000 FixBrushOrgEx() is a NOP.
by Huw Davies (＠huw) 07 Sep '25

07 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8917

2 2