September 2025 - Wine-gitlab

Re: [PATCH v3 0/2] MR8894: crypt32: Accept PKCS12_ALWAYS_CNG_KSP flag and fall back to standard import.
by Hans Leidekker (＠hans) 04 Sep '25

04 Sep '25

Thanks. Can you please squash the commits? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8894#note_114851

1 0

Re: [PATCH v3 0/2] MR8894: crypt32: Accept PKCS12_ALWAYS_CNG_KSP flag and fall back to standard import.
by Christian Tinauer (＠christiantinauer) 04 Sep '25

04 Sep '25

On Wed Sep 3 15:12:53 2025 +0000, Christian Tinauer wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/8894/diffs?diff_id=205547&start_sha=a38d27fbc01002ca53b5c64949790f1a0a326477#25828ec85937a729c394182abf50faf3f08c268f_6193_6193) Reverted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8894#note_114849

1 0

Re: [PATCH v3 0/2] MR8894: crypt32: Accept PKCS12_ALWAYS_CNG_KSP flag and fall back to standard import.
by Christian Tinauer (＠christiantinauer) 04 Sep '25

04 Sep '25

On Wed Sep 3 15:12:52 2025 +0000, Christian Tinauer wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/8894/diffs?diff_id=205547&start_sha=a38d27fbc01002ca53b5c64949790f1a0a326477#b1df58feb3444ad26c675cfa6fe51c306a9dfedc_1398_1398) Reverted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8894#note_114848

1 0

Re: [PATCH v3 0/2] MR8894: crypt32: Accept PKCS12_ALWAYS_CNG_KSP flag and fall back to standard import.
by Christian Tinauer (＠christiantinauer) 04 Sep '25

04 Sep '25

On Wed Sep 3 15:12:52 2025 +0000, Christian Tinauer wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/8894/diffs?diff_id=205547&start_sha=a38d27fbc01002ca53b5c64949790f1a0a326477#85309c8ce7c9487572d2f5c6bde361a8bb004951_3315_3315) Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8894#note_114847

1 0

Re: [PATCH v3 0/2] MR8894: crypt32: Accept PKCS12_ALWAYS_CNG_KSP flag and fall back to standard import.
by Christian Tinauer (＠christiantinauer) 04 Sep '25

04 Sep '25

On Thu Sep 4 08:50:16 2025 +0000, Hans Leidekker wrote: > That should be a FIXME. Done. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8894#note_114846

1 0

Re: [PATCH v10 0/2] MR7064: ntdll: Check for invalid GS base in the 64-bit segv_handler.
by Brendan Shanks (＠bshanks) 04 Sep '25

04 Sep '25

I created !8899 to fix a crash on macOS in `check_invalid_gsbase()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7064#note_114829

1 0

[PATCH 0/1] MR8899: ntdll: Fix crash in check_invalid_gsbase() on macOS.
by Brendan Shanks (＠bshanks) 04 Sep '25

04 Sep '25

I saw a crash when Unix code would try to execute a NULL function pointer: while handling the SEGV `check_invalid_gsbase()` would try to deference `%rip` which is of course NULL. This was only seen on macOS because the initial `if (cur_gsbase == (ULONG_PTR)teb)` check will never be equal, since there's no way [1] to find what GSBASE was when the signal was raised. macOS uses `%gs` for it's own thread-local storage, and we have to reset GSBASE to the Mac TSD in `init_handler()` before anything else runs. This means that every page fault will result in reading from `%rip`, and `virtual_uninterrupted_read_memory()` must be used in case `%rip` isn't a valid address. I also added some comments to explain the lack of a Mac codepath for getting/setting GSBASE. With this commit and testing with the sample code in #57444, I found that on Intel Macs `check_invalid_gsbase()` is necessary and works correctly. Rosetta does not implement resetting GSBASE on a `pop %gs` though, so `check_invalid_gsbase()` isn't necessary there. I do worry slightly about the overhead of calling `virtual_uninterrupted_read_memory()` for every page fault; if that ever needs to be reduced, skipping `check_invalid_gsbase()` on Rosetta would be a first step. [1]: This is mostly but not completely true--when a user LDT is installed (i.e. wow64), macOS uses a larger "full" sigcontext that includes the value of GSBASE. But Rosetta doesn't implement this, so it's only useful on Intel Macs. And if we wanted to use it on Intel Macs, we would need to always install a user LDT. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8899

2 1

Re: [PATCH v2 0/5] MR8882: Cmd engine rewrite (part XXXIV) - approved
by Alexandre Julliard (＠julliard) 03 Sep '25

03 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8882

1 0

Re: [PATCH v2 0/6] MR8892: Comment or define undefined WinRT member interfaces (1/2) - approved
by Alexandre Julliard (＠julliard) 03 Sep '25

03 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8892

1 0

Re: [PATCH v2 0/1] MR8893: opcservices: Remove separate part name allocation. - approved
by Alexandre Julliard (＠julliard) 03 Sep '25

03 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8893

1 0