January 2026 - Wine-gitlab - list.winehq.org

[PATCH 0/5] MR9992: Winemac IME rework part 1
by Marc-Aurel Zent (＠mzent) 28 Jan '26

28 Jan '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9992

3 6

Re: [PATCH v3 0/2] MR9975: where: Add quiet mode.
by eric pouech (＠epo) 28 Jan '26

28 Jan '26

eric pouech (@epo) commented about programs/where/main.c: > int __cdecl wmain(int argc, WCHAR *argv[]) > { > WCHAR *pattern, *colon, *search_paths, *search_path, *next_search_path; > + DWORD flags = 0; > int i; > > for (i = 0; i < argc; i++) > { > - if (argv[i][0] == '/') > + if (argv[i][0] == '/' && wcslen(argv[i]) == 2) > + { > + switch(toupper(argv[i][1])) > + { > + case 'Q': flags |= OPT_QUIET; break; > + default: > + FIXME("Unsupported option %ls -- %c\n", argv[i], argv[i][1]); the %c arg is useless -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9975#note_128273

1 0

Re: [PATCH v3 0/2] MR9975: where: Add quiet mode.
by eric pouech (＠epo) 28 Jan '26

28 Jan '26

eric pouech (@epo) commented about programs/where/main.c: > } > else if (argv[i][0] == '/') > { > - FIXME("Unsupported option %ls len %lld\n", argv[i], (long long)wcslen(argv[i])); > + FIXME("Unsupported option %ls\n", argv[i]); that should be rebased into previous patch. note also that you'd rather use wine_dbgstr_w(argv\[i\]) as argument, to prevent too long strings from overflowing FIXME internal buffer -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9975#note_128268

1 0

[PATCH v17 0/6] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 28 Jan '26

28 Jan '26

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v17: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. kernel32: Fix CreateToolhelp32Snapshot on old WoW64. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Handle ERROR_BAD_LENGTH from CreateToolhelp32Snapshot. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

3 8

[PATCH v2 0/2] MR9975: where: Add quiet mode.
by Thomas Csovcsity (＠thc13) 28 Jan '26

28 Jan '26

Fixes Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59234 -- v2: where: Fix index for option parsing https://gitlab.winehq.org/wine/wine/-/merge_requests/9975

3 4

[PATCH v3 0/2] MR9946: start: Remove quotes from the path specified by '/d'.
by Yeshun Ye (＠yeyeshun) 28 Jan '26

28 Jan '26

I'm not sure how to write a test case for this bug, as it involves creating a child process and I don't know how to verify if the child process was created correctly. Please test manually: enter `start /d "c:\windows" regedit.exe` in a batch file. It won't work correctly because `start` wraps the directory specified by `/D` with `L"\"\\\""` and `L"\\\"\""`. -- v3: start: Remove quotes from the path specified by '/d'. https://gitlab.winehq.org/wine/wine/-/merge_requests/9946

3 5

[PATCH 0/5] MR9991: Draft: opengl32: Avoid using context HDC after context creation.
by Rémi Bernon (＠rbernon) 28 Jan '26

28 Jan '26

There's no guarantee that the HDCs are still valid. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9991

2 5

[PATCH 0/1] MR9907: include: Annotate p_wglAllocateMemoryNV with __WINE_ALLOC_SIZE.
by Alex Henrie (＠alexhenrie) 28 Jan '26

28 Jan '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9907

3 4

[PATCH v5 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) 28 Jan '26

28 Jan '26

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. P.S. I am not intending to post further changes until this MR is being merged. These changes are pretty much simple but fundamental for future changes. -- v5: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring wineandroid: Fix start_device_callback assignment type https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 12

[PATCH v4 0/9] MR9977: wineandroid: Fix build issues and early runtime regressions on modern Android toolchains
by Twaik Yont (＠twaik) 28 Jan '26

28 Jan '26

This merge request contains a set of incremental Android-specific fixes aimed at restoring buildability and removing several early runtime regressions when building Wine with modern Android NDK toolchains. The changes are intentionally minimal and focused on correctness and cleanup rather than adding new functionality. Build-related fixes: - Fix missing ffs() declaration by including <strings.h>. - Fix mismatched ANDROID_WindowPosChanged prototype. - Remove leftover drawable_mutex declarations after OpenGL refactoring. - Avoid unsupported pthread mutex attributes on Android. - Export Java-related globals to ensure they remain visible for dlsym with newer NDKs. - Force --rosegment for wine-preloader when supported to avoid excessive ELF size. Runtime-related fixes: - Fix WineAndroid device access by switching to a consistent \Device\WineAndroid path and aligning driver/device object creation. - Fix start_device_callback assignment type to match expected storage. Status: These changes improve build reliability and eliminate some immediate runtime failures, but they do not make wineandroid fully functional yet. This MR is part of an ongoing bring-up effort for modern Android versions and focuses on getting the simplest pieces building and initializing correctly before further functional work. P.S. I am not intending to post further changes until this MR is being merged. These changes are pretty much simple but fundamental for future changes. -- v4: wineandroid: force --rosegment for wine-preloader wineandroid: Fix WineAndroid device access path ntdll: Export Java globals for dlsym lookup winepulse: Do not use pthread mutex attributes on Android win32u: Fix wineandroid build after OpenGL drawable refactoring https://gitlab.winehq.org/wine/wine/-/merge_requests/9977

3 12