February 2026 - Wine-gitlab

[PATCH v9 0/8] MR8812: winegstreamer: Support 2D sample buffer.
by Conor McCarthy (＠cmccarthy) 17 Feb '26

17 Feb '26

Performance issues can occur when a video output sample has a 2D buffer, because winegstreamer currently outputs only to a linear buffer, which must then be copied into the 2D buffer. Worse, a linear lock of the 2D buffer requires the current contents to be copied to a linear buffer, even when we intend to overwrite it, because MF linear buffers do not support write-only locking. -- v9: winegstreamer: Support 2D sample buffer. mf/tests: Test color convert 2D buffers. mf/tests: Test WMV decoder 2D buffers. mf/tests: Test H.264 decoder 2D buffers. mf/tests: Test sample copier 2D buffers. mfplat/tests: Test NV12 negative stride in MFCreateMediaBufferFromMediaType(). mf/tests: Change todo to flaky for the H.264 decoder ouput type change test. https://gitlab.winehq.org/wine/wine/-/merge_requests/8812

3 10

[PATCH v2 0/1] MR10026: ntoskrnl: Use fastcall for KeInitializeGuardedMutex
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Feb '26

17 Feb '26

Fixes it to use the correct calling convention. -- v2: ntoskrnl: Use fastcall for KeInitializeGuardedMutex. https://gitlab.winehq.org/wine/wine/-/merge_requests/10026

3 2

[PATCH 0/1] MR10097: winegstreamer: Use a single call to free the streams array (ASan).
by Bernhard Übelacker (＠bernhardu) 17 Feb '26

17 Feb '26

The last run with ASan shows the report below. If I understand it right in `init_stream` the streams array gets allocated in a [single call to calloc](https://gitlab.winehq.org/wine/wine/-/blob/964cd76c020dfb8c72dea0b0…. But in the [current version](https://gitlab.winehq.org/wine/wine/-/blob/964cd76c020dfb8c72dea0b… of `free_streams` individual elements of the array get freed, which in the first iterations seems to free the whole array. Therefore ASan gets triggered when accessing the second element of the array. Followup of 964cd76c. CC: @cmccarthy <details> <summary>ASan details [gitlab run](https://gitlab.winehq.org/bernhardu/wine/-/jobs/228543#L4644)</summary> ``` ================================================================= ==qasf_test.exe==1008==ERROR: AddressSanitizer: heap-use-after-free on address 0x02202f34 at pc 0x782389d4 bp 0x0022f8d4 sp 0x0022f8d0 READ of size 4 at 0x02202f34 thread T0 #0 0x782389d3 in free_streams /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1482:21 #1 0x78233c59 in reader_Close /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1972:5 #2 0x7844399c in IWMSyncReader2_Close /builds/bernhardu/wine/build64/include/wmsdkidl.h:7313:12 #3 0x78442b85 in WMReader_Release /builds/bernhardu/wine/build64/../dlls/wmvcore/async_reader.c:586:9 #4 0x784c140c in IWMReader_Release /builds/bernhardu/wine/build64/include/wmsdkidl.h:3767:12 #5 0x784c57a0 in asf_reader_destroy /builds/bernhardu/wine/build64/../dlls/qasf/asfreader.c:449:5 #6 0x784d1a32 in filter_inner_Release /builds/bernhardu/wine/build64/../libs/strmbase/filter.c:259:9 #7 0x784ce484 in filter_Release /builds/bernhardu/wine/build64/../libs/strmbase/filter.c:291:12 #8 0x784c6f1c in IBaseFilter_Release /builds/bernhardu/wine/build64/include/strmif.h:2053:12 #9 0x784c68d3 in file_source_Release /builds/bernhardu/wine/build64/../dlls/qasf/asfreader.c:659:12 #10 0x004077cc in IFileSourceFilter_Release /builds/bernhardu/wine/build64/include/strmif.h:5555:12 #11 0x00402df8 in test_filesourcefilter /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:503:11 #12 0x0040102d in func_asfreader /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:1119:5 #13 0x0041d791 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #14 0x0041d24a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #15 0x0042c2b5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #16 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #17 0x7be4678a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4678a) #18 0x7be470fa in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 0x02202f34 is located 372 bytes inside of 384-byte region [0x02202dc0,0x02202f40) freed by thread T0 here: #0 0x785f5e10 in HeapFree /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:254:3 #1 0x79ddefd5 in msvcrt_heap_free /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c #2 0x79ddf5ec in free /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:414:3 #3 0x7823890b in free_streams /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1489:9 #4 0x78233c59 in reader_Close /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1972:5 #5 0x7844399c in IWMSyncReader2_Close /builds/bernhardu/wine/build64/include/wmsdkidl.h:7313:12 #6 0x78442b85 in WMReader_Release /builds/bernhardu/wine/build64/../dlls/wmvcore/async_reader.c:586:9 #7 0x784c140c in IWMReader_Release /builds/bernhardu/wine/build64/include/wmsdkidl.h:3767:12 #8 0x784c57a0 in asf_reader_destroy /builds/bernhardu/wine/build64/../dlls/qasf/asfreader.c:449:5 #9 0x784d1a32 in filter_inner_Release /builds/bernhardu/wine/build64/../libs/strmbase/filter.c:259:9 #10 0x784ce484 in filter_Release /builds/bernhardu/wine/build64/../libs/strmbase/filter.c:291:12 #11 0x784c6f1c in IBaseFilter_Release /builds/bernhardu/wine/build64/include/strmif.h:2053:12 #12 0x784c68d3 in file_source_Release /builds/bernhardu/wine/build64/../dlls/qasf/asfreader.c:659:12 #13 0x004077cc in IFileSourceFilter_Release /builds/bernhardu/wine/build64/include/strmif.h:5555:12 #14 0x00402df8 in test_filesourcefilter /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:503:11 #15 0x0040102d in func_asfreader /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:1119:5 #16 0x0041d791 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #17 0x0041d24a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #18 0x0042c2b5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #19 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #20 0x7be4678a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4678a) #21 0x7be470fa in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 previously allocated by thread T0 here: #0 0x785f5c96 in HeapAlloc /home/runner/work/llvm-mingw/llvm-mingw/llvm-project/compiler-rt/lib/asan/asan_malloc_win.cpp:230:3 #1 0x79ddeedc in msvcrt_heap_alloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:71:12 #2 0x79ddf5d2 in calloc /builds/bernhardu/wine/build64/../dlls/msvcrt/heap.c:396:10 #3 0x78236e13 in init_stream /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1525:29 #4 0x78233a38 in reader_Open /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:2351:21 #5 0x78443bef in IWMSyncReader2_Open /builds/bernhardu/wine/build64/include/wmsdkidl.h:7310:12 #6 0x78442d68 in WMReader_Open /builds/bernhardu/wine/build64/../dlls/wmvcore/async_reader.c:606:24 #7 0x784c6fc4 in IWMReader_Open /builds/bernhardu/wine/build64/include/wmsdkidl.h:3771:12 #8 0x784c6a2b in file_source_Load /builds/bernhardu/wine/build64/../dlls/qasf/asfreader.c:682:24 #9 0x004073d2 in IFileSourceFilter_Load /builds/bernhardu/wine/build64/include/strmif.h:5559:12 #10 0x00402aa3 in test_filesourcefilter /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:466:10 #11 0x0040102d in func_asfreader /builds/bernhardu/wine/build64/../dlls/qasf/tests/asfreader.c:1119:5 #12 0x0041d791 in run_test /builds/bernhardu/wine/build64/../include/wine/test.h:780:5 #13 0x0041d24a in main /builds/bernhardu/wine/build64/../include/wine/test.h:900:12 #14 0x0042c2b5 in mainCRTStartup /builds/bernhardu/wine/build64/../dlls/msvcrt/crt_main.c:62:11 #15 0x7bcd367f in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x7b82367f) #16 0x7be4678a in call_thread_func_wrapper (C:\windows\system32\ntdll.dll+0x7bc4678a) #17 0x7be470fa in call_thread_func /builds/bernhardu/wine/build64/../dlls/ntdll/signal_i386.c:503:9 SUMMARY: AddressSanitizer: heap-use-after-free /builds/bernhardu/wine/build64/../dlls/winegstreamer/wm_reader.c:1482:21 in free_streams ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10097

4 3

Re: [PATCH v2 0/2] MR10122: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion. - closed
by Craig Schulstad (＠NoDakker) 17 Feb '26

17 Feb '26

This merge request was closed by Craig Schulstad. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10122

1 0

Re: [PATCH v2 0/2] MR10122: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) 17 Feb '26

17 Feb '26

Memo to DarkShadow44, The good news is that testing errors went from hundreds of errors from the first merge request down to three errors in this request which happen to be in the user32 tests. I believe I know what the symptom is, which appears to be attempting to find and load resources that exist in the base module even when a language specific "mui" module is in play. So it appears that I need to refine the refactoring in the "FindResourceExW" function and the "LoadResource" function to account for that scenario. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10122#note_129833

1 0

[PATCH 0/2] MR10122: kernelbase/loader.c: Include rudimentary support for multilanguage resource inclusion.
by Craig Schulstad (＠NoDakker) 17 Feb '26

17 Feb '26

For programs that rely on language specific data for resources such as menus and text, attempt to search for and associated "mui" file. For example, if program "myapp.exe" is executed and resources are not found, and the user's language ID is "ENU", search for file "myapp.ENU", and if found, utilize that file for the source of resource data. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10122

2 3

[PATCH v2 0/2] MR10120: win32u: Implement NtUserEnableMouseInPointer semi-stub.
by Rémi Bernon (＠rbernon) 17 Feb '26

17 Feb '26

-- v2: win32u: Implement NtUserEnableMouseInPointer semi-stub. user32/tests: Test EnableMouseInPointer message translation. https://gitlab.winehq.org/wine/wine/-/merge_requests/10120

2 2

[PATCH 0/2] MR10120: win32u: Implement NtUserEnableMouseInPointer semi-stub.
by Rémi Bernon (＠rbernon) 17 Feb '26

17 Feb '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10120

2 2

[PATCH 0/3] MR10119: winegcc: Use compiler-rt instead of -lgcc on mingw targets.
by Jacek Caban (＠jacek) 17 Feb '26

17 Feb '26

This treats mingw targets the same way as msvc. We already have the necessary infrastructure; we are just missing a few functions to be able to use it for mingw as well. In my case, I was looking at adding emutls support for GCC. Since it is typically provided by libgcc or compiler-rt, this should be straightforward to implement on top of this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10119

2 3

[PATCH v2 0/1] MR10056: dsound: Use a better FIR filter generated with the Parks-McClellan algorithm.
by Anton Baskanov (＠baskanov) 17 Feb '26

17 Feb '26

The new filter provides a 98.5 dB stopband rejection and doesn't attenuate frequencies below 20 kHz (assuming 44.1 kHz sampling rate). ![magnitude](/uploads/e0947573942210102f85bc11082c1380/magnitude.png){width=900 height=403} ![sweep.wine.upstream](/uploads/411cb840ed5f7117a669e1a729101d0f/sweep.wine.upstream.png){width=675 height=356} ![sweep.wine.pm-fir](/uploads/b2f6d669c1bb62c70d6a4a725cb06aa8/sweep.wine.pm-fir.png){width=675 height=356} P.S.: Thanks to Matteo Bruni for providing the test tools. -- v2: dsound: Use a better FIR filter generated with the Parks-McClellan algorithm. https://gitlab.winehq.org/wine/wine/-/merge_requests/10056

4 8