February 2026 - Wine-gitlab

[PATCH v2 0/1] MR10022: gdiplus: Allow GdipBitmapLockBits without read/write flags.
by Bernhard Übelacker (＠bernhardu) 07 Feb '26

07 Feb '26

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59362 [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161700) -- v2: gdiplus: Allow GdipBitmapLockBits without read/write flags. https://gitlab.winehq.org/wine/wine/-/merge_requests/10022

2 1

[PATCH v4 0/3] MR9915: mmedvapi: Device name changes.
by Bernhard Kölbl (＠besentv) 07 Feb '26

07 Feb '26

The test in the last commit would still need an implementation, which turned out to be more complicated than the possible benefits. -- v4: mmdevapi: Adjust device names. https://gitlab.winehq.org/wine/wine/-/merge_requests/9915

4 6

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + if (system_lang_id != LANG_ENGLISH) > + { > + winetest_skip("Skipping font family tests on non English setups\n"); > + return; > + } > + > + hdc = GetDC(NULL); > + > + memset(&lf, 0, sizeof(lf)); > + > + for (i = 0; i < ARRAY_SIZE(td); ++i) > + { > + lf.lfPitchAndFamily = td[i].family; > + lf.lfHeight = td[i].font_height; > + lf.lfCharSet = td[i].charset; > + hfont = NULL; Unnecessary initialisation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129010

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + { > + lf.lfPitchAndFamily = td[i].family; > + lf.lfHeight = td[i].font_height; > + lf.lfCharSet = td[i].charset; > + hfont = NULL; > + > + hfont = CreateFontIndirectW(&lf); > + ok(!!hfont, "Failed to create font.\n"); > + > + old = SelectObject(hdc, hfont); > + > + memset(&metric, 0, sizeof(metric)); > + GetTextMetricsW(hdc, &metric); > + > + todo_wine_if(td[i].todo) ok((metric.tmPitchAndFamily & 0x70) == (td[i].family & 0x70), > + "got unexpected font family %2x, needed %2x\n", metric.tmPitchAndFamily & 0x70, td[i].family & 0x70); Does the returned tmPitchAndFamily have the high bit set at all? It would be nicer to just mask that with `0xf0`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129011

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/gdi32/tests/font.c: > + hfont = CreateFontIndirectW(&lf); > + ok(!!hfont, "Failed to create font.\n"); > + > + old = SelectObject(hdc, hfont); > + > + memset(&metric, 0, sizeof(metric)); > + GetTextMetricsW(hdc, &metric); > + > + todo_wine_if(td[i].todo) ok((metric.tmPitchAndFamily & 0x70) == (td[i].family & 0x70), > + "got unexpected font family %2x, needed %2x\n", metric.tmPitchAndFamily & 0x70, td[i].family & 0x70); > + > + memset(font_name, 0, sizeof(font_name)); > + GetTextFaceW(hdc, ARRAY_SIZE(font_name), font_name); > + > + todo_wine ok(!wcscmp(font_name, td[i].expected_font), > + "Got unexpected font %s for height %lu, expected %s\n", debugstr_w(font_name), td[i].font_height, debugstr_w(td[i].expected_font)); What's going on here? Why is this always failing with Wine? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129012

1 0

Re: [PATCH v3 0/2] MR9514: gdi32: Fix font creation with invaild bits.
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

Huw Davies (@huw) commented about dlls/win32u/font.c: > { > const char * const *defaults; > > - if ((pitch_and_family & FIXED_PITCH) || (pitch_and_family & 0xf0) == FF_MODERN) > + if ((pitch_and_family & FIXED_PITCH) || (pitch_and_family & FF_MODERN) == FF_MODERN) This doesn't look right. The `FF_` constants are not bit-fields. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9514#note_129013

1 0

Re: [PATCH v3 0/28] MR9928: Draft: dsound: Speed up resampling.
by Anton Baskanov (＠baskanov) 07 Feb '26

07 Feb '26

v3: - Rebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9928#note_129005

1 0

[PATCH v2 0/28] MR9928: Draft: dsound: Speed up resampling.
by Anton Baskanov (＠baskanov) 07 Feb '26

07 Feb '26

This implements a number of optimizations, in particular: - Swapping around the resampling loops in case of downsampling, allowing the FIR step to stay fixed regardless of the resampling ratio. - Rearranging the FIR array elements to make the access sequential. - Adding SSE versions of the resampling functions. Together, these amount to more than a 5x reduction of `cp_fields_resample` execution time. The quality of the resampling should be the same, or even improve slightly, due to a more precise `rem` calculation and removal of the FIR step rounding, although I haven't yet conducted any measurements. -- v2: dsound: Add a 32-bit SSE version of downsample. dsound: Add a 32-bit SSE version of upsample. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/9928

2 4

Re: [PATCH v2 0/1] MR9776: riched20: Fix crash when copying text. - approved
by Huw Davies (＠huw) 07 Feb '26

07 Feb '26

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9776

1 0

[PATCH 0/1] MR9713: xaudio2_7/tests: Dynamically load function XAudio2CreateWithVersionInfo.
by Bernhard Übelacker 07 Feb '26

07 Feb '26

Make the test run again with win10-1709 and before. Followup to e04f84dc4c. [Test pattern page](https://test.winehq.org/data/patterns.html#xaudio2_8:xaudio2) [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=161206) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9713

3 3