- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/5] MR9588: dsound: Introduce a cubic spline interpolation resampler.
by Anton Baskanov (＠baskanov) 20 Jan '26

20 Jan '26

On Mon Jan 12 13:30:33 2026 +0000, Matteo Bruni wrote: > I'm curious about your changes. All things being equal it would be > preferable to improve the existing resampler rather than introducing a > different one. The problem is that I'm not sure we can make it fast > enough without effectively rewriting it from scratch. > When I wrote this MR I felt like the current resampler might be > hopelessly too complex for realtime resampling of 100+ sound buffers > (which is what Fallout 3 and New Vegas can end up with on occasion). I > benchmarked Wine's dsound resampling and compared the performance to > Windows. I also tested plugging resamplers from other common libraries > (speexdsp and libsamplerate, before openal-soft) into Wine's dsound, and > that kinda reinforced my view. The fastest fsinc implementation I tried > (which is from openal-soft) is still about half as fast as Win 10 / > 11's, IIRC. > I can go look at the actual numbers but I'm pretty sure a 5x improvement > when using explicit SSE does not quite cut it. > I'll mention that, since I wrote this MR, I have prepared a few more > patches to improve on other pieces of the dsound mixer, which become the > bottleneck once the resampler itself gets fast enough. You can find it > at https://gitlab.winehq.org/Mystral/wine/-/commits/dsound-perf (I > cleaned the patches up locally since I pushed all that to gitlab, but > the gist should be there already). For reference, these are the changes: > - Prepare all the input samples and store all the generated output > samples in one go instead of doing it sample-by-sample > - Don't use indirect function calls for sample conversion > - Don't use indirect function calls for channel interleaving > - Interleave channels after mixing > - Mix and apply volume at the same time > - SSE mixing > These patches give some incremental performance improvements. It's > possible that the combination of these and an improved version of the > current resampler gets us where we want, although I'm not super hopeful... Here are my changes: !9928 > When I wrote this MR I felt like the current resampler might be hopelessly too complex for realtime resampling of 100+ sound buffers (which is what Fallout 3 and New Vegas can end up with on occasion). That's interesting. My changes seem to be enough to fix the crackling in Star Wolves 3, which also creates 100+ buffers. Tested on a laptop with AMD Ryzen 5 3500U with the frequency reduced to 1400 GHz. I also tried to add AVX+FMA3 versions of the resampling functions, but I'm getting diminishing returns. The bottleneck might be the indirect calls to `get` and `put` or the index calculation code in the outer loop. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9588#note_127381

1 0

[PATCH v2 0/3] MR9926: ntdll: Make RtlEncodePointer / RtlDecodePointer compatible.
by Paul Gofman (＠gofman) 20 Jan '26

20 Jan '26

-- v2: ntdll: Reimplement RtlEncodePointer / RtlDecodePointer using process cookie. https://gitlab.winehq.org/wine/wine/-/merge_requests/9926

2 5

[PATCH 0/3] MR9926: ntdll: Make RtlEncodePointer / RtlDecodePointer compatible.
by Paul Gofman (＠gofman) 20 Jan '26

20 Jan '26

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9926

3 5

[PATCH 0/2] MR9927: mountmgr: Implement FileFsFullSizeInformationEx.
by Elizabeth Figura (＠zfigura) 20 Jan '26

20 Jan '26

No application I am aware of needs this. We currently have an awkward divide between volume/disk/drive ioctls (and NtQueryVolumeInformationFile classes, which are technically not ioctls). Some are implemented in mountmgr, some in ntdll, some in both, and one (FSCTL_DISMOUNT_VOLUME) in the server. Which version is called depends on how the device is opened. NT paths of the form \??\A: or \DosDevices\A: go to ntdll, but other paths, such as \Device\HarddiskVolume0 or \??\Volume{...}, go to mountmgr. It is my intent to move everything to mountmgr (with the exception of NtQueryVolumeInformationFile, which can be called on any file in the volume, not just the volume device or volume root. Note that in many cases we do ultimately forward these calls to mountmgr via get_mountmgr_fs_info() anyway.) This means the following: - FileFsFullSizeInformationEx implemented in mountmgr - FileFsDeviceInformation implemented in ntoskrnl (this one is actually handled by the I/O manager) - FSCTL_DISMOUNT_VOLUME moved from server to mountmgr. mountmgr will have to call the server to close open files as part of this. - Everything inside of cdrom.c would be moved to mountmgr. This is a lot of thrashing, but will ultimately result in more natural code; in particular the ugly hacks for IOCTL_STORAGE_EJECT_MEDIA and the "cache" can effectively go away. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9927

2 2

Re: [PATCH v2 0/5] MR9922: winevulkan: Misc make_vulkan extensions refactoring. - approved
by Alexandre Julliard (＠julliard) 20 Jan '26

20 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9922

1 0

Re: [PATCH v6 0/2] MR9882: kernelbase: Trim whitespaces from the quoted 'cmdline' - approved
by Alexandre Julliard (＠julliard) 20 Jan '26

20 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9882

1 0

Re: [PATCH v3 0/2] MR9466: gitlab: Install some missing dependencies. - approved
by Alexandre Julliard (＠julliard) 20 Jan '26

20 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9466

1 0

Re: [PATCH v2 0/1] MR9906: ntdll: Make VEH registration structure compatible. - approved
by Alexandre Julliard (＠julliard) 19 Jan '26

19 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9906

1 0

Re: [PATCH v2 0/1] MR9919: advapi32: Use same default values for both GetEffectiveRightsFromAclA/W - approved
by Alexandre Julliard (＠julliard) 19 Jan '26

19 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9919

1 0

Re: [PATCH v2 0/1] MR9924: include: Move intrinsic pragmas below function declarations. - approved
by Alexandre Julliard (＠julliard) 19 Jan '26

19 Jan '26

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9924

1 0